From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26097 invoked by alias); 16 Oct 2014 19:01:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26086 invoked by uid 89); 16 Oct 2014 19:01:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ob0-f173.google.com Received: from mail-ob0-f173.google.com (HELO mail-ob0-f173.google.com) (209.85.214.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 19:01:18 +0000 Received: by mail-ob0-f173.google.com with SMTP id wp4so3421642obc.4 for ; Thu, 16 Oct 2014 12:01:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=UnOR+iBtYWnYqzs0fqfpf7boj6XNg29q/Cyr9QVcatw=; b=BMcBId/IONG5z1VYZxZJtsnnJWp+oUFXzC6THkl5Ewa2c6OaZWwlmXJnv/x+3Obzk0 rid/QFAQRwD7K8odRHRgnsRxjsH3j629pK3WUnibvz7o+yNkfBG7LuBZ+U8ulObSsH5F Ve6AX/W8FHD06a0N+IoK4qTHlJVyw3buj+DvH2jHLa2LJ86cz3XSYk6Xy+L5U0q3+3fu duelqJEap+ff6B7V3dNmpE8L2s/MQ79EPZ+AV6y7+kgRSTRNjmShfjNCYXz2SW7yLvtq 8QLnsQKtJwKiSTTbSeVjmfJFXdGEUH8ll2NEo6kSHjmLg24BlgJMfGMRSF9/ehouyd3e RXNQ== X-Gm-Message-State: ALoCoQm2TWIcgKMiE/b2Efi68pSxNfngOZkm+EsuvK0WSDJL3Wdrvj+jwQ7YHOkFNOEx/b80Cpd7 MIME-Version: 1.0 X-Received: by 10.202.48.212 with SMTP id w203mr2496944oiw.30.1413486076977; Thu, 16 Oct 2014 12:01:16 -0700 (PDT) Received: by 10.202.197.13 with HTTP; Thu, 16 Oct 2014 12:01:16 -0700 (PDT) In-Reply-To: References: Date: Thu, 16 Oct 2014 19:01:00 -0000 Message-ID: Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference From: Siva Chandra To: Doug Evans , gdb-patches Cc: Sergio Durigan Junior , Pedro Alves Content-Type: multipart/mixed; boundary=001a113cdb9e83b18605058edfc2 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00438.txt.bz2 --001a113cdb9e83b18605058edfc2 Content-Type: text/plain; charset=UTF-8 Content-length: 348 The patch updated with a test case is attached. gdb/ChangeLog: * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE on the arg type of a constructor only if it is of reference type. gdb/testsuite/ChangeLog: * gdb.cp/non-trivial-retval.cc: Add a test case. * gdb.cp/non-trivial-retval.exp: Add a test. --001a113cdb9e83b18605058edfc2 Content-Type: text/plain; charset=US-ASCII; name="gnuv3_pass_by_reference_v2.txt" Content-Disposition: attachment; filename="gnuv3_pass_by_reference_v2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i1cgvwtc1 Content-length: 2693 ZGlmZiAtLWdpdCBhL2dkYi9nbnUtdjMtYWJpLmMgYi9nZGIvZ251LXYzLWFi aS5jCmluZGV4IGE2YzZmOWYuLmI5NjBhYTMgMTAwNjQ0Ci0tLSBhL2dkYi9n bnUtdjMtYWJpLmMKKysrIGIvZ2RiL2dudS12My1hYmkuYwpAQCAtMTMyMCwx MyArMTMyMCwxNSBAQCBnbnV2M19wYXNzX2J5X3JlZmVyZW5jZSAoc3RydWN0 IHR5cGUgKnR5cGUpCiAJaWYgKFRZUEVfTkZJRUxEUyAoZmllbGR0eXBlKSA9 PSAyKQogCSAgewogCSAgICBzdHJ1Y3QgdHlwZSAqYXJnX3R5cGUgPSBUWVBF X0ZJRUxEX1RZUEUgKGZpZWxkdHlwZSwgMSk7Ci0JICAgIHN0cnVjdCB0eXBl ICphcmdfdGFyZ2V0X3R5cGU7CiAKLQkgICAgYXJnX3RhcmdldF90eXBlID0g Y2hlY2tfdHlwZWRlZiAoVFlQRV9UQVJHRVRfVFlQRSAoYXJnX3R5cGUpKTsK KwkgICAgaWYgKFRZUEVfQ09ERSAoYXJnX3R5cGUpID09IFRZUEVfQ09ERV9S RUYpCisJICAgICAgeworCQlzdHJ1Y3QgdHlwZSAqYXJnX3RhcmdldF90eXBl OwogCi0JICAgIGlmIChUWVBFX0NPREUgKGFyZ190eXBlKSA9PSBUWVBFX0NP REVfUkVGCi0JCSYmIGNsYXNzX3R5cGVzX3NhbWVfcCAoYXJnX3RhcmdldF90 eXBlLCB0eXBlKSkKLQkgICAgICByZXR1cm4gMTsKKwkgICAgICAgIGFyZ190 YXJnZXRfdHlwZSA9IGNoZWNrX3R5cGVkZWYgKFRZUEVfVEFSR0VUX1RZUEUg KGFyZ190eXBlKSk7CisJCWlmIChjbGFzc190eXBlc19zYW1lX3AgKGFyZ190 YXJnZXRfdHlwZSwgdHlwZSkpCisJCSAgcmV0dXJuIDE7CisJICAgICAgfQog CSAgfQogICAgICAgfQogCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dk Yi5jcC9ub24tdHJpdmlhbC1yZXR2YWwuY2MgYi9nZGIvdGVzdHN1aXRlL2dk Yi5jcC9ub24tdHJpdmlhbC1yZXR2YWwuY2MKaW5kZXggODM4MmY0MC4uYWVi Nzg3NSAxMDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuY3Avbm9uLXRy aXZpYWwtcmV0dmFsLmNjCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLmNwL25v bi10cml2aWFsLXJldHZhbC5jYwpAQCAtNjMsNiArNjMsMzMgQEAgZjIgKGlu dCBpMSwgaW50IGkyKQogICByZXR1cm4gYjsKIH0KIAorY2xhc3MgQjEKK3sK K3B1YmxpYzoKKyAgQjEgKCkge30KKyAgQjEgKGludCBpKTsgIC8qIFB1dCB0 aGlzIGRlY2wgYmVmb3JlIHRoZSBjb3B5LWN0b3IgZGVjbC4gICovCisgIEIx IChjb25zdCBCMSAmb2JqKTsKKworICBpbnQgYjE7Cit9OworCitCMTo6QjEg KGNvbnN0IEIxICZvYmopCit7CisgIGIxID0gb2JqLmIxOworfQorCitCMTo6 QjEgKGludCBpKSA6IGIxIChpKSB7IH0KKworQjEKK2YyMiAoaW50IGkxLCBp bnQgaTIpCit7CisgIEIxIGIxOworCisgIGIxLmIxID0gaTEgKyBpMjsKKwor ICByZXR1cm4gYjE7Cit9CisKIGNsYXNzIEMKIHsKIHB1YmxpYzoKZGlmZiAt LWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmNwL25vbi10cml2aWFsLXJldHZh bC5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5jcC9ub24tdHJpdmlhbC1yZXR2 YWwuZXhwCmluZGV4IDc5MzQ5NDYuLjM0NTBhOTQgMTAwNjQ0Ci0tLSBhL2dk Yi90ZXN0c3VpdGUvZ2RiLmNwL25vbi10cml2aWFsLXJldHZhbC5leHAKKysr IGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuY3Avbm9uLXRyaXZpYWwtcmV0dmFsLmV4 cApAQCAtMzIsNSArMzIsNiBAQCBnZGJfY29udGludWVfdG9fYnJlYWtwb2lu dCAiQnJlYWsgaGVyZSIKIAogZ2RiX3Rlc3QgInAgZjEgKGkxLCBpMikiICIu KiA9IHthID0gMTIzfSIgInAgZjEgKGkxLCBpMikiCiBnZGJfdGVzdCAicCBm MiAoaTEsIGkyKSIgIi4qID0ge2IgPSAxMjN9IiAicCBmMiAoaTEsIGkyKSIK K2dkYl90ZXN0ICJwIGYyMiAoaTEsIGkyKSIgIi4qID0ge2IxID0gMTIzfSIg InAgZjIyIChpMSwgaTIpIgogZ2RiX3Rlc3QgInAgZjMgKGkxLCBpMikiICIu KiA9IHsuKiBjID0gMTIzfSIgInAgZjMgKGkxLCBpMikiCiBnZGJfdGVzdCAi cCBmNCAoaTEsIGkyKSIgIi4qID0gey4qIGUgPSAxMjN9IiAicCBmNCAoaTEs IGkyKSIK --001a113cdb9e83b18605058edfc2--