From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4879 invoked by alias); 18 Apr 2012 19:31:40 -0000 Received: (qmail 4868 invoked by uid 22791); 18 Apr 2012 19:31:39 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qc0-f169.google.com (HELO mail-qc0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 19:31:06 +0000 Received: by qcsd16 with SMTP id d16so5493638qcs.0 for ; Wed, 18 Apr 2012 12:31:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=e1J9h05SiJiCR9f+CyjzYMTa8UmyR31QgjkhRET1+qw=; b=hj9GRwDpsXEkQdprwezy/4z9A+7XFa6OzfJvVOimnBz+BuasGVFvdKSTVUWJ6Mmns7 uNMRuwEMvGIg3gwUupmZFJ+NBeR1RdNAjstDRzpGJ7MJeyA4mFdKVQBD4iyTE5CnzkdS fB0VtQtcIjbpriYkRRVuQdARJFNomM6xyez7t9OcKyuyG0V749Wb3BwMMZke8eNl9sZv ObD9jWqZ88a6NxIjQsbhlD+uLfZgOX5ZFod+MxUy3/5wWEeOlDymsDFGAWkKg6Izkf3d Fpdj9yOBDhWJCWma6Fb0LnOkIYWNWSvmztMY3SrWrrwJY4XHPvtBiOEclnr8LKZpLocu SXXg== Received: by 10.224.175.67 with SMTP id w3mr5359247qaz.82.1334777465764; Wed, 18 Apr 2012 12:31:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.175.67 with SMTP id w3mr5359229qaz.82.1334777465632; Wed, 18 Apr 2012 12:31:05 -0700 (PDT) Received: by 10.224.35.2 with HTTP; Wed, 18 Apr 2012 12:31:05 -0700 (PDT) In-Reply-To: <87ty0hotrk.fsf@fleche.redhat.com> References: <87vckytg9a.fsf@fleche.redhat.com> <87ty0hotrk.fsf@fleche.redhat.com> Date: Wed, 18 Apr 2012 19:53:00 -0000 Message-ID: Subject: Re: [RFC - Python scripting] New methods Symtab.global_block and Symtab.static_block (docs included) From: Siva Chandra To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQlA/3VzXD+tJRh0fiuC3j9oFrjYpxXZKGpBwzOAsMDgq3hxLvWdSyeYtmqVTs6DYjipf787N5Gz6iQFrtjYUbogL3xRTxpKuOpDN3YrGYiiDcWN8TFi6Xn2B2ZHWWi37ikk6Vk1d/4UkDz6QdacMlAmMk3tGQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00604.txt.bz2 Siva> + =A0block =3D symtab->blockvector->block[GLOBAL_BLOCK]; Siva> + =A0block =3D symtab->blockvector->block[STATIC_BLOCK]; Tom> These two spots should use the BLOCKVECTOR accessor macro. Tom> I forgot that we also have blockvector accessors. Tom> So, could you change these to use BLOCKVECTOR_BLOCK as well? I have already done this in the updated patch I have sent today: http://sourceware.org/ml/gdb-patches/2012-04/msg00543.html Thanks, Siva Chandra