From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16304 invoked by alias); 15 Apr 2013 18:59:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16295 invoked by uid 89); 15 Apr 2013 18:59:01 -0000 X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-ea0-f177.google.com (HELO mail-ea0-f177.google.com) (209.85.215.177) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Apr 2013 18:59:01 +0000 Received: by mail-ea0-f177.google.com with SMTP id q14so2327437eaj.22 for ; Mon, 15 Apr 2013 11:58:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=sDXC/j4L20+hHven9+OdnBnvXe04xzPbV4xrpwZQWwA=; b=ouIxBRl637u+/vdz/8ob2TMQ9nTa8+VYYDsEgnD4DNDCvMuEJfPNggmJuion2EDPJO Ppi7yQrtkb+19ixegHiDEKdZRslyTjViRrDPCbtOS10f+1GTDvpMYwHBeNY4Dl1tRXb6 mnDQphFNP6k3PpGNqxVu5dMhNghafILgjKfubplVXjg/gMN0s4a+9H6bJCBKPqt9jv3F YUic6y7ZkPYIpY0JVEWVVd74HW2T1gAtT47a9MIkl0hJhjAVgQxmKQsf3hPLJIm1ONYz C9iWUKWxLO8VsKnie35LJyIgGA2FUGzs+3LNkaSx4tVA5B/cyVRtCc/LAzd8mbfiX+O2 BKGA== MIME-Version: 1.0 X-Received: by 10.14.87.199 with SMTP id y47mr41779469eee.17.1366052338544; Mon, 15 Apr 2013 11:58:58 -0700 (PDT) Received: by 10.15.22.70 with HTTP; Mon, 15 Apr 2013 11:58:58 -0700 (PDT) In-Reply-To: <516C0D67.7020307@redhat.com> References: <8761zrfox7.fsf@fleche.redhat.com> <516C0D67.7020307@redhat.com> Date: Tue, 16 Apr 2013 05:39:00 -0000 Message-ID: Subject: Re: [RFC][testsuite] Add option to link testcases with pthreads when using 'prepare_for_testing' From: Siva Chandra To: Pedro Alves Cc: Tom Tromey , gdb-patches Content-Type: multipart/mixed; boundary=001a11c29c60627c0b04da6ad8ba X-Gm-Message-State: ALoCoQn8S5aorxiXYd7YVP4FDdzjznmNJ5+6/oqMNEdYiuFUMQlwcJEU64Wkf9r4gOs3l40GZm9ogtJLtFE/fmwfvJVe+GC4Gz17v8QlX+yhpjEkh3YMk3jyU5IAlNapXZ3xShk5pMz9hLwj4GSLk6gMbIJjhNRAUx7nqkWthbaCvTlYwDaFV/Lsm+TQX8rFDirApbOc2oVuDY02/SwkRLkRqEmNhpYc7w== X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00442.txt.bz2 --001a11c29c60627c0b04da6ad8ba Content-Type: text/plain; charset=ISO-8859-1 Content-length: 613 On Mon, Apr 15, 2013 at 7:23 AM, Pedro Alves wrote: > Super nit, but do we need "with_" ? We don't say "with_debug" or > "with_nowarnings" either. I'd suggest just "pthread". Singular, as > GNU uses -pthread / -lpthread. Done. Please find the patch attached. 2013-04-15 Siva Chandra Reddy Add option to link testcases with Pthreads library when using 'prepare_for_testing' in tests. testsuite/ * lib/gdb.exp (build_executable_from_specs): Use gdb_compile_pthreads to compile if option "pthreads" is specified. --001a11c29c60627c0b04da6ad8ba Content-Type: text/plain; charset=US-ASCII; name="pthreads_option_patch.txt" Content-Disposition: attachment; filename="pthreads_option_patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfk08r630 Content-length: 2135 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAgYi9nZGIv dGVzdHN1aXRlL2xpYi9nZGIuZXhwCmluZGV4IDMyNzNiZjQuLjA2ZTEyMjYg MTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAKKysrIGIv Z2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cApAQCAtMzk5NSw3ICszOTk1LDgg QEAgcHJvYyB0ZXN0X3ByZWZpeF9jb21tYW5kX2hlbHAgeyBjb21tYW5kX2xp c3QgZXhwZWN0ZWRfaW5pdGlhbF9saW5lcyBhcmdzIH0gewogIyBkaWZmZXJl bnQgb3B0aW9ucyB0byBiZSBwYXNzZWQgdG8gZGlmZmVyZW50IHN1Yi1jb21w aWxhdGlvbnMuCiAjIFRFU1ROQU1FIGlzIHRoZSBuYW1lIG9mIHRoZSB0ZXN0 OyB0aGlzIGlzIHBhc3NlZCB0byAndW50ZXN0ZWQnIGlmCiAjIHNvbWV0aGlu ZyBmYWlscy4KLSMgT1BUSU9OUyBpcyBwYXNzZWQgdG8gdGhlIGZpbmFsIGxp bmssIHVzaW5nIGdkYl9jb21waWxlLgorIyBPUFRJT05TIGlzIHBhc3NlZCB0 byB0aGUgZmluYWwgbGluaywgdXNpbmcgZ2RiX2NvbXBpbGUuICBJZiBPUFRJ T05TCisjIGNvbnRhaW5zIHRoZSBvcHRpb24gInB0aHJlYWRzIiwgdGhlbiBn ZGJfY29tcGlsZV9wdGhyZWFkcyBpcyB1c2VkLgogIyBBUkdTIGlzIGEgZmxh dCBsaXN0IG9mIHNvdXJjZSBzcGVjaWZpY2F0aW9ucywgb2YgdGhlIGZvcm06 CiAjICAgIHsgU09VUkNFMSBPUFRJT05TMSBbIFNPVVJDRTIgT1BUSU9OUzIg XS4uLiB9CiAjIEVhY2ggU09VUkNFIGlzIGNvbXBpbGVkIHRvIGFuIG9iamVj dCBmaWxlIHVzaW5nIGl0cyBPUFRJT05TLApAQCAtNDAxNywxMCArNDAxOCwx OSBAQCBwcm9jIGJ1aWxkX2V4ZWN1dGFibGVfZnJvbV9zcGVjcyB7dGVzdG5h bWUgZXhlY3V0YWJsZSBvcHRpb25zIGFyZ3N9IHsKICAgICAgICAgbGFwcGVu ZCBvYmplY3RzICIke2JpbmZpbGV9JHtpfS5vIgogCWluY3IgaQogICAgIH0K LSAgICAKLSAgICBpZiAgeyBbZ2RiX2NvbXBpbGUgJG9iamVjdHMgIiR7Ymlu ZmlsZX0iIGV4ZWN1dGFibGUgJG9wdGlvbnNdICE9ICIiIH0gewotICAgICAg ICB1bnRlc3RlZCAkdGVzdG5hbWUKLSAgICAgICAgcmV0dXJuIC0xCisKKyAg ICBzZXQgcHRocmVhZHMgW2xzZWFyY2ggLWV4YWN0ICRvcHRpb25zICJwdGhy ZWFkcyJdCisgICAgaWYgeyAkcHRocmVhZHMgPj0gMCB9IHsKKyAgICAgICAg c2V0IG9wdGlvbnMgW2xyZXBsYWNlICRvcHRpb25zICRwdGhyZWFkcyAkcHRo cmVhZHNdCisgICAgICAgIGlmICB7IFtnZGJfY29tcGlsZV9wdGhyZWFkcyAk b2JqZWN0cyAiJHtiaW5maWxlfSIgZXhlY3V0YWJsZSAkb3B0aW9uc10gIT0g IiIgfSB7CisgICAgICAgICAgICB1bnRlc3RlZCAkdGVzdG5hbWUKKyAgICAg ICAgICAgIHJldHVybiAtMQorICAgICAgICB9CisgICAgfSBlbHNlIHsKKyAg ICAgICAgaWYgIHsgW2dkYl9jb21waWxlICRvYmplY3RzICIke2JpbmZpbGV9 IiBleGVjdXRhYmxlICRvcHRpb25zXSAhPSAiIiB9IHsKKyAgICAgICAgICAg IHVudGVzdGVkICR0ZXN0bmFtZQorICAgICAgICAgICAgcmV0dXJuIC0xCisg ICAgICAgIH0KICAgICB9CiAKICAgICBzZXQgaW5mb19vcHRpb25zICIiCg== --001a11c29c60627c0b04da6ad8ba--