From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28227 invoked by alias); 29 Apr 2014 13:49:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28150 invoked by uid 89); 29 Apr 2014 13:49:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f175.google.com Received: from mail-wi0-f175.google.com (HELO mail-wi0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 29 Apr 2014 13:49:27 +0000 Received: by mail-wi0-f175.google.com with SMTP id cc10so7433983wib.14 for ; Tue, 29 Apr 2014 06:49:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=p/C2zCZQNNrDJAmN7U2ZyO3+vvbZyQuPSj7sBPvsEUY=; b=KiOHtbXmETbHo8pibJKFFkynNwhNbcnyjEG1ks7g47vftVA5QOPIw4tMRCyYNAoVXr xnnnU6TgKllJG3d8Doj4hgqVrl6zFtcNdmWIA3rHd95ZkYXZ93e/3xv8uaA/+S9MAcbj NbQEjPyWqd68V+82ggDKMw+H+EV24XfqzzlgW/r++hSVBFX5DMuQs47z019jbpPkw8pJ b/Zbp3YOgbGwCEjnFnQOy1qvqDvUO5+rjwr8iknzcKcHWiuSL+2ImFu9RwTUxlThY0Yp NmMXpV574c8z7Vcx4PK42V9y5O8DWR/3Ixt//GKVVI+iblynIW6cAtHKsub27nhyqboo 7alA== X-Gm-Message-State: ALoCoQmq5QUoQfKpKmBPg1uLUiY4QzZA2M8HIXmVzP0B9EGY2cxABNxC+Hg8XAPaVN1Pfv2VM0feQLRukfEgSCwHriI+jSktAMFppDzrlUzHP64UD4vyb/R9YM/O4FDpx2x8fyRCMuldh3ZU+OxEemPvE5t1B2Y7lScIkprfcLF435cT2FtAjkLBKVVCBTdpuxFr0JNuKF8DJnsoi5CnvoGeKHndrQX3qA== MIME-Version: 1.0 X-Received: by 10.194.187.50 with SMTP id fp18mr554333wjc.89.1398779362972; Tue, 29 Apr 2014 06:49:22 -0700 (PDT) Received: by 10.217.51.7 with HTTP; Tue, 29 Apr 2014 06:49:22 -0700 (PDT) Date: Tue, 29 Apr 2014 13:49:00 -0000 Message-ID: Subject: [PATCH] Remove unused arguments to few functions in dwarf2loc.c and gdbtypes.c. From: Siva Chandra To: gdb-patches Content-Type: multipart/mixed; boundary=047d7bb03b4e0d5cb004f82eb39d X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00613.txt.bz2 --047d7bb03b4e0d5cb004f82eb39d Content-Type: text/plain; charset=UTF-8 Content-length: 1799 The attached patch removes unused arguments to few recently added (few as recent as yesterday) functions. I did not see any reasoning as to why they exist in the patch posts to gdb-patches. I did some digging as to why the unused args could be useful at all. For example, one function touched by the attached patch is dwarf2loc:dwarf2_evaluate_property. Before this patch, this function required an (eventually) unused argument of type CORE_ADDR. I think the intention there was correct: A dynamic property is probably embedded in the value and hence the value address is required to evaluate it. However, the patch that added this function added c99 vla support. I think the array lengths for VLAs are not embedded in the (array) object but somewhere else (the stack frame for example). Hence, the value address is not required. Am I missing something here? [One property for which the value address could be useful is when evaluating bitpos of virtual base class fields. However, in the Python API for example, one looks up bitpos via gdb.Field.bitpos where the field object is typically got via gdb.Type.fields() and not via a gdb.Value object. Hence, dwarf2loc:dwarf2_evaluate_property is not really useful with or without the CORE_ADDR argument for this. I am working on a patch which looks up the bitpos of virtual base classes dynamically via the vtable of the class.] gdb/ChangeLog: 2014-04-29 Siva Chandra Reddy * dwarf2loc.c (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property): Remove unused CORE_ADDR argument. Update all callers. * dwarf2loc.h (dwarf2_evaluate_property): Update signature. * gdbtypes.c (resolve_dynamic_range, resolve_dynamic_array): Remove unused CORE_ADDR argument. Update all callers. --047d7bb03b4e0d5cb004f82eb39d Content-Type: text/plain; charset=US-ASCII; name="remove_unused_args_v1.txt" Content-Disposition: attachment; filename="remove_unused_args_v1.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hul800pz0 Content-length: 5413 ZGlmZiAtLWdpdCBhL2dkYi9kd2FyZjJsb2MuYyBiL2dkYi9kd2FyZjJsb2Mu YwppbmRleCBmYTE3ZWE2Li41NTE3NDQyIDEwMDY0NAotLS0gYS9nZGIvZHdh cmYybG9jLmMKKysrIGIvZ2RiL2R3YXJmMmxvYy5jCkBAIC0yNDM2LDcgKzI0 MzYsNyBAQCBkd2FyZjJfZXZhbHVhdGVfbG9jX2Rlc2MgKHN0cnVjdCB0eXBl ICp0eXBlLCBzdHJ1Y3QgZnJhbWVfaW5mbyAqZnJhbWUsCiAKIHN0YXRpYyBp bnQKIGR3YXJmMl9sb2NleHByX2JhdG9uX2V2YWwgKGNvbnN0IHN0cnVjdCBk d2FyZjJfbG9jZXhwcl9iYXRvbiAqZGxiYXRvbiwKLQkJCSAgIENPUkVfQURE UiBhZGRyLCBDT1JFX0FERFIgKnZhbHApCisJCQkgICBDT1JFX0FERFIgKnZh bHApCiB7CiAgIHN0cnVjdCBkd2FyZl9leHByX2NvbnRleHQgKmN0eDsKICAg c3RydWN0IGR3YXJmX2V4cHJfYmF0b24gYmF0b247CkBAIC0yNDkxLDggKzI0 OTEsNyBAQCBkd2FyZjJfbG9jZXhwcl9iYXRvbl9ldmFsIChjb25zdCBzdHJ1 Y3QgZHdhcmYyX2xvY2V4cHJfYmF0b24gKmRsYmF0b24sCiAvKiBTZWUgZHdh cmYybG9jLmguICAqLwogCiBpbnQKLWR3YXJmMl9ldmFsdWF0ZV9wcm9wZXJ0 eSAoY29uc3Qgc3RydWN0IGR5bmFtaWNfcHJvcCAqcHJvcCwgQ09SRV9BRERS IGFkZHJlc3MsCi0JCQkgIENPUkVfQUREUiAqdmFsdWUpCitkd2FyZjJfZXZh bHVhdGVfcHJvcGVydHkgKGNvbnN0IHN0cnVjdCBkeW5hbWljX3Byb3AgKnBy b3AsIENPUkVfQUREUiAqdmFsdWUpCiB7CiAgIGlmIChwcm9wID09IE5VTEwp CiAgICAgcmV0dXJuIDA7CkBAIC0yNTAzLDcgKzI1MDIsNyBAQCBkd2FyZjJf ZXZhbHVhdGVfcHJvcGVydHkgKGNvbnN0IHN0cnVjdCBkeW5hbWljX3Byb3Ag KnByb3AsIENPUkVfQUREUiBhZGRyZXNzLAogICAgICAgewogCWNvbnN0IHN0 cnVjdCBkd2FyZjJfcHJvcGVydHlfYmF0b24gKmJhdG9uID0gcHJvcC0+ZGF0 YS5iYXRvbjsKIAotCWlmIChkd2FyZjJfbG9jZXhwcl9iYXRvbl9ldmFsICgm YmF0b24tPmxvY2V4cHIsIGFkZHJlc3MsIHZhbHVlKSkKKwlpZiAoZHdhcmYy X2xvY2V4cHJfYmF0b25fZXZhbCAoJmJhdG9uLT5sb2NleHByLCB2YWx1ZSkp CiAJICB7CiAJICAgIGlmIChiYXRvbi0+cmVmZXJlbmNlZF90eXBlKQogCSAg ICAgIHsKZGlmZiAtLWdpdCBhL2dkYi9kd2FyZjJsb2MuaCBiL2dkYi9kd2Fy ZjJsb2MuaAppbmRleCAzNjE3M2M1Li44YWQ1ZmE5IDEwMDY0NAotLS0gYS9n ZGIvZHdhcmYybG9jLmgKKysrIGIvZ2RiL2R3YXJmMmxvYy5oCkBAIC05Niw3 ICs5Niw3IEBAIHN0cnVjdCB2YWx1ZSAqZHdhcmYyX2V2YWx1YXRlX2xvY19k ZXNjIChzdHJ1Y3QgdHlwZSAqdHlwZSwKICAgIGludG8gVkFMVUUsIG90aGVy d2lzZSByZXR1cm5zIDAuICAqLwogCiBpbnQgZHdhcmYyX2V2YWx1YXRlX3By b3BlcnR5IChjb25zdCBzdHJ1Y3QgZHluYW1pY19wcm9wICpwcm9wLAotCQkJ ICAgICAgQ09SRV9BRERSIGFkZHIsIENPUkVfQUREUiAqdmFsdWUpOworCQkJ ICAgICAgQ09SRV9BRERSICp2YWx1ZSk7CiAKIENPUkVfQUREUiBkd2FyZjJf cmVhZF9hZGRyX2luZGV4IChzdHJ1Y3QgZHdhcmYyX3Blcl9jdV9kYXRhICpw ZXJfY3UsCiAJCQkJICB1bnNpZ25lZCBpbnQgYWRkcl9pbmRleCk7CmRpZmYg LS1naXQgYS9nZGIvZ2RidHlwZXMuYyBiL2dkYi9nZGJ0eXBlcy5jCmluZGV4 IDFhMDc0MjAuLjhlNjYzMWEgMTAwNjQ0Ci0tLSBhL2dkYi9nZGJ0eXBlcy5j CisrKyBiL2dkYi9nZGJ0eXBlcy5jCkBAIC0xNjQ2LDcgKzE2NDYsNyBAQCBp c19keW5hbWljX3R5cGUgKHN0cnVjdCB0eXBlICp0eXBlKQogfQogCiBzdGF0 aWMgc3RydWN0IHR5cGUgKgotcmVzb2x2ZV9keW5hbWljX3JhbmdlIChzdHJ1 Y3QgdHlwZSAqZHluX3JhbmdlX3R5cGUsIENPUkVfQUREUiBhZGRyKQorcmVz b2x2ZV9keW5hbWljX3JhbmdlIChzdHJ1Y3QgdHlwZSAqZHluX3JhbmdlX3R5 cGUpCiB7CiAgIENPUkVfQUREUiB2YWx1ZTsKICAgc3RydWN0IHR5cGUgKnN0 YXRpY19yYW5nZV90eXBlOwpAQCAtMTY1Nyw3ICsxNjU3LDcgQEAgcmVzb2x2 ZV9keW5hbWljX3JhbmdlIChzdHJ1Y3QgdHlwZSAqZHluX3JhbmdlX3R5cGUs IENPUkVfQUREUiBhZGRyKQogICBnZGJfYXNzZXJ0IChUWVBFX0NPREUgKGR5 bl9yYW5nZV90eXBlKSA9PSBUWVBFX0NPREVfUkFOR0UpOwogCiAgIHByb3Ag PSAmVFlQRV9SQU5HRV9EQVRBIChkeW5fcmFuZ2VfdHlwZSktPmxvdzsKLSAg aWYgKGR3YXJmMl9ldmFsdWF0ZV9wcm9wZXJ0eSAocHJvcCwgYWRkciwgJnZh bHVlKSkKKyAgaWYgKGR3YXJmMl9ldmFsdWF0ZV9wcm9wZXJ0eSAocHJvcCwg JnZhbHVlKSkKICAgICB7CiAgICAgICBsb3dfYm91bmQua2luZCA9IFBST1Bf Q09OU1Q7CiAgICAgICBsb3dfYm91bmQuZGF0YS5jb25zdF92YWwgPSB2YWx1 ZTsKQEAgLTE2NjksNyArMTY2OSw3IEBAIHJlc29sdmVfZHluYW1pY19yYW5n ZSAoc3RydWN0IHR5cGUgKmR5bl9yYW5nZV90eXBlLCBDT1JFX0FERFIgYWRk cikKICAgICB9CiAKICAgcHJvcCA9ICZUWVBFX1JBTkdFX0RBVEEgKGR5bl9y YW5nZV90eXBlKS0+aGlnaDsKLSAgaWYgKGR3YXJmMl9ldmFsdWF0ZV9wcm9w ZXJ0eSAocHJvcCwgYWRkciwgJnZhbHVlKSkKKyAgaWYgKGR3YXJmMl9ldmFs dWF0ZV9wcm9wZXJ0eSAocHJvcCwgJnZhbHVlKSkKICAgICB7CiAgICAgICBo aWdoX2JvdW5kLmtpbmQgPSBQUk9QX0NPTlNUOwogICAgICAgaGlnaF9ib3Vu ZC5kYXRhLmNvbnN0X3ZhbCA9IHZhbHVlOwpAQCAtMTY5Niw3ICsxNjk2LDcg QEAgcmVzb2x2ZV9keW5hbWljX3JhbmdlIChzdHJ1Y3QgdHlwZSAqZHluX3Jh bmdlX3R5cGUsIENPUkVfQUREUiBhZGRyKQogICAgb2YgdGhlIGFzc29jaWF0 ZWQgYXJyYXkuICAqLwogCiBzdGF0aWMgc3RydWN0IHR5cGUgKgotcmVzb2x2 ZV9keW5hbWljX2FycmF5IChzdHJ1Y3QgdHlwZSAqdHlwZSwgQ09SRV9BRERS IGFkZHIpCityZXNvbHZlX2R5bmFtaWNfYXJyYXkgKHN0cnVjdCB0eXBlICp0 eXBlKQogewogICBDT1JFX0FERFIgdmFsdWU7CiAgIHN0cnVjdCB0eXBlICpl bHRfdHlwZTsKQEAgLTE3MDcsMTIgKzE3MDcsMTIgQEAgcmVzb2x2ZV9keW5h bWljX2FycmF5IChzdHJ1Y3QgdHlwZSAqdHlwZSwgQ09SRV9BRERSIGFkZHIp CiAKICAgZWx0X3R5cGUgPSB0eXBlOwogICByYW5nZV90eXBlID0gY2hlY2tf dHlwZWRlZiAoVFlQRV9JTkRFWF9UWVBFIChlbHRfdHlwZSkpOwotICByYW5n ZV90eXBlID0gcmVzb2x2ZV9keW5hbWljX3JhbmdlIChyYW5nZV90eXBlLCBh ZGRyKTsKKyAgcmFuZ2VfdHlwZSA9IHJlc29sdmVfZHluYW1pY19yYW5nZSAo cmFuZ2VfdHlwZSk7CiAKICAgYXJ5X2RpbSA9IGNoZWNrX3R5cGVkZWYgKFRZ UEVfVEFSR0VUX1RZUEUgKGVsdF90eXBlKSk7CiAKICAgaWYgKGFyeV9kaW0g IT0gTlVMTCAmJiBUWVBFX0NPREUgKGFyeV9kaW0pID09IFRZUEVfQ09ERV9B UlJBWSkKLSAgICBlbHRfdHlwZSA9IHJlc29sdmVfZHluYW1pY19hcnJheSAo VFlQRV9UQVJHRVRfVFlQRSAodHlwZSksIGFkZHIpOworICAgIGVsdF90eXBl ID0gcmVzb2x2ZV9keW5hbWljX2FycmF5IChUWVBFX1RBUkdFVF9UWVBFICh0 eXBlKSk7CiAgIGVsc2UKICAgICBlbHRfdHlwZSA9IFRZUEVfVEFSR0VUX1RZ UEUgKHR5cGUpOwogCkBAIC0xNzUxLDExICsxNzUxLDExIEBAIHJlc29sdmVf ZHluYW1pY190eXBlIChzdHJ1Y3QgdHlwZSAqdHlwZSwgQ09SRV9BRERSIGFk ZHIpCiAJfQogCiAgICAgICBjYXNlIFRZUEVfQ09ERV9BUlJBWToKLQlyZXNv bHZlZF90eXBlID0gcmVzb2x2ZV9keW5hbWljX2FycmF5ICh0eXBlLCBhZGRy KTsKKwlyZXNvbHZlZF90eXBlID0gcmVzb2x2ZV9keW5hbWljX2FycmF5ICh0 eXBlKTsKIAlicmVhazsKIAogICAgICAgY2FzZSBUWVBFX0NPREVfUkFOR0U6 Ci0JcmVzb2x2ZWRfdHlwZSA9IHJlc29sdmVfZHluYW1pY19yYW5nZSAodHlw ZSwgYWRkcik7CisJcmVzb2x2ZWRfdHlwZSA9IHJlc29sdmVfZHluYW1pY19y YW5nZSAodHlwZSk7CiAJYnJlYWs7CiAgICAgfQogCg== --047d7bb03b4e0d5cb004f82eb39d--