Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siva Chandra <sivachandra@google.com>
To: gdb-patches@sourceware.org
Cc: Kevin Pouget <kevin.pouget@gmail.com>,
	Eli Zaretskii <eliz@gnu.org>, Doug Evans <dje@google.com>
Subject: Re: [RFC] A new command 'grep'
Date: Tue, 03 Jan 2012 06:02:00 -0000	[thread overview]
Message-ID: <CAGyQ6gxdD7NeyaPpUtAzQkNGqJ+YO0o4YfawffyCjO=-b_DSOw@mail.gmail.com> (raw)
In-Reply-To: <CADPb22R5G=fkb9dVM3=2aRnOvtUpEuhqWXwNqWSZ3VQT-Dj3ig@mail.gmail.com>

On Mon, Jan 2, 2012 at 11:14 PM, Doug Evans <dje@google.com> wrote:
> On Mon, Jan 2, 2012 at 1:28 AM, Kevin Pouget <kevin.pouget@gmail.com> wrote:
>> On Mon, Jan 2, 2012 at 9:54 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>> I think this is the first time we receive a proposal for a command
>>> implemented in Python.  Perhaps there's a place to discuss whether
>>> some policy is in order in this regard.  E.g., the command will be
>>> unavailable in non-Python builds, which at least needs to be
>>> documented.  There may be other aspects that are worth discussing.
>>
>> I'm also curious about that, and maybe first of all, is there a Python
>> specific coding convention likely to be enforced in GNU projects
>> and/or GDB?
>
> Sorry for the repeat.
> [I wasn't aware the mail program I was using would sent it as rich html, sigh.]
>
> For reference sake,
> there are already some gdb commands in python,
> see python/lib/gdb/command.
> The pretty printer support there doesn't need to worry about
> non-python builds of course.
>
> As for coding convention, we follow pep008 with a few additions.
> ref: http://sourceware.org/gdb/current/onlinedocs/gdbint/Coding-Standards.html#Coding-Standards

1. OK. I have verified that my code sticks to PEP008 but for the order
of imports. I will fix that.
2. Eli's query on the policy on general purpose commands implemented
in Python is very relevant. But before that, is this new command I
propose worth having?
3. If yes, then is it a good idea to have general purpose commands
implemented in Python? If not, I will implement this, and the earlier
'explore' command I proposed in C.

Thanks,
Siva Chandra


      reply	other threads:[~2012-01-03  6:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02  5:01 Siva Chandra
2012-01-02  8:54 ` Eli Zaretskii
2012-01-02  9:28   ` Kevin Pouget
2012-01-02  9:35     ` Abhijit Halder
2012-01-02 10:17     ` Siva Chandra
2012-01-02 17:44     ` Doug Evans
2012-01-03  6:02       ` Siva Chandra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGyQ6gxdD7NeyaPpUtAzQkNGqJ+YO0o4YfawffyCjO=-b_DSOw@mail.gmail.com' \
    --to=sivachandra@google.com \
    --cc=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevin.pouget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox