From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1314 invoked by alias); 10 Jun 2014 18:56:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1293 invoked by uid 89); 10 Jun 2014 18:56:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f176.google.com Received: from mail-wi0-f176.google.com (HELO mail-wi0-f176.google.com) (209.85.212.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 10 Jun 2014 18:56:43 +0000 Received: by mail-wi0-f176.google.com with SMTP id n3so4043486wiv.15 for ; Tue, 10 Jun 2014 11:56:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ZsTV+7oOE0JVWak+cdsYhI7lQDL6RhX81XmzTSUD4j0=; b=e/ti0wm5+8pVuip5vdh/XK7AxXemXgklOuiTJDw4Ipp/9vEMfSQpOGR5OzSzd4DPv4 BAEYY8ByCG4KGqYcCgoEMCoYt2gmxW5Z+CGKOhj/2k27xeyV9yfUZ3V6h+sCgbtQC02F 1Fw5EmFu1XQg2EyFxNoJOYJ6vwhspskufCp/L5aH9tjeirA2XYgtbkhUC5TdytkVLhhl zFRQ8UIFOQpdFLrf0PveLnIkx0MGIUQp5A1nU42QgrmofhCiQFS16+4LZZj7sYLf6rPx gmWB24KOgrNe8knKhrXV5EAwA8HwSGjde2CWcofJYvKfE9eZfDuIj1xk2uxWsjQj4IzY c3jw== X-Gm-Message-State: ALoCoQl0zUpndw0KXKF+OFo5w228EjBmMoPF/tFm5xiDSEgDQImaOvQ/thZwwT1VJOKcTrabsY9z MIME-Version: 1.0 X-Received: by 10.180.89.233 with SMTP id br9mr17916455wib.14.1402426600601; Tue, 10 Jun 2014 11:56:40 -0700 (PDT) Received: by 10.217.50.137 with HTTP; Tue, 10 Jun 2014 11:56:40 -0700 (PDT) In-Reply-To: References: <5395BC0D.50709@redhat.com> Date: Tue, 10 Jun 2014 18:56:00 -0000 Message-ID: Subject: Re: [PATCH] Wrap PyObject_Get/HasAttrString in a function with second arg having const qualifier. From: Siva Chandra To: Pedro Alves Cc: gdb-patches , Ulrich Weigand Content-Type: multipart/mixed; boundary=e89a8f3ba0ff5ae58e04fb7fe313 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00429.txt.bz2 --e89a8f3ba0ff5ae58e04fb7fe313 Content-Type: text/plain; charset=UTF-8 Content-length: 226 On Tue, Jun 10, 2014 at 11:56 AM, Siva Chandra wrote: > Thanks for the quick review. I have pushed the attached patch which > includes the doc fixes suggested by Pedro. Ah! The patch is attached now! --e89a8f3ba0ff5ae58e04fb7fe313 Content-Type: text/plain; charset=US-ASCII; name="fix_xmethod_for_2_4_final.txt" Content-Disposition: attachment; filename="fix_xmethod_for_2_4_final.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hw9kl1mg0 Content-length: 2554 ZGlmZiAtLWdpdCBhL2dkYi9weXRob24vcHktdmFsdWUuYyBiL2dkYi9weXRo b24vcHktdmFsdWUuYwppbmRleCA1NGRhNjdhLi44NTMyZGE2IDEwMDY0NAot LS0gYS9nZGIvcHl0aG9uL3B5LXZhbHVlLmMKKysrIGIvZ2RiL3B5dGhvbi9w eS12YWx1ZS5jCkBAIC01NTQsOCArNTU0LDcgQEAgc3RhdGljIGludAogZ2V0 X2ZpZWxkX2ZsYWcgKFB5T2JqZWN0ICpmaWVsZCwgY29uc3QgY2hhciAqZmxh Z19uYW1lKQogewogICBpbnQgZmxhZ192YWx1ZTsKLSAgLyogUHl0aG9uIDIu NCBkaWQgbm90IGhhdmUgYSAnY29uc3QnIGhlcmUuICAqLwotICBQeU9iamVj dCAqZmxhZ19vYmplY3QgPSBQeU9iamVjdF9HZXRBdHRyU3RyaW5nIChmaWVs ZCwgKGNoYXIgKikgZmxhZ19uYW1lKTsKKyAgUHlPYmplY3QgKmZsYWdfb2Jq ZWN0ID0gUHlPYmplY3RfR2V0QXR0clN0cmluZyAoZmllbGQsIGZsYWdfbmFt ZSk7CiAKICAgaWYgKGZsYWdfb2JqZWN0ID09IE5VTEwpCiAgICAgcmV0dXJu IC0xOwpkaWZmIC0tZ2l0IGEvZ2RiL3B5dGhvbi9weXRob24taW50ZXJuYWwu aCBiL2dkYi9weXRob24vcHl0aG9uLWludGVybmFsLmgKaW5kZXggOWMwNjYy MS4uMDE5OGU5ZCAxMDA2NDQKLS0tIGEvZ2RiL3B5dGhvbi9weXRob24taW50 ZXJuYWwuaAorKysgYi9nZGIvcHl0aG9uL3B5dGhvbi1pbnRlcm5hbC5oCkBA IC0xODcsNiArMTg3LDMyIEBAIGdkYl9QeV9ERUNSRUYgKHZvaWQgKm9wKSAv KiBBUkk6IGVkaXRDYXNlIGZ1bmN0aW9uICovCiAjdW5kZWYgUHlfREVDUkVG CiAjZGVmaW5lIFB5X0RFQ1JFRihvcCkgZ2RiX1B5X0RFQ1JFRiAob3ApCiAK Ky8qIFRoZSBzZWNvbmQgYXJndW1lbnQgdG8gUHlPYmplY3RfR2V0QXR0clN0 cmluZyB3YXMgbWlzc2luZyB0aGUgJ2NvbnN0JworICAgcXVhbGlmaWVyIGlu IFB5dGhvbi0yLjQuICBIZW5jZSwgd2Ugd3JhcCBpdCBpbiBhIGZ1bmN0aW9u IHRvIGF2b2lkIGVycm9ycworICAgd2hlbiBjb21waWxlZCB3aXRoIC1XZXJy b3IuICAqLworCitzdGF0aWMgaW5saW5lIFB5T2JqZWN0ICoKK2dkYl9QeU9i amVjdF9HZXRBdHRyU3RyaW5nIChQeU9iamVjdCAqb2JqLAorCQkJICAgIGNv bnN0IGNoYXIgKmF0dHIpIC8qIEFSSTogZWRpdENhc2UgZnVuY3Rpb24gKi8K K3sKKyAgcmV0dXJuIFB5T2JqZWN0X0dldEF0dHJTdHJpbmcgKG9iaiwgKGNo YXIgKikgYXR0cik7Cit9CisKKyNkZWZpbmUgUHlPYmplY3RfR2V0QXR0clN0 cmluZyhvYmosIGF0dHIpIGdkYl9QeU9iamVjdF9HZXRBdHRyU3RyaW5nIChv YmosIGF0dHIpCisKKy8qIFRoZSBzZWNvbmQgYXJndW1lbnQgdG8gUHlPYmpl Y3RfSGFzQXR0clN0cmluZyB3YXMgYWxzbyBtaXNzaW5nIHRoZSAnY29uc3Qn CisgICBxdWFsaWZpZXIgaW4gUHl0aG9uLTIuNC4gIEhlbmNlLCB3ZSB3cmFw IGl0IGFsc28gaW4gYSBmdW5jdGlvbiB0byBhdm9pZAorICAgZXJyb3JzIHdo ZW4gY29tcGlsZWQgd2l0aCAtV2Vycm9yLiAgKi8KKworc3RhdGljIGlubGlu ZSBpbnQKK2dkYl9QeU9iamVjdF9IYXNBdHRyU3RyaW5nIChQeU9iamVjdCAq b2JqLAorCQkJICAgIGNvbnN0IGNoYXIgKmF0dHIpICAvKiBBUkk6IGVkaXRD YXNlIGZ1bmN0aW9uICovCit7CisgIHJldHVybiBQeU9iamVjdF9IYXNBdHRy U3RyaW5nIChvYmosIChjaGFyICopIGF0dHIpOworfQorCisjZGVmaW5lIFB5 T2JqZWN0X0hhc0F0dHJTdHJpbmcob2JqLCBhdHRyKSBnZGJfUHlPYmplY3Rf SGFzQXR0clN0cmluZyAob2JqLCBhdHRyKQorCiAvKiBJbiBvcmRlciB0byBi ZSBhYmxlIHRvIHBhcnNlIHN5bXRhYl9hbmRfbGluZV90b19zYWxfb2JqZWN0 IGZ1bmN0aW9uCiAgICBhIHJlYWwgc3ltdGFiX2FuZF9saW5lIHN0cnVjdHVy ZSBpcyBuZWVkZWQuICAqLwogI2luY2x1ZGUgInN5bXRhYi5oIgo= --e89a8f3ba0ff5ae58e04fb7fe313--