From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98567-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18589 invoked by alias); 15 Feb 2013 20:36:03 -0000
Received: (qmail 18531 invoked by uid 22791); 15 Feb 2013 20:36:02 -0000
X-SWARE-Spam-Status: No, hits=-5.5 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail-ea0-f177.google.com (HELO mail-ea0-f177.google.com) (209.85.215.177)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Feb 2013 20:35:27 +0000
Received: by mail-ea0-f177.google.com with SMTP id n13so1583476eaa.36        for <gdb-patches@sourceware.org>; Fri, 15 Feb 2013 12:35:26 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:x-received:in-reply-to:references:date:message-id         :subject:from:to:cc:content-type:x-gm-message-state;        bh=tZAo+3a2f2Xm6iUGhT1Jhosu9MK3k58NdIF7xQJof+c=;        b=SruGjv+F7mh7NOBorRhXDs2unAr9qHHYMjt57nsF6facr4giFhK7LHa/AEF6WwoSa0         XDTlT+QAGK36x0vzaTiqj3ki+aCffqpBrtxeXf3TL7QyjoDhix5Ma2XduhHsbVgilDyi         3x7EpJgOexzN10PD4eD5ztXfxfOerWO9g36N5mMCnWevOgHYyFf5IOQ+K/2+PbZN0665         ZfSahEbLZnpXUZqSzFdLJDDv3cagurVYovDgn8k95y3ejPi9NmYLiYTRXdum7Pc6a+Py         2/dNxmNedQhVClUsIUAXADl/beqATzNF1H4HGAcUkOiwuu5zb1ZIGj4mBvWsKHGneJ4b         1BWA==
MIME-Version: 1.0
X-Received: by 10.14.178.69 with SMTP id e45mr12410661eem.9.1360960526057; Fri, 15 Feb 2013 12:35:26 -0800 (PST)
Received: by 10.14.207.195 with HTTP; Fri, 15 Feb 2013 12:35:25 -0800 (PST)
In-Reply-To: <20765.55532.700460.792597@ruffy2.mtv.corp.google.com>
References: <CAGyQ6gy_08hZn2Pk6pmD+AuOkH7SCsQ6732KTa7sucZ7-4prUA@mail.gmail.com>	<20753.38272.55066.651097@ruffy2.mtv.corp.google.com>	<CAGyQ6gy68LdCd_qxDX7vinMg-Pb6qnukGScOw2uzgezxKxh_TA@mail.gmail.com>	<CADPb22TGJNFg7VJkeoTB7Ctd=K2Tc490LKo_mdUVXFF2K6TV5g@mail.gmail.com>	<CAGyQ6gweW=9L4mVCkFetd+LvvpjSYzYKM78mYDu5HfG1LpVwiQ@mail.gmail.com>	<87txphmdt3.fsf@fleche.redhat.com>	<CAGyQ6gzSs617BRcreAGA5418EpXaqCaPN8ZzKjQYNx9yxDSJRA@mail.gmail.com>	<87r4kkks5g.fsf@fleche.redhat.com>	<CAGyQ6gwSnFH3OKHSpNxVmVxRRRM61c=T=euhJg6hyFL7+88ecg@mail.gmail.com>	<20763.64197.459891.627211@ruffy2.mtv.corp.google.com>	<CAGyQ6gxOqnD0tr+rR2kuYBr6ub6vN8DvGG5PxA+BO-O8VYXVqA@mail.gmail.com>	<20765.55532.700460.792597@ruffy2.mtv.corp.google.com>
Date: Fri, 15 Feb 2013 20:36:00 -0000
Message-ID: <CAGyQ6gxX7r9QWY+ze9kzyjAwqCf9-kTmor2JRFAoW1mx=x47Kw@mail.gmail.com>
Subject: Re: [RFC - Python Scripting] New method gdb.Architecture.disassemble
From: Siva Chandra <sivachandra@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Cc: Doug Evans <dje@google.com>, Tom Tromey <tromey@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQnpNEdo51cmETWJE+vM3oVYzTxwmrhHFenWu3icft0C6nIClOep+bfsNuMkUQ6EbQLvSIyTAcl+5T09gjpGxtRe8w2ugLTsOrn0m8cEZ+6fFYdLKcHPDkFUwK2qgDzyU5Rsr+jRQ5w/BQ1u+Sa6xeLRi+Mr4RYLcpFeBRGAPH4hPJq7bmsVzp1u0obIFinEm87psBP3IjbZT1grsyzPvH57zlcvCA==
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-02/txt/msg00417.txt.bz2

Fixed all of Doug's nits. Patch attached.

2013-02-15  Siva Chandra Reddy  <sivachandra@google.com>

        Add a new method 'disassemble' to gdb.Architecture class.
        * python/py-arch.c (archpy_disassmble): Implementation of the
        new method gdb.Architecture.disassemble.
        (arch_object_methods): Add entry for the new method.

doc/

        * gdb.texinfo (Architectures In Python): Add description about
        the new method gdb.Architecture.disassemble.

testsuite/

        * gdb.python/py-arch.c: New test case
        * gdb.python/py-arch.exp: New tests to test
        gdb.Architecture.disassemble
        * gdb.python/Makefile.in: Add py-arch to the list of
        EXECUTABLES.

Thanks,
Siva Chandra