From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21825 invoked by alias); 11 May 2012 16:35:09 -0000 Received: (qmail 21090 invoked by uid 22791); 11 May 2012 16:35:07 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f41.google.com (HELO mail-vb0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 16:34:22 +0000 Received: by vbbey12 with SMTP id ey12so3705346vbb.0 for ; Fri, 11 May 2012 09:34:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=u3RNwKO1Tdj4KcOzAZJF8iTZafpgyfwa/yHJZeTQWZk=; b=CXxbtidfcjpaLRmg9Zv7g7Rk1+SHlgFOuwx9YrrIB7YBOypR1NKy739EDBv0S7yCiv z4qcRzuVl+Zb1VGGxAWgThMS/IlIL8lsIE5zNTllzOZHGCvC5mh6v2UbH9Cak3vDsOke J88QfpxL7F+CRRJwflhe/8hcdoJnI5xCUR/hWZQWRMv78GmAdbQJZvbmPt0bOe5OfR8I tFV5rwaALF5wuS98lTznHqog/N590yK2h6Q7/9avo9V5U4Zx4qXZooxXsBUOXIN8IzBg oPr9yRuXOb3krMGejBFqEaknX6Ol+PM6dRblgszSrH4ewiDIQG8TcKTsSsOicQZjSq9+ hOPA== Received: by 10.52.74.69 with SMTP id r5mr4177075vdv.110.1336754061689; Fri, 11 May 2012 09:34:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.74.69 with SMTP id r5mr4177068vdv.110.1336754061602; Fri, 11 May 2012 09:34:21 -0700 (PDT) Received: by 10.52.156.162 with HTTP; Fri, 11 May 2012 09:34:21 -0700 (PDT) In-Reply-To: References: <8362c73huz.fsf@gnu.org> Date: Fri, 11 May 2012 16:35:00 -0000 Message-ID: Subject: Re: [RFC] - Exposing find_pc_line through Python API From: Siva Chandra To: Doug Evans Cc: Eli Zaretskii , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=bcaec5016287fe709a04bfc54ed2 X-System-Of-Record: true X-Gm-Message-State: ALoCoQnio8lIU/zF0J9wuI5WhGy5iBuDejJcBQLgnGtNNlSlJIYOtmN47Sp8QwrUZqfT7yQMlTWpzQFKT4Fzij8LnAiFYvjoFKtKANlQ/Sqr29yT+l0GAha1lLhlFFuPr7J6opDWdVYzATHTKTw9b0w+15ZrB58aow== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00416.txt.bz2 --bcaec5016287fe709a04bfc54ed2 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 891 On Fri, May 11, 2012 at 2:45 AM, Doug Evans wrote: > I think we need to specify what the result is if there is no sal for > the specified pc. > ... > "actual" can be deleted now. I have addressed these two comments. The patch is attached. 2012-05-11 Siva Chandra Reddy Add a new function gdb.find_pc_line to the Python API. * NEWS (Python Scripting): Add entry about the new function. * python/python.c (gdbpy_find_pc_line): New function which implements gdb.find_pc_line. (GdbMethods): Add entry for the new function. doc/ * gdb.texinfo (Basic Python): Add description about the function gdb.find_pc_line testsuite/ * gdb.python/python.c: Add a new breakpoint comment. * gdb.python/python.exp: Add tests to test gdb.find_pc_line. Thanks, Siva Chandra --bcaec5016287fe709a04bfc54ed2 Content-Type: text/plain; charset=US-ASCII; name="pc_line_patch_v3.txt" Content-Disposition: attachment; filename="pc_line_patch_v3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h23gtd9j0 Content-length: 6511 SW5kZXg6IE5FV1MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi9ORVdTLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjUxNApkaWZmIC11IC1wIC1yMS41MTQgTkVXUwotLS0gTkVXUwkzIE1heSAy MDEyIDA3OjA3OjI0IC0wMDAwCTEuNTE0CisrKyBORVdTCTExIE1heSAyMDEy IDE2OjI5OjUyIC0wMDAwCkBAIC00Myw2ICs0Myw5IEBACiAgICAgIHdoaWNo IHJldHVybiB0aGUgZ2xvYmFsIGFuZCBzdGF0aWMgYmxvY2tzIChhcyBnZGIu QmxvY2sgb2JqZWN0cyksCiAgICAgIG9mIHRoZSB1bmRlcmx5aW5nIHN5bWJv bCB0YWJsZSwgcmVzcGVjdGl2ZWx5LgogCisgICoqIE5ldyBmdW5jdGlvbiBn ZGIuZmluZF9wY19saW5lIHdoaWNoIHJldHVybnMgdGhlIGdkYi5TeW10YWJf YW5kX2xpbmUKKyAgICAgb2JqZWN0IGFzc29jaWF0ZWQgd2l0aCBhIFBDIHZh bHVlLgorCiAqIEdvIGxhbmd1YWdlIHN1cHBvcnQuCiAgIEdEQiBub3cgc3Vw cG9ydHMgZGVidWdnaW5nIHByb2dyYW1zIHdyaXR0ZW4gaW4gdGhlIEdvIHBy b2dyYW1taW5nCiAgIGxhbmd1YWdlLgpJbmRleDogZG9jL2dkYi50ZXhpbmZv Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3Ny Yy9nZGIvZG9jL2dkYi50ZXhpbmZvLHYKcmV0cmlldmluZyByZXZpc2lvbiAx Ljk1NwpkaWZmIC11IC1wIC1yMS45NTcgZ2RiLnRleGluZm8KLS0tIGRvYy9n ZGIudGV4aW5mbwk5IE1heSAyMDEyIDE5OjI5OjI1IC0wMDAwCTEuOTU3Cisr KyBkb2MvZ2RiLnRleGluZm8JMTEgTWF5IDIwMTIgMTY6MzA6MTUgLTAwMDAK QEAgLTIyMzk0LDYgKzIyMzk0LDE1IEBAIGNvbXB1dGUgdmFsdWVzLCBmb3Ig ZXhhbXBsZSwgaXQgaXMgdGhlIG8KIGNvbnZlbmllbmNlIHZhcmlhYmxlIChA cHhyZWZ7Q29udmVuaWVuY2UgVmFyc30pIGFzIGEgQGNvZGV7Z2RiLlZhbHVl fS4KIEBlbmQgZGVmdW4KIAorQGZpbmRleCBnZGIuZmluZF9wY19saW5lCitA ZGVmdW4gZ2RiLmZpbmRfcGNfbGluZSAocGMpCitSZXR1cm4gdGhlIEBjb2Rl e2dkYi5TeW10YWJfYW5kX2xpbmV9IG9iamVjdCBjb3JyZXNwb25kaW5nIHRv IHRoZQorQHZhcntwY30gdmFsdWUuICBAeHJlZntTeW1ib2wgVGFibGVzIElu IFB5dGhvbn0uICBJZiBhbiBpbnZhbGlkCit2YWx1ZSBvZiBAdmFye3BjfSBp cyBwYXNzZWQgYXMgYW4gYXJndW1lbnQsIHRoZW4gdGhlIEBjb2Rle3N5bXRh Yn0gYW5kCitAY29kZXtsaW5lfSBhdHRyaWJ1dGVzIG9mIHRoZSByZXR1cm5l ZCBAY29kZXtnZGIuU3ltdGFiX2FuZF9saW5lfSBvYmplY3QKK3dpbGwgYmUg QGNvZGV7Tm9uZX0gYW5kIDAgcmVzcGVjdGl2ZWx5LgorQGVuZCBkZWZ1bgor CiBAZmluZGV4IGdkYi5wb3N0X2V2ZW50CiBAZGVmdW4gZ2RiLnBvc3RfZXZl bnQgKGV2ZW50KQogUHV0IEB2YXJ7ZXZlbnR9LCBhIGNhbGxhYmxlIG9iamVj dCB0YWtpbmcgbm8gYXJndW1lbnRzLCBpbnRvCkluZGV4OiBweXRob24vcHl0 aG9uLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2dkYi9weXRob24vcHl0aG9uLmMsdgpyZXRyaWV2aW5nIHJldmlz aW9uIDEuODYKZGlmZiAtdSAtcCAtcjEuODYgcHl0aG9uLmMKLS0tIHB5dGhv bi9weXRob24uYwkzMCBNYXIgMjAxMiAyMDowNTo1NSAtMDAwMAkxLjg2Cisr KyBweXRob24vcHl0aG9uLmMJMTEgTWF5IDIwMTIgMTY6MzA6MTYgLTAwMDAK QEAgLTYzMSw2ICs2MzEsMjQgQEAgZ2RicHlfcGFyc2VfYW5kX2V2YWwgKFB5 T2JqZWN0ICpzZWxmLCBQeQogICByZXR1cm4gdmFsdWVfdG9fdmFsdWVfb2Jq ZWN0IChyZXN1bHQpOwogfQogCisvKiBJbXBsZW1lbnRhdGlvbiBvZiBnZGIu ZmluZF9wY19saW5lIGZ1bmN0aW9uLgorICAgUmV0dXJucyB0aGUgZ2RiLlN5 bXRhYl9hbmRfbGluZSBvYmplY3QgY29ycmVzcG9uZGluZyB0byBhIFBDIHZh bHVlLiAgKi8KKworc3RhdGljIFB5T2JqZWN0ICoKK2dkYnB5X2ZpbmRfcGNf bGluZSAoUHlPYmplY3QgKnNlbGYsIFB5T2JqZWN0ICphcmdzKQoreworICBz dHJ1Y3Qgc3ltdGFiX2FuZF9saW5lIHNhbDsKKyAgQ09SRV9BRERSIHBjOwor ICB1bnNpZ25lZCBsb25nIGxvbmcgcGNfbGx1OworCisgIGlmICghUHlBcmdf UGFyc2VUdXBsZSAoYXJncywgR0RCX1BZX0xMVV9BUkcsICZwY19sbHUpKQor ICAgIHJldHVybiBOVUxMOworCisgIHBjID0gKENPUkVfQUREUikgcGNfbGx1 OworICBzYWwgPSBmaW5kX3BjX2xpbmUgKHBjLCAwKTsKKyAgcmV0dXJuIHN5 bXRhYl9hbmRfbGluZV90b19zYWxfb2JqZWN0IChzYWwpOworfQorCiAvKiBS ZWFkIGEgZmlsZSBhcyBQeXRob24gY29kZS4KICAgIEZJTEUgaXMgdGhlIGZp bGUgdG8gcnVuLiAgRklMRU5BTUUgaXMgbmFtZSBvZiB0aGUgZmlsZSBGSUxF LgogICAgVGhpcyBkb2VzIG5vdCB0aHJvdyBhbnkgZXJyb3JzLiAgSWYgYW4g ZXhjZXB0aW9uIG9jY3VycyBweXRob24gd2lsbCBwcmludApAQCAtMTQ1OCw2 ICsxNDc2LDkgQEAgZ2RiLlN5bXRhYl9hbmRfbGluZSBvYmplY3RzIChvciBO b25lKS4ifQogICAgICJwYXJzZV9hbmRfZXZhbCAoU3RyaW5nKSAtPiBWYWx1 ZS5cblwKIFBhcnNlIFN0cmluZyBhcyBhbiBleHByZXNzaW9uLCBldmFsdWF0 ZSBpdCwgYW5kIHJldHVybiB0aGUgcmVzdWx0IGFzIGEgVmFsdWUuIgogICB9 LAorICB7ICJmaW5kX3BjX2xpbmUiLCBnZGJweV9maW5kX3BjX2xpbmUsIE1F VEhfVkFSQVJHUywKKyAgICAiZmluZF9wY19saW5lIChwYykgLT4gU3ltdGFi X2FuZF9saW5lLlxuXAorUmV0dXJuIHRoZSBnZGIuU3ltdGFiX2FuZF9saW5l IG9iamVjdCBjb3JyZXNwb25kaW5nIHRvIHRoZSBwYyB2YWx1ZS4iIH0sCiAK ICAgeyAicG9zdF9ldmVudCIsIGdkYnB5X3Bvc3RfZXZlbnQsIE1FVEhfVkFS QVJHUywKICAgICAiUG9zdCBhbiBldmVudCBpbnRvIGdkYidzIGV2ZW50IGxv b3AuIiB9LApJbmRleDogdGVzdHN1aXRlL2dkYi5weXRob24vcHl0aG9uLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weXRob24uYyx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS40CmRpZmYgLXUgLXAgLXIxLjQgcHl0aG9uLmMKLS0t IHRlc3RzdWl0ZS9nZGIucHl0aG9uL3B5dGhvbi5jCTQgSmFuIDIwMTIgMDg6 Mjc6NDkgLTAwMDAJMS40CisrKyB0ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weXRo b24uYwkxMSBNYXkgMjAxMiAxNjozMDoxOSAtMDAwMApAQCAtMjMsNiArMjMs NiBAQCBpbnQKIG1haW4gKGludCBhcmdjLCBjaGFyICphcmd2W10pCiB7CiAg IGZ1bmMxICgpOwotICBmdW5jMiAoKTsKKyAgZnVuYzIgKCk7ICAgICAgLyog QnJlYWsgYXQgZnVuYzIgY2FsbCBzaXRlLiAgKi8KICAgcmV0dXJuIDA7ICAg ICAgLyogQnJlYWsgdG8gZW5kLiAgKi8KIH0KSW5kZXg6IHRlc3RzdWl0ZS9n ZGIucHl0aG9uL3B5dGhvbi5leHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhv bi9weXRob24uZXhwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjMyCmRpZmYg LXUgLXAgLXIxLjMyIHB5dGhvbi5leHAKLS0tIHRlc3RzdWl0ZS9nZGIucHl0 aG9uL3B5dGhvbi5leHAJMzAgTWFyIDIwMTIgMTk6MTY6NTIgLTAwMDAJMS4z MgorKysgdGVzdHN1aXRlL2dkYi5weXRob24vcHl0aG9uLmV4cAkxMSBNYXkg MjAxMiAxNjozMDoxOSAtMDAwMApAQCAtMzY3LDMgKzM2NywyMyBAQCBnZGJf dGVzdF9tdWx0aXBsZSAicHl0aG9uIGdkYi5wcm9tcHRfaG9vCiAKIGdkYl9w eV90ZXN0X3NpbGVudF9jbWQgInB5dGhvbiBnZGIucHJvbXB0X2hvb2sgPSBO b25lIiBcCiAgICAgInNldCB0aGUgaG9vayB0byBkZWZhdWx0IiAxCisKKyMg U3RhcnQgd2l0aCBhIGZyZXNoIGdkYi4KK2NsZWFuX3Jlc3RhcnQgJHt0ZXN0 ZmlsZX0KKworIyBUaGUgZm9sbG93aW5nIHRlc3RzIHJlcXVpcmUgZXhlY3V0 aW9uLgorCitpZiAhW3J1bnRvX21haW5dIHRoZW4geworICAgIGZhaWwgIkNh bid0IHJ1biB0byBtYWluIgorICAgIHJldHVybiAwCit9CisKK3J1bnRvIFtn ZGJfZ2V0X2xpbmVfbnVtYmVyICJCcmVhayBhdCBmdW5jMiBjYWxsIHNpdGUu Il0KKworZ2RiX3B5X3Rlc3Rfc2lsZW50X2NtZCAicHl0aG9uIGxpbmUgPSBn ZGIuc2VsZWN0ZWRfZnJhbWUoKS5maW5kX3NhbCgpLmxpbmUiICJHZXQgbGlu ZSBudW1iZXIgb2YgZnVuYzIgY2FsbCBzaXRlIiAxCitnZGJfdGVzdCAicHl0 aG9uIHByaW50IGdkYi5maW5kX3BjX2xpbmUoZ2RiLnNlbGVjdGVkX2ZyYW1l KCkucGMoKSkubGluZSA9PSBsaW5lIiAiVHJ1ZSIgIlRlc3QgZmluZF9wY19s aW5lIGF0IGZ1bmMyIGNhbGwgc2l0ZSIKKworZ2RiX3B5X3Rlc3Rfc2lsZW50 X2NtZCAic3RlcCIgIlN0ZXAgaW50byBmdW5jMiIgMQorZ2RiX3B5X3Rlc3Rf c2lsZW50X2NtZCAidXAiICJTdGVwIG91dCBvZiBmdW5jMiIgMQorCitnZGJf dGVzdCAicHl0aG9uIHByaW50IGdkYi5maW5kX3BjX2xpbmUoZ2RiLnNlbGVj dGVkX2ZyYW1lKCkucGMoKSkubGluZSA+IGxpbmUiICJUcnVlIiAiVGVzdCBm aW5kX3BjX2xpbmUgd2l0aCByZXN1bWUgYWRkcmVzcyIK --bcaec5016287fe709a04bfc54ed2--