From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28748 invoked by alias); 15 Jan 2014 13:19:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28738 invoked by uid 89); 15 Jan 2014 13:19:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ea0-f182.google.com Received: from mail-ea0-f182.google.com (HELO mail-ea0-f182.google.com) (209.85.215.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 13:19:36 +0000 Received: by mail-ea0-f182.google.com with SMTP id a15so462640eae.41 for ; Wed, 15 Jan 2014 05:19:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fUeu4VppG1azwrFW8Tk2z9aSS850yk21AGR75s7Q3hQ=; b=SZc/ncVSaSzQHGg53Zn4rCHBPsQp6yhciJbDmFIZv7rB9j5l71EgGIMfztH2Q12MhC Grm9QZcPUS7dFEwfSVRg3RmR7cJD98kkMr0L1OWE55pqIF81LFeQk0wYZC0Q9rpM2AXV BJFRja2UlXxLm+TKFTzBk0gOKtpIDpcnCrnoxWATErlzWvqWPLXe0CwskTrLUJ5XBEbX q/aorJsTMeEZez+LJ2bZUNGSGdBbcrz+PyzkkMmasT5Qfowtp79lbP87HMD+KlDi0VG5 lpSwrTip4/7OdIN4WG54QDxg+U2HoYvdd/QlvVJe/qwZW8fxM3ctNXfKZTBU7JyIvLau tI+Q== X-Gm-Message-State: ALoCoQm2YIdSiy2LRtys8Wo9WltnQhKVqk5F4LeSaXZB8FSRbdfsE/+Dr5eg5WYoHZZY1RkS8K622OeXhLiITf14wL7fsSVcLKlecWaPOThCYjnHp9+FwZHIHo5QKJNArTXsAqbTG3Miv+UNtSSD48I5OQtF50szK8gLwZj+VqW2SKQHx2LKGIXwkME5z/odJuNf049GKFz1zcKHEzAid0/DH7KTYuqX4g== MIME-Version: 1.0 X-Received: by 10.15.49.9 with SMTP id i9mr2729896eew.112.1389791969021; Wed, 15 Jan 2014 05:19:29 -0800 (PST) Received: by 10.14.151.72 with HTTP; Wed, 15 Jan 2014 05:19:28 -0800 (PST) In-Reply-To: <20140115124617.GK4762@adacore.com> References: <87lhysltqs.fsf@fleche.redhat.com> <87ppnvziuw.fsf@fleche.redhat.com> <87ha96y5wa.fsf@fleche.redhat.com> <20140115124617.GK4762@adacore.com> Date: Wed, 15 Jan 2014 13:19:00 -0000 Message-ID: Subject: Re: [Patch] PR python/15464 and python/16113 From: Siva Chandra To: Joel Brobecker Cc: Tom Tromey , gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00503.txt.bz2 On Wed, Jan 15, 2014 at 4:46 AM, Joel Brobecker wrote: > I have no objection in this case, so I'll defer to Tom in return :). > The patch is fairly large, in areas where I don't necessarily understand > all the repercutions. Hence it is good that Tom's OK with it - so > go head, and push to 7.7. > > By the way, I happened to notice a couple of style violations which > I just fixed: > > + { > + const char *field_name = TYPE_FIELD_NAME (type, field); > + if (field_name[0] != '\0') > + { > > Empty line after local declaration. > > + if (ftype == NULL) > + { > + PyErr_SetString (PyExc_TypeError, > + _("'type' attribute of gdb.Field object is not a " > + "gdb.Type object.")); > + } > > No need for the curly braces. Thanks for fixing these. > They are obviously not important for the gdb-7.7 branch, unless you > think there is a chance we might touch this code again in the near > future, and would want to backport to 7.7. In that case, cherry-picking > those two commits on the gdb-7.7 branch would help avoiding patching > conflicts... I have cherry-picked all three commits into gdb-7.7-branch. I built and tested of course, but I hope I did not screw up something else. Thank you, Siva Chandra