From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7460 invoked by alias); 15 Apr 2013 13:36:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7451 invoked by uid 89); 15 Apr 2013 13:36:13 -0000 X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mail-ee0-f47.google.com (HELO mail-ee0-f47.google.com) (74.125.83.47) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Apr 2013 13:36:12 +0000 Received: by mail-ee0-f47.google.com with SMTP id t10so2202587eei.6 for ; Mon, 15 Apr 2013 06:36:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=uh18D2HAXoZy+ZX20CUMcXn5wcLjjro1jJYPZeVe++c=; b=BgMlzyz3wsMl5jyr37tQb0LJ5jwrYsk8RNmZya3vY+Kts7xcZCbC8Qx3hY2rnivALt Qaum6oyyhL1INUYtF8Mk4TNpmfwUpB9cWvxqEHEh48tRSvsoolw5Y1wtE/OjxRPf8P1/ j9qjOjF/T96GkXuzE4pE+rmjKPG/luLb2T8nKsYUAfoWnzZcgAQVV9EXT+KSKAVWHget 8nGVsVpQ/Pjj5zht8PQOphlccYvrYG1FVsxD62eAFffvwCycKIYvdW76R+KIgq2GwSIl p7p6W0JCeH2k3htXAuU8H8jdFyc4ZWR/YcWQRYUW9fZNsYS3hi1XYvqvliA+xI0V6+9H LGtA== MIME-Version: 1.0 X-Received: by 10.14.87.199 with SMTP id y47mr38878005eee.17.1366032969734; Mon, 15 Apr 2013 06:36:09 -0700 (PDT) Received: by 10.15.22.70 with HTTP; Mon, 15 Apr 2013 06:36:09 -0700 (PDT) In-Reply-To: <8761zrfox7.fsf@fleche.redhat.com> References: <8761zrfox7.fsf@fleche.redhat.com> Date: Mon, 15 Apr 2013 18:12:00 -0000 Message-ID: Subject: Re: [RFC][testsuite] Add option to link testcases with pthreads when using 'prepare_for_testing' From: Siva Chandra To: Tom Tromey Cc: gdb-patches Content-Type: multipart/mixed; boundary=001a11c29c60e9d10a04da6655bf X-Gm-Message-State: ALoCoQlgmWCBeLSL1dCdY0AkypFyRRL20RZnZY1TwRW3UvjyAb1Au56iwLQro79mnpVBe3BDgNbYXFGq6MzJdLuhomTFOsI0DmJYCURftpwiHBvUnWfBs/spMc8fZotQaSANUcU/BKJI+CAiG1APYnp9r8LTngIPctbXc84bNhEVD8QCujzHC5o06ZOyii9RbtYQl+kLM6w4OqHm714bTdIdLlvNsg1JHQ== X-Virus-Found: No X-SW-Source: 2013-04/txt/msg00426.txt.bz2 --001a11c29c60e9d10a04da6655bf Content-Type: text/plain; charset=ISO-8859-1 Content-length: 839 The attached patch addresses both of Tom's comments. On Fri, Apr 12, 2013 at 1:56 PM, Tom Tromey wrote: > The intro comment to build_executable_from_specs needs an update to note > that with_pthreads is handled locally. Done. > Siva> + if { [lsearch -exact $options "with_pthreads"] >= 0 } { > Siva> + if { [gdb_compile_pthreads $objects "${binfile}" executable $options] != "" } { > > I wonder if you need to remove with_pthreads from the options here. Done. ChangeLog 2013-04-15 Siva Chandra Reddy Add option to link testcases with Pthreads library when using 'prepare_for_testing' in tests. testsuite/ * lib/gdb.exp (build_executable_from_specs): Use gdb_compile_pthreads to compile if option "with_pthreads" is specified. --001a11c29c60e9d10a04da6655bf Content-Type: text/plain; charset=US-ASCII; name="pthreads_option_patch.txt" Content-Disposition: attachment; filename="pthreads_option_patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hfjor6hv0 Content-length: 2176 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAgYi9nZGIv dGVzdHN1aXRlL2xpYi9nZGIuZXhwCmluZGV4IGQwNTI1N2QuLmE5MDBjYjcg MTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAKKysrIGIv Z2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cApAQCAtMzk3Nyw3ICszOTc3LDgg QEAgcHJvYyB0ZXN0X3ByZWZpeF9jb21tYW5kX2hlbHAgeyBjb21tYW5kX2xp c3QgZXhwZWN0ZWRfaW5pdGlhbF9saW5lcyBhcmdzIH0gewogIyBkaWZmZXJl bnQgb3B0aW9ucyB0byBiZSBwYXNzZWQgdG8gZGlmZmVyZW50IHN1Yi1jb21w aWxhdGlvbnMuCiAjIFRFU1ROQU1FIGlzIHRoZSBuYW1lIG9mIHRoZSB0ZXN0 OyB0aGlzIGlzIHBhc3NlZCB0byAndW50ZXN0ZWQnIGlmCiAjIHNvbWV0aGlu ZyBmYWlscy4KLSMgT1BUSU9OUyBpcyBwYXNzZWQgdG8gdGhlIGZpbmFsIGxp bmssIHVzaW5nIGdkYl9jb21waWxlLgorIyBPUFRJT05TIGlzIHBhc3NlZCB0 byB0aGUgZmluYWwgbGluaywgdXNpbmcgZ2RiX2NvbXBpbGUuICBJZiBPUFRJ T05TCisjIGNvbnRhaW5zIHRoZSBvcHRpb24gIndpdGhfcHRocmVhZHMiLCB0 aGVuIGdkYl9jb21waWxlX3B0aHJlYWRzIGlzIHVzZWQuCiAjIEFSR1MgaXMg YSBmbGF0IGxpc3Qgb2Ygc291cmNlIHNwZWNpZmljYXRpb25zLCBvZiB0aGUg Zm9ybToKICMgICAgeyBTT1VSQ0UxIE9QVElPTlMxIFsgU09VUkNFMiBPUFRJ T05TMiBdLi4uIH0KICMgRWFjaCBTT1VSQ0UgaXMgY29tcGlsZWQgdG8gYW4g b2JqZWN0IGZpbGUgdXNpbmcgaXRzIE9QVElPTlMsCkBAIC0zOTk5LDEwICs0 MDAwLDE5IEBAIHByb2MgYnVpbGRfZXhlY3V0YWJsZV9mcm9tX3NwZWNzIHt0 ZXN0bmFtZSBleGVjdXRhYmxlIG9wdGlvbnMgYXJnc30gewogICAgICAgICBs YXBwZW5kIG9iamVjdHMgIiR7YmluZmlsZX0ke2l9Lm8iCiAJaW5jciBpCiAg ICAgfQotICAgIAotICAgIGlmICB7IFtnZGJfY29tcGlsZSAkb2JqZWN0cyAi JHtiaW5maWxlfSIgZXhlY3V0YWJsZSAkb3B0aW9uc10gIT0gIiIgfSB7Ci0g ICAgICAgIHVudGVzdGVkICR0ZXN0bmFtZQotICAgICAgICByZXR1cm4gLTEK KworICAgIHNldCB3aXRoX3B0aHJlYWRzIFtsc2VhcmNoIC1leGFjdCAkb3B0 aW9ucyAid2l0aF9wdGhyZWFkcyJdCisgICAgaWYgeyAkd2l0aF9wdGhyZWFk cyA+PSAwIH0geworICAgICAgICBzZXQgb3B0aW9ucyBbbHJlcGxhY2UgJG9w dGlvbnMgJHdpdGhfcHRocmVhZHMgJHdpdGhfcHRocmVhZHNdCisgICAgICAg IGlmICB7IFtnZGJfY29tcGlsZV9wdGhyZWFkcyAkb2JqZWN0cyAiJHtiaW5m aWxlfSIgZXhlY3V0YWJsZSAkb3B0aW9uc10gIT0gIiIgfSB7CisgICAgICAg ICAgICB1bnRlc3RlZCAkdGVzdG5hbWUKKyAgICAgICAgICAgIHJldHVybiAt MQorICAgICAgICB9CisgICAgfSBlbHNlIHsKKyAgICAgICAgaWYgIHsgW2dk Yl9jb21waWxlICRvYmplY3RzICIke2JpbmZpbGV9IiBleGVjdXRhYmxlICRv cHRpb25zXSAhPSAiIiB9IHsKKyAgICAgICAgICAgIHVudGVzdGVkICR0ZXN0 bmFtZQorICAgICAgICAgICAgcmV0dXJuIC0xCisgICAgICAgIH0KICAgICB9 CiAKICAgICBzZXQgaW5mb19vcHRpb25zICIiCg== --001a11c29c60e9d10a04da6655bf--