From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116964-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12390 invoked by alias); 24 Oct 2014 12:56:12 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12371 invoked by uid 89); 24 Oct 2014 12:56:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oi0-f41.google.com
Received: from mail-oi0-f41.google.com (HELO mail-oi0-f41.google.com) (209.85.218.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 24 Oct 2014 12:56:10 +0000
Received: by mail-oi0-f41.google.com with SMTP id u20so270018oif.14        for <gdb-patches@sourceware.org>; Fri, 24 Oct 2014 05:56:09 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=NCPizwxnZ+zG7BJC+oMMDWTV2QYuS9jgf4UQm9b/5ZQ=;        b=EtFJHRNNfQn2EyPnqn9yvNNY7AG0mf6CwuY9KA/Vd3D2cQVq5/eh18ud63qx2+5O+a         nQXSKLH80XJsIGLZ3KkzA1MSNZYt8pYoqxTBU3TFO08Tit3HQoxkyBMxfsglkv0etp9U         gQU/tTmdxeFMnVFpzK8QB6Q2e2CqDqBPQJS+FH73ZBYkgqjROzD5S+x14/75Cdlx1HwZ         bz+Gle2P1Qx8vLPNJJpyk6JGQ/gk8+HNee7msOcMQntBeSmkKkl4sDX5f15/IfCw/yDY         valMfwQxreFkoAqFLK8d27vnZpNOM+GvAEXKzyIrGN1p1S0cNle32gT2CrGGToMoHpGu         UYzw==
X-Gm-Message-State: ALoCoQmkF5Z7L0ftGZHRFh/gD670LQW6/BTbGgpbuHCunOUkEPjn8Rrm/UdMCZZSmcImjXagXCER
MIME-Version: 1.0
X-Received: by 10.182.20.15 with SMTP id j15mr1413702obe.52.1414155368958; Fri, 24 Oct 2014 05:56:08 -0700 (PDT)
Received: by 10.202.197.13 with HTTP; Fri, 24 Oct 2014 05:56:08 -0700 (PDT)
In-Reply-To: <CADPb22SL8CCmRn22qfGOsSkqtyC86udXTQAf-BK2AcsPUdn7cw@mail.gmail.com>
References: <CAGyQ6gzAMpiA8Hwt1=DqmFxXjfe44nqGsCqsj-fx=ObJbgPAsA@mail.gmail.com>	<CAGyQ6gy9eObF+29DSibKj4xxiw9NpoWtarVJTtd-j_A7LBnktA@mail.gmail.com>	<CAGyQ6gzXKBQ4JVOZeEUAc3fvDtXJ+yACsU74rL2Q4cnO4JTh+g@mail.gmail.com>	<CADPb22SL8CCmRn22qfGOsSkqtyC86udXTQAf-BK2AcsPUdn7cw@mail.gmail.com>
Date: Fri, 24 Oct 2014 12:56:00 -0000
Message-ID: <CAGyQ6gwk4rn_=LTB17cpfkWHdc4gv7AU-NdsybLKFJQBOhGb1Q@mail.gmail.com>
Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
From: Siva Chandra <sivachandra@google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00640.txt.bz2

On Thu, Oct 23, 2014 at 10:31 PM, Doug Evans <dje@google.com> wrote:
>>> gdb/ChangeLog:
>>>
>>>         * gnu-v3-abi.c (gnuv3_pass_by_reference): Call TYPE_TARGET_TYPE
>>>         on the arg type of a constructor only if it is of reference type.
>>>
>>> gdb/testsuite/ChangeLog:
>>>
>>>         * gdb.cp/non-trivial-retval.cc: Add a test case.
>>>         * gdb.cp/non-trivial-retval.exp: Add a test.
>
> LGTM with one nit.
>
> +class B1
> +{
> +public:
> +  B1 () {}
> +  B1 (int i);  /* Put this decl before the copy-ctor decl.  */
> +  B1 (const B1 &obj);
> +
> +  int b1;
> +};
>
> Can you elaborate on why "Put this decl before ..."?

Thank you. Pushed after adding a detailed comment:
3433cfa51f6397231ffe2b2c69298eff89179769