From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31045 invoked by alias); 16 Aug 2014 01:16:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30735 invoked by uid 89); 16 Aug 2014 01:16:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 16 Aug 2014 01:16:36 +0000 Received: by mail-oi0-f52.google.com with SMTP id h136so2149138oig.25 for ; Fri, 15 Aug 2014 18:16:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=6jk/o/azTBektNifO3uEVRHzZ7PZH3pBLwIWxKrEzbs=; b=Gxb2guwUKQ617ktGENojhzdCdR1HdPMaemzzMI5Kl4RUkIqkohL5x5BRb+K6cYLf2W yGsfJ4gGCeepsFGB4P5Ct3jVCOyw7d+O8PCTPkbnvHqiIosu0XPRDHNvas8L5OCiP0DO kp0lEi2RpUCl+0K5MzQMgsuj8ajWpNdKcm9ETtLeNgfE3dJpKmzYT+h7KBzUtvr7YoId ZBa/OkVPGGniJFm+jV4VmehucTDbG5i5QQ3m/NJq86Y0EhbCa75GzU53n3oAauDiE0We z2C9f6iqhhlMe+rintAoznacitztW6LZlDRc3XZuKjVQw/hetHd8HaZ/dtgS7QYGIMDJ WvKQ== X-Gm-Message-State: ALoCoQmxN6ISu4orAgtxUWuFHInNRCJ5gnxJgZA4itE2ipIwWsbNKbfHOGHcFPXZPpt7Ni4nd9lz MIME-Version: 1.0 X-Received: by 10.182.3.100 with SMTP id b4mr18090obb.79.1408151794787; Fri, 15 Aug 2014 18:16:34 -0700 (PDT) Received: by 10.202.12.193 with HTTP; Fri, 15 Aug 2014 18:16:34 -0700 (PDT) In-Reply-To: <21485.14738.947462.758709@ruffy.mtv.corp.google.com> References: <21485.14738.947462.758709@ruffy.mtv.corp.google.com> Date: Sat, 16 Aug 2014 01:16:00 -0000 Message-ID: Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3 From: Siva Chandra To: Doug Evans Cc: gdb-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00284.txt.bz2 On Thu, Aug 14, 2014 at 3:34 PM, Doug Evans wrote: > Siva Chandra writes: > > The attached patch fixes the "no space before parenthesis in Python" > > comment by Joel. The comment was for the changes in the test suite. > > Going by examples, I thought the test case code (but not the .exp > > files) did not require adherence to coding style. > > > > I also agree with Joel that this patch should also pushed to the 7.8 branch. > > > > ChangeLog: > > 2014-08-14 Siva Chandra Reddy > > > > gdb/ > > > > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the > > 'items' methods instead of 'iteritems' method on dictionaries. > > > > gdb/testsuite/ > > > > * gdb.python/py-xmethods.py (A_getarrayind) > > (E_method_char_worker.__call__, E_method_int_worker.__call__): > > Use 'print' with function call syntax. > > (E_method_matcher.match): Fix tab vs space indentation mixup. > > LGTM Pushed 940df408121be31beed22ef7a5ad133cb1592726.