From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2970 invoked by alias); 30 Dec 2013 14:27:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2959 invoked by uid 89); 30 Dec 2013 14:27:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ee0-f52.google.com Received: from mail-ee0-f52.google.com (HELO mail-ee0-f52.google.com) (74.125.83.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 30 Dec 2013 14:27:03 +0000 Received: by mail-ee0-f52.google.com with SMTP id d17so5112781eek.11 for ; Mon, 30 Dec 2013 06:27:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=KZPjypsxjL/45r1/3c12fY9bAMUueLp7a2u9xldoDl4=; b=WtbjSKmU+OVgavgyeGPgHBkpqUDhkwm8WLAQqq4cN9GffICIF5EvA5pr4U6oXvSC8H +sGirGqiUWpdIX2/T/RzjwiARxa7vd/epGrGMiXBvW/apSo4Btzkb+lSxpTVWwfc6P+9 XjA7/4XaqAmiFUzbNcRMY2QKoDj5sk9OrsZQiPEnZMbVNj9K/n661+lYjN1lqxXrUeXX LbZA442a2GZpbF5fXdHrMehw04nx01oIfndyosN075c6Vmqd04a3TyIYpGkoAEWxAEFN L7/u6QjmTcChugpYzJIQOO8JY3dti0UttfvgfB0EhyQlljaqOb8K/ODAWdGFs8bVZoPg gAjg== X-Gm-Message-State: ALoCoQm0/E7/zzjkJPa/JELPSft/C9ZGEvmS0gIXeJkK1F8aPDtrHEijsMydaH7Z01Eq1IwTurWjrBOcl5NmCsO/ECaggcYrhIMI9oxdFWzI5UwLBUdmzM+ppVrWiYe92hbnKcbxUXD+28KQFMsWuaqfvh5WpemmY/0a10U+0zsuBJM5dN4qxWeWjt6tmfinLR9Bvy3DzXpI2dSZiWChWHeBVMxR44BgbQ== MIME-Version: 1.0 X-Received: by 10.15.10.2 with SMTP id f2mr57251eet.112.1388413620084; Mon, 30 Dec 2013 06:27:00 -0800 (PST) Received: by 10.14.151.72 with HTTP; Mon, 30 Dec 2013 06:26:59 -0800 (PST) In-Reply-To: References: Date: Mon, 30 Dec 2013 14:27:00 -0000 Message-ID: Subject: Re: [Patch] PR python/15464 and python/16113 From: Siva Chandra To: gdb-patches Content-Type: multipart/mixed; boundary=001a1133d1f8a0a4f004eec13cfc X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00991.txt.bz2 --001a1133d1f8a0a4f004eec13cfc Content-Type: text/plain; charset=UTF-8 Content-length: 516 Attached is a newer version of the patch which an 'xfree' moved to a more appropriate place. 2013-12-30 Siva Chandra Reddy PR python/15464 PR python/16133 * valops.c (value_struct_elt_bitpos): New function * python/py-value.c (valpy_getitem): Use 'bitpos' attribute to look for a field when 'name' is 'None' or empty. testsuite/ * gdb.python/py-value-cc.cc: Enhance test case. * gdb.python/py-value-cc.exp: Add new tests. --001a1133d1f8a0a4f004eec13cfc Content-Type: text/plain; charset=US-ASCII; name="value_field_subscript_patch_v2.txt" Content-Disposition: attachment; filename="value_field_subscript_patch_v2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hpttldnk1 Content-length: 8719 ZGlmZiAtLWdpdCBhL2dkYi9weXRob24vcHktdmFsdWUuYyBiL2dkYi9weXRo b24vcHktdmFsdWUuYwppbmRleCBkZjI1MTc5Li42OTE5NGIwIDEwMDY0NAot LS0gYS9nZGIvcHl0aG9uL3B5LXZhbHVlLmMKKysrIGIvZ2RiL3B5dGhvbi9w eS12YWx1ZS5jCkBAIC01NzMsNiArNTczLDcgQEAgdmFscHlfZ2V0aXRlbSAo UHlPYmplY3QgKnNlbGYsIFB5T2JqZWN0ICprZXkpCiAgIHZhbHVlX29iamVj dCAqc2VsZl92YWx1ZSA9ICh2YWx1ZV9vYmplY3QgKikgc2VsZjsKICAgY2hh ciAqZmllbGQgPSBOVUxMOwogICBQeU9iamVjdCAqYmFzZV9jbGFzc190eXBl X29iamVjdCA9IE5VTEw7CisgIGxvbmcgYml0cG9zID0gLTE7CiAgIHZvbGF0 aWxlIHN0cnVjdCBnZGJfZXhjZXB0aW9uIGV4Y2VwdDsKICAgUHlPYmplY3Qg KnJlc3VsdCA9IE5VTEw7CiAKQEAgLTYxNCwxMCArNjE1LDQxIEBAIHZhbHB5 X2dldGl0ZW0gKFB5T2JqZWN0ICpzZWxmLCBQeU9iamVjdCAqa2V5KQogCSAg aWYgKG5hbWVfb2JqID09IE5VTEwpCiAJICAgIHJldHVybiBOVUxMOwogCi0J ICBmaWVsZCA9IHB5dGhvbl9zdHJpbmdfdG9faG9zdF9zdHJpbmcgKG5hbWVf b2JqKTsKLQkgIFB5X0RFQ1JFRiAobmFtZV9vYmopOwotCSAgaWYgKGZpZWxk ID09IE5VTEwpCi0JICAgIHJldHVybiBOVUxMOworCSAgaWYgKG5hbWVfb2Jq ICE9IFB5X05vbmUpCisJICAgIHsKKwkgICAgICBmaWVsZCA9IHB5dGhvbl9z dHJpbmdfdG9faG9zdF9zdHJpbmcgKG5hbWVfb2JqKTsKKwkgICAgICBQeV9E RUNSRUYgKG5hbWVfb2JqKTsKKwkgICAgICBuYW1lX29iaiA9IE5VTEw7CisJ ICAgICAgaWYgKGZpZWxkID09IE5VTEwpCisJCXJldHVybiBOVUxMOworCSAg ICB9CisKKwkgIGlmIChuYW1lX29iaiA9PSBQeV9Ob25lIHx8IGZpZWxkWzBd ID09ICdcMCcpCisJICAgIHsKKwkgICAgICBQeU9iamVjdCAqYml0cG9zX29i ajsKKwkgICAgICBpbnQgdmFsaWQ7CisKKwkgICAgICBQeV9YREVDUkVGIChu YW1lX29iaik7CisJICAgICAgeGZyZWUgKGZpZWxkKTsKKwkgICAgICBmaWVs ZCA9IE5VTEw7CisKKwkgICAgICBpZiAoIVB5T2JqZWN0X0hhc0F0dHJTdHJp bmcgKGtleSwgImJpdHBvcyIpKQorCQl7CisJCSAgUHlFcnJfU2V0U3RyaW5n IChQeUV4Y19BdHRyaWJ1dGVFcnJvciwKKwkJCQkgICBfKCJnZGIuRmllbGQg b2JqZWN0IGhhcyBubyBuYW1lIGFuZCBubyAiCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIidiaXRwb3MnIGF0dHJpYnV0ZS4iKSk7 CisKKwkJICByZXR1cm4gTlVMTDsKKwkJfQorCSAgICAgIGJpdHBvc19vYmog PSBQeU9iamVjdF9HZXRBdHRyU3RyaW5nIChrZXksICJiaXRwb3MiKTsKKwkg ICAgICBpZiAoYml0cG9zX29iaiA9PSBOVUxMKQorCQlyZXR1cm4gTlVMTDsK KworCSAgICAgIHZhbGlkID0gZ2RiX3B5X2ludF9hc19sb25nIChiaXRwb3Nf b2JqLCAmYml0cG9zKTsKKwkgICAgICBQeV9ERUNSRUYgKGJpdHBvc19vYmop OworCSAgICAgIGlmICghdmFsaWQpCisJCXJldHVybiBOVUxMOworCSAgICB9 CiAJfQogICAgIH0KIApAQCAtNjI5LDYgKzY2MSw4IEBAIHZhbHB5X2dldGl0 ZW0gKFB5T2JqZWN0ICpzZWxmLCBQeU9iamVjdCAqa2V5KQogCiAgICAgICBp ZiAoZmllbGQpCiAJcmVzX3ZhbCA9IHZhbHVlX3N0cnVjdF9lbHQgKCZ0bXAs IE5VTEwsIGZpZWxkLCAwLCBOVUxMKTsKKyAgICAgIGVsc2UgaWYgKGJpdHBv cyA+PSAwKQorCXJlc192YWwgPSB2YWx1ZV9zdHJ1Y3RfZWx0X2JpdHBvcyAo JnRtcCwgYml0cG9zLCAic3RydWN0L2NsYXNzL3VuaW9uIik7CiAgICAgICBl bHNlIGlmIChiYXNlX2NsYXNzX3R5cGVfb2JqZWN0ICE9IE5VTEwpCiAJewog CSAgc3RydWN0IHR5cGUgKmJhc2VfY2xhc3NfdHlwZSwgKnZhbF90eXBlOwpk aWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXZhbHVl LWNjLmNjIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LXZhbHVlLWNj LmNjCmluZGV4IDgwMDk0ZWMuLjhiOWFhNWEgMTAwNjQ0Ci0tLSBhL2dkYi90 ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS12YWx1ZS1jYy5jYworKysgYi9nZGIv dGVzdHN1aXRlL2dkYi5weXRob24vcHktdmFsdWUtY2MuY2MKQEAgLTMwLDgg KzMwLDE1IEBAIGNsYXNzIEIgOiBwdWJsaWMgQSB7CiAgIGNoYXIgYTsKIH07 CiAKK3N0cnVjdCBYCit7CisgIHVuaW9uIHsgaW50IHg7IGNoYXIgeTsgfTsK KyAgdW5pb24geyBpbnQgYTsgY2hhciBiOyB9OworfTsKKwogdHlwZWRlZiBC IEJ0ZDsKIHR5cGVkZWYgaW50ICppbnRfcHRyOwordHlwZWRlZiBYIFh0ZDsK IAogaW50CiBmdW5jIChjb25zdCBBICZhKQpAQCAtNTcsNiArNjQsMTMgQEAg ZnVuYyAoY29uc3QgQSAmYSkKICAgVSB1OwogICB1LmEgPSA5OTsKIAorICBY IHg7CisgIHgueCA9IDEwMTsKKyAgeC5hID0gMTAyOworCisgIFggKnhfcHRy ID0gJng7CisgIFh0ZCAqeHRkID0gJng7CisKICAgcmV0dXJuIDA7IC8qIEJy ZWFrIGhlcmUuICAqLwogfQogCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRl L2dkYi5weXRob24vcHktdmFsdWUtY2MuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9n ZGIucHl0aG9uL3B5LXZhbHVlLWNjLmV4cAppbmRleCBlYWNhZjJlLi4wOGRj NDYyIDEwMDY0NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHkt dmFsdWUtY2MuZXhwCisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9w eS12YWx1ZS1jYy5leHAKQEAgLTUzLDYgKzUzLDEyIEBAIGdkYl90ZXN0X25v X291dHB1dCAicHl0aG9uIGJfcmVmID0gZ2RiLnBhcnNlX2FuZF9ldmFsKCdi X3JlZicpIiAiaW5pdCBiX3JlZiIKIGdkYl90ZXN0X25vX291dHB1dCAicHl0 aG9uIGJfdGQgPSBnZGIucGFyc2VfYW5kX2V2YWwoJ2JfdGQnKSIgImluaXQg Yl90ZCIKIGdkYl90ZXN0X25vX291dHB1dCAicHl0aG9uIHUgPSBnZGIucGFy c2VfYW5kX2V2YWwoJ3UnKSIgImluaXQgdSIKIGdkYl90ZXN0X25vX291dHB1 dCAicHl0aG9uIHVfZmllbGRzID0gdS50eXBlLmZpZWxkcygpIiAiaW5pdCB1 X2ZpZWxkcyIKK2dkYl90ZXN0X25vX291dHB1dCAicHl0aG9uIHggPSBnZGIu cGFyc2VfYW5kX2V2YWwoJ3gnKSIgImluaXQgeCIKK2dkYl90ZXN0X25vX291 dHB1dCAicHl0aG9uIHhfZmllbGRzID0geC50eXBlLmZpZWxkcygpIiAiaW5p dCB4X2ZpZWxkcyIKK2dkYl90ZXN0X25vX291dHB1dCAicHl0aG9uIHhfcHRy ID0gZ2RiLnBhcnNlX2FuZF9ldmFsKCd4X3B0cicpIiAiaW5pdCB4X3B0ciIK K2dkYl90ZXN0X25vX291dHB1dCAicHl0aG9uIHh0ZCA9IGdkYi5wYXJzZV9h bmRfZXZhbCgneHRkJykiICJpbml0IHh0ZCIKKworZ2RiX3Rlc3QgInB5dGhv biBwcmludChiXFtiX2ZpZWxkc1xbMVxdXF0pIiAiOTcgJ2EnIiAiYi5hIHZp YSBmaWVsZCIKIAogZ2RiX3Rlc3QgInB5dGhvbiBwcmludChiXFtiX2ZpZWxk c1xbMVxdXF0pIiAiOTcgJ2EnIiAiYi5hIHZpYSBmaWVsZCIKIGdkYl90ZXN0 ICJweXRob24gcHJpbnQoYlxbYl9maWVsZHNcWzBcXVxdLnR5cGUpIiAiQSIg XApAQCAtNzksMyArODUsMTEgQEAgZ2RiX3Rlc3QgInB5dGhvbiBwcmludChi X3RkXFtiX2ZpZWxkc1xbMFxdXF1cWydhJ1xdKSIgIjEwMCIgXAogCiBnZGJf dGVzdCAicHl0aG9uIHByaW50KHVcW3VfZmllbGRzXFswXF1cXSkiICI5OS4q IiAidSdzIGZpcnN0IGZpZWxkIHZpYSBmaWVsZCIKIGdkYl90ZXN0ICJweXRo b24gcHJpbnQodVxbdV9maWVsZHNcWzFcXVxdKSIgIjk5LioiICJ1J3Mgc2Vj b25kIGZpZWxkIHZpYSBmaWVsZCIKKworZ2RiX3Rlc3QgInB5dGhvbiBwcmlu dCBsZW4oeF9maWVsZHMpIiAiMiIgIm51bWJlciBmb3IgZmllbGRzIGluIHUi CitnZGJfdGVzdCAicHl0aG9uIHByaW50IHhcW3hfZmllbGRzXFswXF1cXVxb J3gnXF0iICIxMDEiICJ4LnggdmlhIGZpZWxkIgorZ2RiX3Rlc3QgInB5dGhv biBwcmludCB4XFt4X2ZpZWxkc1xbMVxdXF1cWydhJ1xdIiAiMTAyIiAieC5h IHZpYSBmaWVsZCIKK2dkYl90ZXN0ICJweXRob24gcHJpbnQgeF9wdHJcW3hf ZmllbGRzXFswXF1cXVxbJ3gnXF0iICIxMDEiICJ4X3B0ci0+eCB2aWEgZmll bGQiCitnZGJfdGVzdCAicHl0aG9uIHByaW50IHhfcHRyXFt4X2ZpZWxkc1xb MVxdXF1cWydhJ1xdIiAiMTAyIiAieF9wdHItPmEgdmlhIGZpZWxkIgorZ2Ri X3Rlc3QgInB5dGhvbiBwcmludCB4dGRcW3hfZmllbGRzXFswXF1cXVxbJ3gn XF0iICIxMDEiICJ4dGQtPnggdmlhIGZpZWxkIgorZ2RiX3Rlc3QgInB5dGhv biBwcmludCB4dGRcW3hfZmllbGRzXFsxXF1cXVxbJ2EnXF0iICIxMDIiICJ4 dGQtPmEgdmlhIGZpZWxkIgpkaWZmIC0tZ2l0IGEvZ2RiL3ZhbG9wcy5jIGIv Z2RiL3ZhbG9wcy5jCmluZGV4IGQ0M2M3NTguLmYxNDc4NTQgMTAwNjQ0Ci0t LSBhL2dkYi92YWxvcHMuYworKysgYi9nZGIvdmFsb3BzLmMKQEAgLTIyNDgs NiArMjI0OCw0OSBAQCB2YWx1ZV9zdHJ1Y3RfZWx0IChzdHJ1Y3QgdmFsdWUg KiphcmdwLCBzdHJ1Y3QgdmFsdWUgKiphcmdzLAogICByZXR1cm4gdjsKIH0K IAorLyogR2l2ZW4gKkFSR1AsIGEgdmFsdWUgb2YgdHlwZSBzdHJ1Y3R1cmUg b3IgdW5pb24sIG9yIGEgcG9pbnRlci9yZWZlcmVuY2UKKyAgIHRvIGEgc3Ry dWN0dXJlIG9yIHVuaW9uLCBleHRyYWN0IGFuZCByZXR1cm4gaXRzIGNvbXBv bmVudCAoZmllbGQpIGF0IHRoZQorICAgc3BlY2lmaWVkIEJJVFBPUy4KKyAg IFJldHVybnMgTlVMTCBpZiBCSVRQT1MgaXMgaW52YWxpZC4gICovCisKK3N0 cnVjdCB2YWx1ZSAqCit2YWx1ZV9zdHJ1Y3RfZWx0X2JpdHBvcyAoc3RydWN0 IHZhbHVlICoqYXJncCwgaW50IGJpdHBvcywgY29uc3QgY2hhciAqZXJyKQor eworICBzdHJ1Y3QgdHlwZSAqdDsKKyAgc3RydWN0IHZhbHVlICp2OworICBp bnQgaTsKKyAgaW50IG5iYXNlczsKKworICAqYXJncCA9IGNvZXJjZV9hcnJh eSAoKmFyZ3ApOworCisgIHQgPSBjaGVja190eXBlZGVmICh2YWx1ZV90eXBl ICgqYXJncCkpOworCisgIHdoaWxlIChUWVBFX0NPREUgKHQpID09IFRZUEVf Q09ERV9QVFIgfHwgVFlQRV9DT0RFICh0KSA9PSBUWVBFX0NPREVfUkVGKQor ICAgIHsKKyAgICAgICphcmdwID0gdmFsdWVfaW5kICgqYXJncCk7CisgICAg ICBpZiAoVFlQRV9DT0RFIChjaGVja190eXBlZGVmICh2YWx1ZV90eXBlICgq YXJncCkpKSAhPSBUWVBFX0NPREVfRlVOQykKKwkqYXJncCA9IGNvZXJjZV9h cnJheSAoKmFyZ3ApOworICAgICAgdCA9IGNoZWNrX3R5cGVkZWYgKHZhbHVl X3R5cGUgKCphcmdwKSk7CisgICAgfQorCisgIGlmIChUWVBFX0NPREUgKHQp ICE9IFRZUEVfQ09ERV9TVFJVQ1QKKyAgICAgICYmIFRZUEVfQ09ERSAodCkg IT0gVFlQRV9DT0RFX1VOSU9OKQorICAgIGVycm9yIChfKCJBdHRlbXB0IHRv IGV4dHJhY3QgYSBjb21wb25lbnQgb2YgYSB2YWx1ZSB0aGF0IGlzIG5vdCBh ICVzLiIpLAorCSAgIGVycik7CisKKyAgZm9yIChpID0gVFlQRV9OX0JBU0VD TEFTU0VTICh0KTsgaSA8IFRZUEVfTkZJRUxEUyAodCk7IGkrKykKKyAgICB7 CisgICAgICBpZiAoIWZpZWxkX2lzX3N0YXRpYyAoJlRZUEVfRklFTEQgKHQs IGkpKQorCSAgJiYgYml0cG9zID09IFRZUEVfRklFTERfQklUUE9TICh0LCBp KSkKKwlyZXR1cm4gdmFsdWVfcHJpbWl0aXZlX2ZpZWxkICgqYXJncCwgMCwg aSwgdCk7CisgICAgfQorCisgIGVycm9yIChfKCJBdHRlbXB0IHRvIGV4dHJh Y3QgYSBjb21wb25lbnQgd2l0aCBhbiBpbnZhbGlkIGJpdHBvcy4iKSk7CisK KyAgLyogTmV2ZXIgaGl0LiAgKi8KKyAgcmV0dXJuIE5VTEw7Cit9CisKIC8q IFNlYXJjaCB0aHJvdWdoIHRoZSBtZXRob2RzIG9mIGFuIG9iamVjdCAoYW5k IGl0cyBiYXNlcykgdG8gZmluZCBhCiAgICBzcGVjaWZpZWQgbWV0aG9kLiAg UmV0dXJuIHRoZSBwb2ludGVyIHRvIHRoZSBmbl9maWVsZCBsaXN0IG9mCiAg ICBvdmVybG9hZGVkIGluc3RhbmNlcy4KZGlmZiAtLWdpdCBhL2dkYi92YWx1 ZS5oIGIvZ2RiL3ZhbHVlLmgKaW5kZXggNmIxNThkZi4uYTI3OTgwMyAxMDA2 NDQKLS0tIGEvZ2RiL3ZhbHVlLmgKKysrIGIvZ2RiL3ZhbHVlLmgKQEAgLTY3 MCw2ICs2NzAsMTAgQEAgZXh0ZXJuIHN0cnVjdCB2YWx1ZSAqdmFsdWVfc3Ry dWN0X2VsdCAoc3RydWN0IHZhbHVlICoqYXJncCwKIAkJCQkgICAgICAgY29u c3QgY2hhciAqbmFtZSwgaW50ICpzdGF0aWNfbWVtZnVuY3AsCiAJCQkJICAg ICAgIGNvbnN0IGNoYXIgKmVycik7CiAKK2V4dGVybiBzdHJ1Y3QgdmFsdWUg KnZhbHVlX3N0cnVjdF9lbHRfYml0cG9zIChzdHJ1Y3QgdmFsdWUgKiphcmdw LAorCQkJCQkgICAgICBpbnQgYml0cG9zLAorCQkJCQkgICAgICBjb25zdCBj aGFyICplcnIpOworCiBleHRlcm4gc3RydWN0IHZhbHVlICp2YWx1ZV9hZ2dy ZWdhdGVfZWx0IChzdHJ1Y3QgdHlwZSAqY3VydHlwZSwKIAkJCQkJICBjaGFy ICpuYW1lLAogCQkJCQkgIHN0cnVjdCB0eXBlICpleHBlY3RfdHlwZSwK --001a1133d1f8a0a4f004eec13cfc--