From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5196 invoked by alias); 10 May 2013 19:55:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5176 invoked by uid 89); 10 May 2013 19:55:02 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ee0-f43.google.com (HELO mail-ee0-f43.google.com) (74.125.83.43) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 10 May 2013 19:55:02 +0000 Received: by mail-ee0-f43.google.com with SMTP id b15so2515879eek.2 for ; Fri, 10 May 2013 12:54:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=SY2+Km1/6R26Bv7ORY6DsnY5uMmjwZIAjy9cgdQ098E=; b=D+HQTmN9leWxHpTf22o2791wa7hTzAAMZ8ZpXS95aUXNssCTD4Omld8HjiCp5cOm/X LmT7Zr81R5zqVeY1ElkG2wlBO2lUrzsP33zqSIQT8R+2BtfuSc+Szl0H1E5zCnfGWivy Qjjsq04361I5LYiZqAiTCI+uqAndZq1j395oxdJSG5BNbbd2/KEUDVE+C4TqFIl/71RM T2bJ6k1Qnx601uOgtkBqWRFwsyufWa46DCd9X7ed92KNje97E58WykQkH5DhMIsKTB5R 3HA7QL2LvsUf543qxHLD00wKfcD31/Ea1OPHpzURTbOSFI0q4Fu3W+jgmpPdtWEKgT2N TTVw== MIME-Version: 1.0 X-Received: by 10.14.194.70 with SMTP id l46mr44729535een.28.1368215699741; Fri, 10 May 2013 12:54:59 -0700 (PDT) Received: by 10.14.204.72 with HTTP; Fri, 10 May 2013 12:54:59 -0700 (PDT) In-Reply-To: <87r4hefx59.fsf@fleche.redhat.com> References: <87r4hefx59.fsf@fleche.redhat.com> Date: Fri, 10 May 2013 19:55:00 -0000 Message-ID: Subject: Re: [RFC] Debug Methods in GDB Python From: Siva Chandra To: Tom Tromey Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmgps/WW/MLLUHK7sdxxo0ooMNtT9SphIjcJiLWm4PVwHNcTUgExFIcK7gM0mRK3jq+pzPAmoUFZfdZQMxyh5xTaAI4LRv9QU8ybdQX1SuZdUNgmLqm9v9j2TmQjcOO1zkMC+kyPu+rf2DodkbjnjmSp0fJ0x4PxZjuZbagDbP0tT8QuUTFzQ1qhJwU5QVETyKsDfAyWAd4UJWirUktAGvECuRgwA== X-SW-Source: 2013-05/txt/msg00400.txt.bz2 On Fri, May 10, 2013 at 12:33 PM, Tom Tromey wrote: >>>>>> "Siva" == Siva Chandra writes: > > Siva> Attached is a new version of the patch which I have now regression > Siva> tested. Except for tests and docs, I think it is complete wrt the > Siva> feature set I have in mind. Hence, the caveats from the previous mail > Siva> still apply. > > I'm sorry about the delay here. Thanks a lot for taking a look. I have had to be away from this work myself and I will continue to be away for at least a week more. Hence, I will respond to your comments in detail late May/early June. For my own reference, I am summarizing your comments as follows: 1. The ext_fn_object should use the GDB style "virtual method" approach. 2. Python related exceptions and error checking are missing. 3. More functions could be static and function comments are missing. 4. Copy-paste errors. 5. One specific comment about thread safety and GIL. It would also be good to get feedback on the Python side API that I put together. Thanks, Siva Chandra