From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116758-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7137 invoked by alias); 16 Oct 2014 18:18:29 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7126 invoked by uid 89); 16 Oct 2014 18:18:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mail-oi0-f52.google.com
Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 18:18:27 +0000
Received: by mail-oi0-f52.google.com with SMTP id a3so3083389oib.39        for <gdb-patches@sourceware.org>; Thu, 16 Oct 2014 11:18:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=N2C18hO60Y3B3ME63TZ8du7sSmbD8yplc+Gwotn9XBw=;        b=nFT3/lkPYuq3n/N4chGOcT9w8M9yLxBzkdYrq4kSlKctyrzzSGz0XdtFJ7g5PP519D         kkvmVAfN1+zKmdL4jrgy+Z89hYtmGSTeWZf34PScV9q+FbvecHUrRT0fz+5xiBSimoY4         WMWNiC/wJpaYW6ZzSfOSyzmuQTkkv34ewq8QYRHF9lmx5oN8yyzm1gJxRahVIe+FxhD7         k+L3fO0hXhei1GKv1xS9spkPUAENxMCpkF8xFObBENuWA+t5X9vEQN2ozeEBa3dJBXXW         uIVmAmXUcfitjU//5adzVrzj+cwk12v0KAnwq+0aUtBVTL+qZZ1IAhCCH6vOmgDNNZjC         UjKg==
X-Gm-Message-State: ALoCoQlzpYjj5HDANAaE5C/DWGMNpoMO/yP17vPY4vkgOy8plT1/dWV1ffRk61KOFVkIYWEUhHrJ
MIME-Version: 1.0
X-Received: by 10.60.133.170 with SMTP id pd10mr2384869oeb.35.1413483504865; Thu, 16 Oct 2014 11:18:24 -0700 (PDT)
Received: by 10.202.197.13 with HTTP; Thu, 16 Oct 2014 11:18:24 -0700 (PDT)
In-Reply-To: <87r3y7j2xw.fsf@redhat.com>
References: <CAGyQ6gzAMpiA8Hwt1=DqmFxXjfe44nqGsCqsj-fx=ObJbgPAsA@mail.gmail.com>	<544007F1.9010005@redhat.com>	<CAGyQ6gz3DfAA52yh0ANFyJycMnAc5oQLmG6p+x6R70G7cbmuYQ@mail.gmail.com>	<87r3y7j2xw.fsf@redhat.com>
Date: Thu, 16 Oct 2014 18:18:00 -0000
Message-ID: <CAGyQ6gwH7n3OPQojn86GA=uBrGbHOcys7DeyrXogQGb6+CcSnA@mail.gmail.com>
Subject: Re: [PATCH] Guard a call to TYPE_TARGET_TYPE in gnuv3_pass_by_reference
From: Siva Chandra <sivachandra@google.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Pedro Alves <palves@redhat.com>, Doug Evans <dje@google.com>, 	gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00434.txt.bz2

On Thu, Oct 16, 2014 at 11:15 AM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Thursday, October 16 2014, Siva Chandra wrote:
>
>> Do you think a test case should be added? I did think about it, but
>> then, should there be a test case for every use of TYPE_TARGET_TYPE? I
>> thought it was more of a "user mistake" in my original patch.
>
> If I may, I think a testcase should be added for this case, yes.  GDB
> should not have a problem because a user mistake.

I will add and send an updated patch. The user mistake I am talking
about here is me as a developer using "TYPE_TARGET_TYPE" in GDB source
code.