From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11091 invoked by alias); 12 Jun 2012 18:41:05 -0000 Received: (qmail 11078 invoked by uid 22791); 12 Jun 2012 18:41:03 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qa0-f41.google.com (HELO mail-qa0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jun 2012 18:40:40 +0000 Received: by qabg27 with SMTP id g27so3252820qab.0 for ; Tue, 12 Jun 2012 11:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=xlcJcZxMYhJHuz4wYFgljuxC1Y27da3Sh850WMS7leQ=; b=j7/Jk3lChF6aG53lrRxF4IBOBELCGwOhhb2GHT/sHYWyOHCoffHGhleRiQHLfL4y0p NXddeu35cpjntKABZcta694HO7GaMydYzryPMccFXeP/xR7ICu5DmAi81cbhQft7mamb T94z2tJxCfghPsDaFT7xtp3ArEiPcZg9xdgOSOMcM/fD7mRzB8K1h27vcpIi1WD7yc2j Gmj3j9d7YZ8phkA5RXp9ZlzZ7PceNVBYWkQbJcC0YKpbJa/6zla6PHA0fFveTmAS7QGC 4KV7UpJIATgaGmw8fXtmX/0nfgkXpcothOP3pxZe3olBYN5GqLz55a+qgAn6YcWFuyke FGEQ== Received: by 10.224.219.67 with SMTP id ht3mr9558305qab.0.1339526439738; Tue, 12 Jun 2012 11:40:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.219.67 with SMTP id ht3mr9558275qab.0.1339526439450; Tue, 12 Jun 2012 11:40:39 -0700 (PDT) Received: by 10.224.63.209 with HTTP; Tue, 12 Jun 2012 11:40:39 -0700 (PDT) In-Reply-To: References: Date: Tue, 12 Jun 2012 18:41:00 -0000 Message-ID: Subject: Re: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line From: Siva Chandra To: Doug Evans Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf3010edf39738c204c24acd22 X-System-Of-Record: true X-Gm-Message-State: ALoCoQm4Tz3QEsdDBTao78+BAY4u/Uw98SKcuK2qzXAMwwCBJTQyoP7BoDdTVAJd9/fFNgOMhldDgt8mbRrvxhXokgWlyPUKBfXVvmaGsB+RG8oi+I1nj5NwcI/yvQgaH6LuBK9+mJudaGAJRQA4nN4IOMwHOVSydg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00367.txt.bz2 --20cf3010edf39738c204c24acd22 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1624 On Tue, Jun 12, 2012 at 2:52 AM, Doug Evans wrote: > Let's go with "end_pc" and at least leave "pc" alone for now. Done. > One question we need to answer is what behaviour to expose in the API. > Is the range [pc,end_pc] or [pc,end_pc)? > [I know what the internal code does, but we don't have to follow it if > it makes for a sufficiently better API.] I have changed the behavior to [pc, end_pc] as this (at least the name) feels more meaningful to me. But, why was right open behavior chosen for internal code? Even the two-argument flavor of the 'disassemble' command has right open behavior. > And we need to clearly document this behaviour. I have described it in the documentation as "the end address of the program counter address range for the current source line". 2012-06-12 Siva Chandra Reddy New attribute 'end_pc' for gdb.Symtab_and_line. * NEWS (Python Scripting): Add entry about the new attribute. * python/py-symtab.c (salpy_get_end_pc): New function which implements the get method for the 'end_pc' attribute of gdb.Symtab_and_line. (sal_object_getset): Add entry for the 'end_pc' attribute. doc/ * gdb.texinfo (Symbol Tables In Python): Add description about the new 'end_pc' attribute of gdb.Symtab_and line. testsuite/ * gdb.python/py-symtab.exp: Add tests to test the new attribute 'end_pc' of gdb.Symtab_and_line. * gdb.python/py-symbol.c: Move break point comment to enable testing of gdb.Symtab_and_line.end_pc. Thanks, Siva Chandra --20cf3010edf39738c204c24acd22 Content-Type: text/plain; charset=US-ASCII; name="sal_end_patch_v2.txt" Content-Disposition: attachment; filename="sal_end_patch_v2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h3db8i9l0 Content-length: 5983 SW5kZXg6IE5FV1MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi9ORVdTLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjUyNwpkaWZmIC11IC1wIC1yMS41MjcgTkVXUwotLS0gTkVXUwk2IEp1biAy MDEyIDE4OjAzOjUzIC0wMDAwCTEuNTI3CisrKyBORVdTCTEyIEp1biAyMDEy IDE4OjI4OjAyIC0wMDAwCkBAIC02MCw2ICs2MCwxMCBAQAogICAqKiBOZXcg ZnVuY3Rpb24gZ2RiLmZpbmRfcGNfbGluZSB3aGljaCByZXR1cm5zIHRoZSBn ZGIuU3ltdGFiX2FuZF9saW5lCiAgICAgIG9iamVjdCBhc3NvY2lhdGVkIHdp dGggYSBQQyB2YWx1ZS4KIAorICAqKiBnZGIuU3ltdGFiX2FuZF9saW5lIGhh cyBuZXcgYXR0cmlidXRlICdlbmRfcGMnIHdoaWNoIGhvbGRzIHRoZSBlbmQK KyAgICAgYWRkcmVzcyBvZiB0aGUgcHJvZ3JhbSBjb3VudGVyIGFkZHJlc3Mg cmFuZ2UgZm9yIHRoZSBjdXJyZW50IHNvdXJjZQorICAgICBsaW5lLgorCiAq IEdvIGxhbmd1YWdlIHN1cHBvcnQuCiAgIEdEQiBub3cgc3VwcG9ydHMgZGVi dWdnaW5nIHByb2dyYW1zIHdyaXR0ZW4gaW4gdGhlIEdvIHByb2dyYW1taW5n CiAgIGxhbmd1YWdlLgpJbmRleDogZG9jL2dkYi50ZXhpbmZvCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvZG9j L2dkYi50ZXhpbmZvLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjk3NApkaWZm IC11IC1wIC1yMS45NzQgZ2RiLnRleGluZm8KLS0tIGRvYy9nZGIudGV4aW5m bwk4IEp1biAyMDEyIDEzOjA1OjU1IC0wMDAwCTEuOTc0CisrKyBkb2MvZ2Ri LnRleGluZm8JMTIgSnVuIDIwMTIgMTg6Mjg6MjEgLTAwMDAKQEAgLTI1MjYy LDYgKzI1MjYyLDExIEBAIEluZGljYXRlcyB0aGUgY3VycmVudCBwcm9ncmFt IGNvdW50ZXIgYWQKIHdyaXRhYmxlLgogQGVuZCBkZWZ2YXIKIAorQGRlZnZh ciBTeW10YWJfYW5kX2xpbmUuZW5kX3BjCitJbmRpY2F0ZXMgdGhlIGVuZCBh ZGRyZXNzIG9mIHRoZSBwcm9ncmFtIGNvdW50ZXIgYWRkcmVzcyByYW5nZSBm b3IKK3RoZSBjdXJyZW50IHNvdXJjZSBsaW5lLiAgVGhpcyBhdHRyaWJ1dGUg aXMgbm90IHdyaXRhYmxlLgorQGVuZCBkZWZ2YXIKKwogQGRlZnZhciBTeW10 YWJfYW5kX2xpbmUubGluZQogSW5kaWNhdGVzIHRoZSBjdXJyZW50IGxpbmUg bnVtYmVyIGZvciB0aGlzIG9iamVjdC4gIFRoaXMKIGF0dHJpYnV0ZSBpcyBu b3Qgd3JpdGFibGUuCkluZGV4OiBweXRob24vcHktc3ltdGFiLmMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9w eXRob24vcHktc3ltdGFiLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOQpk aWZmIC11IC1wIC1yMS45IHB5LXN5bXRhYi5jCi0tLSBweXRob24vcHktc3lt dGFiLmMJMyBNYXkgMjAxMiAwNzowNzoyNSAtMDAwMAkxLjkKKysrIHB5dGhv bi9weS1zeW10YWIuYwkxMiBKdW4gMjAxMiAxODoyODoyMiAtMDAwMApAQCAt MjM3LDYgKzIzNywxOSBAQCBzYWxweV9nZXRfcGMgKFB5T2JqZWN0ICpzZWxm LCB2b2lkICpjbG9zCiAgIHJldHVybiBnZGJfcHlfbG9uZ19mcm9tX3Vsb25n ZXN0IChzYWwtPnBjKTsKIH0KIAorLyogSW1wbGVtZW50YXRpb24gb2YgdGhl IGdldCBtZXRob2QgZm9yIHRoZSAnZW5kX3BjJyBhdHRyaWJ1dGUgb2YKKyAg IGdkYi5TeW10YWJfYW5kX2xpbmUuICAqLworCitzdGF0aWMgUHlPYmplY3Qg Kgorc2FscHlfZ2V0X2VuZF9wYyAoUHlPYmplY3QgKnNlbGYsIHZvaWQgKmNs b3N1cmUpCit7CisgIHN0cnVjdCBzeW10YWJfYW5kX2xpbmUgKnNhbCA9IE5V TEw7CisKKyAgU0FMUFlfUkVRVUlSRV9WQUxJRCAoc2VsZiwgc2FsKTsKKwor ICByZXR1cm4gZ2RiX3B5X2xvbmdfZnJvbV91bG9uZ2VzdCAoc2FsLT5lbmQg LSAxKTsKK30KKwogc3RhdGljIFB5T2JqZWN0ICoKIHNhbHB5X2dldF9saW5l IChQeU9iamVjdCAqc2VsZiwgdm9pZCAqY2xvc3VyZSkKIHsKQEAgLTU1Niw2 ICs1NjksOCBAQCBzdGF0aWMgUHlUeXBlT2JqZWN0IHN5bXRhYl9vYmplY3Rf dHlwZSA9CiBzdGF0aWMgUHlHZXRTZXREZWYgc2FsX29iamVjdF9nZXRzZXRb XSA9IHsKICAgeyAic3ltdGFiIiwgc2FscHlfZ2V0X3N5bXRhYiwgTlVMTCwg IlN5bXRhYiBvYmplY3QuIiwgTlVMTCB9LAogICB7ICJwYyIsIHNhbHB5X2dl dF9wYywgTlVMTCwgIlJldHVybiB0aGUgc3ltdGFiX2FuZF9saW5lJ3MgcGMu IiwgTlVMTCB9LAorICB7ICJlbmRfcGMiLCBzYWxweV9nZXRfZW5kX3BjLCBO VUxMLAorICAgICJSZXR1cm4gdGhlIHN5bXRhYl9hbmRfbGluZSdzIGVuZCBw Yy4iLCBOVUxMIH0sCiAgIHsgImxpbmUiLCBzYWxweV9nZXRfbGluZSwgTlVM TCwKICAgICAiUmV0dXJuIHRoZSBzeW10YWJfYW5kX2xpbmUncyBsaW5lLiIs IE5VTEwgfSwKICAge05VTEx9ICAvKiBTZW50aW5lbCAqLwpJbmRleDogdGVz dHN1aXRlL2dkYi5weXRob24vcHktc3ltYm9sLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUv Z2RiLnB5dGhvbi9weS1zeW1ib2wuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24g MS42CmRpZmYgLXUgLXAgLXIxLjYgcHktc3ltYm9sLmMKLS0tIHRlc3RzdWl0 ZS9nZGIucHl0aG9uL3B5LXN5bWJvbC5jCTMgTWF5IDIwMTIgMDc6MDc6MjYg LTAwMDAJMS42CisrKyB0ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW1ib2wu YwkxMiBKdW4gMjAxMiAxODoyODoyMyAtMDAwMApAQCAtNDAsOCArNDAsOCBA QCBpbnQgcXEgPSA3MjsJCQkvKiBsaW5lIG9mIHFxICovCiBpbnQgZnVuYyAo aW50IGFyZykKIHsKICAgaW50IGkgPSAyOwotICBpID0gaSAqIGFyZzsKLSAg cmV0dXJuIGFyZzsgLyogQmxvY2sgYnJlYWsgaGVyZS4gICovCisgIGkgPSBp ICogYXJnOyAvKiBCbG9jayBicmVhayBoZXJlLiAgKi8KKyAgcmV0dXJuIGFy ZzsKIH0KIAogc3RydWN0IHNpbXBsZV9zdHJ1Y3QKSW5kZXg6IHRlc3RzdWl0 ZS9nZGIucHl0aG9uL3B5LXN5bXRhYi5leHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUvZ2Ri LnB5dGhvbi9weS1zeW10YWIuZXhwLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjkKZGlmZiAtdSAtcCAtcjEuOSBweS1zeW10YWIuZXhwCi0tLSB0ZXN0c3Vp dGUvZ2RiLnB5dGhvbi9weS1zeW10YWIuZXhwCTMgTWF5IDIwMTIgMDc6MDc6 MjYgLTAwMDAJMS45CisrKyB0ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW10 YWIuZXhwCTEyIEp1biAyMDEyIDE4OjI4OjIzIC0wMDAwCkBAIC01NCwxMCAr NTQsMTMgQEAgZ2RiX3B5X3Rlc3Rfc2lsZW50X2NtZCAicHl0aG9uIHN0YXRp Y19ibAogZ2RiX3B5X3Rlc3Rfc2lsZW50X2NtZCAicHl0aG9uIGdsb2JhbF9z eW1ib2xzID0gXFtcXTsgc3RhdGljX3N5bWJvbHMgPSBcW1xdIiAiU2V0IHVw IHN5bWJvbCBuYW1lIGxpc3RzIiAwCiBnZGJfcHlfdGVzdF9zaWxlbnRfY21k ICJweXRob24gZm9yIHN5bSBpbiBnbG9iYWxfYmxvY2s6IGdsb2JhbF9zeW1i b2xzLmFwcGVuZChzeW0ubmFtZSkiICJHZXQgZ2xvYmFsIHN5bWJvbCBuYW1l cyIgMAogZ2RiX3B5X3Rlc3Rfc2lsZW50X2NtZCAicHl0aG9uIGZvciBzeW0g aW4gc3RhdGljX2Jsb2NrOiBzdGF0aWNfc3ltYm9scy5hcHBlbmQoc3ltLm5h bWUpIiAiR2V0IHN0YXRpYyBzeW1ib2wgbmFtZXMiIDAKK2dkYl9weV90ZXN0 X3NpbGVudF9jbWQgInN0ZXAiICJTdGVwIHRvIHRoZSBuZXh0IGxpbmUiIDAK K2dkYl9weV90ZXN0X3NpbGVudF9jbWQgInB5dGhvbiBuZXdfcGMgPSBnZGIu c2VsZWN0ZWRfZnJhbWUoKS5maW5kX3NhbCgpLnBjIiAiR2V0IG5ldyBQQyIg MAogCiAjIFRlc3Qgc2FsLgogZ2RiX3Rlc3QgInB5dGhvbiBwcmludCBzYWwu c3ltdGFiIiAiLipnZGIucHl0aG9uL3B5LXN5bWJvbC5jLioiICJUZXN0IHN5 bXRhYiIKIGdkYl90ZXN0ICJweXRob24gcHJpbnQgc2FsLnBjIiAiJHtkZWNp bWFsfSIgIlRlc3Qgc2FsLnBjIgorZ2RiX3Rlc3QgInB5dGhvbiBwcmludCBz YWwuZW5kX3BjID09IChuZXdfcGMgLSAxKSIgIlRydWUiICJUZXN0IHNhbC5l bmRfcGMiCiBnZGJfdGVzdCAicHl0aG9uIHByaW50IHNhbC5saW5lIiAiJGxp bmVfbm8iICJUZXN0IHNhbC5saW5lIgogZ2RiX3Rlc3QgInB5dGhvbiBwcmlu dCBzYWwuaXNfdmFsaWQoKSIgIlRydWUiICJUZXN0IHNhbC5pc192YWxpZCIK IAo= --20cf3010edf39738c204c24acd22--