From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10106 invoked by alias); 21 May 2012 08:40:49 -0000 Received: (qmail 9901 invoked by uid 22791); 21 May 2012 08:40:45 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qc0-f169.google.com (HELO mail-qc0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 May 2012 08:40:31 +0000 Received: by qcsd16 with SMTP id d16so3658560qcs.0 for ; Mon, 21 May 2012 01:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :x-system-of-record:x-gm-message-state; bh=dLWnMCKtoj9iMXLxvS5BsJlkKiB9DNkveBehZCx31tU=; b=Pw0jwu7nBwdfupfIZcMs9XdPVmgb65ZzzNoupuakHZkj9ZVDdH68ZVlZu7bT2s1UH4 g/Kg9W7xmdqiiZh6zDiCEqH8cqixfjMv47PxRkWZbKf4qoV1ROBGXoGSwOlTrir6p7kg 1rlOnUdaSVB5crzGtnfIldPxukW50MW31li8G7fiRoUtDWBuaA+0H/O73IoEZY+5JLyJ QDyqU3vTWoqJeUCZ67+SgDRlYK03NWIF2ja3d4yT4MkuK/z884TcWLUDDMylGTqi81+b ANYRC2381cLQ65agNAtU6Kest7lxcVSHGNoq+/iz4nGE6eBEtEQ6Y2XpMS2RQLxxRz2S YHtg== Received: by 10.224.117.66 with SMTP id p2mr22446473qaq.30.1337589630708; Mon, 21 May 2012 01:40:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.117.66 with SMTP id p2mr22446461qaq.30.1337589630552; Mon, 21 May 2012 01:40:30 -0700 (PDT) Received: by 10.224.222.19 with HTTP; Mon, 21 May 2012 01:40:30 -0700 (PDT) Date: Mon, 21 May 2012 08:40:00 -0000 Message-ID: Subject: [RFC - Python Scripting] Add 'end' attribute to gdb.Symtab_and_line From: Siva Chandra To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=20cf3074b472c8c9be04c087dafb X-System-Of-Record: true X-Gm-Message-State: ALoCoQmNjwUYRc3luQekv1NzJWhyV36pG5di5FkubE15YN34ErgydZwXF26Srl1uawLQozHlWm+sJOIiD2mszBodJVVn/Wl4i6wjwPzOYiLTxVhRrzdBfTn4ZBXu70YeIDqHf8xvlYKmLdY2kLwj3BL5+11OLUZVZQ== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00759.txt.bz2 --20cf3074b472c8c9be04c087dafb Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1488 Hello, Attached is a patch which adds the 'end' attribute to gdb.Symtab_and_line. Essentially, it exposes the 'end' field of 'struct symtab_and_line'. Though I have named the new attribute 'end' in the attached patch, I would like to discuss this. There is already an attribute 'pc' which is described as "Indicates the current program counter address" in the documentation. I do not think this description is accurate: 'pc' is actually the begin address of the program counter address range for the current source line. To indicate the right meaning of 'pc' and the new 'end' attribute, should they be named 'start_pc' and 'end_pc' respectively, at least in the python API? 2012-05-21 Siva Chandra Reddy New attribute 'end' for gdb.Symtab_and_line. * NEWS (Python Scripting): Add entry about the new attribute. * python/py-symtab.c (salpy_get_end): New function which implements the get method for the 'end' attribute of gdb.Symtab_and_line. (sal_object_getset): Add entry for the 'end' attribute. doc/ * gdb.texinfo (Symbol Tables In Python): Add description about the new 'end' attribute of gdb.Symtab_and line. testsuite/ * gdb.python/py-symtab.exp: Add tests to test the new attribute 'end' of gdb.Symtab_and_line. * gdb.python/py-symbol.c: Move break point comment to enable testing of gdb.Symtab_and_line.end. Thanks, Siva Chandra --20cf3074b472c8c9be04c087dafb Content-Type: text/plain; charset=US-ASCII; name="sal_end_patch_v1.txt" Content-Disposition: attachment; filename="sal_end_patch_v1.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h2h8abh70 Content-length: 5946 SW5kZXg6IE5FV1MKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi9ORVdTLHYKcmV0cmlldmluZyByZXZpc2lvbiAx LjUyNApkaWZmIC11IC1wIC1yMS41MjQgTkVXUwotLS0gTkVXUwkyMCBNYXkg MjAxMiAyMDozNToxOCAtMDAwMAkxLjUyNAorKysgTkVXUwkyMSBNYXkgMjAx MiAwNzoyMzowNyAtMDAwMApAQCAtNTgsNiArNTgsMTAgQEAKICAgKiogTmV3 IGZ1bmN0aW9uIGdkYi5maW5kX3BjX2xpbmUgd2hpY2ggcmV0dXJucyB0aGUg Z2RiLlN5bXRhYl9hbmRfbGluZQogICAgICBvYmplY3QgYXNzb2NpYXRlZCB3 aXRoIGEgUEMgdmFsdWUuCiAKKyAgKiogZ2RiLlN5bXRhYl9hbmRfbGluZSBo YXMgbmV3IGF0dHJpYnV0ZSAnZW5kJyB3aGljaCBob2xkcyB0aGUgb3Blbgor ICAgICB1cHBlciBib3VuZCBvZiB0aGUgcHJvZ3JhbSBjb3VudGVyIGFkZHJl c3MgcmFuZ2UgZm9yIHRoZSBjdXJyZW50CisgICAgIHNvdXJjZSBsaW5lLgor CiAqIEdvIGxhbmd1YWdlIHN1cHBvcnQuCiAgIEdEQiBub3cgc3VwcG9ydHMg ZGVidWdnaW5nIHByb2dyYW1zIHdyaXR0ZW4gaW4gdGhlIEdvIHByb2dyYW1t aW5nCiAgIGxhbmd1YWdlLgpJbmRleDogZG9jL2dkYi50ZXhpbmZvCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIv ZG9jL2dkYi50ZXhpbmZvLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjk3MApk aWZmIC11IC1wIC1yMS45NzAgZ2RiLnRleGluZm8KLS0tIGRvYy9nZGIudGV4 aW5mbwkyMCBNYXkgMjAxMiAyMDozNToxOSAtMDAwMAkxLjk3MAorKysgZG9j L2dkYi50ZXhpbmZvCTIxIE1heSAyMDEyIDA3OjIzOjE1IC0wMDAwCkBAIC0y NTI1OCw2ICsyNTI1OCwxMSBAQCBJbmRpY2F0ZXMgdGhlIGN1cnJlbnQgcHJv Z3JhbSBjb3VudGVyIGFkCiB3cml0YWJsZS4KIEBlbmQgZGVmdmFyCiAKK0Bk ZWZ2YXIgU3ltdGFiX2FuZF9saW5lLmVuZAorSW5kaWNhdGVzIHRoZSBvcGVu IHVwcGVyIGJvdW5kIG9mIHRoZSBwcm9ncmFtIGNvdW50ZXIgYWRkcmVzcyBy YW5nZSBmb3IKK3RoZSBjdXJyZW50IHNvdXJjZSBsaW5lLiAgVGhpcyBhdHRy aWJ1dGUgaXMgbm90IHdyaXRhYmxlLgorQGVuZCBkZWZ2YXIKKwogQGRlZnZh ciBTeW10YWJfYW5kX2xpbmUubGluZQogSW5kaWNhdGVzIHRoZSBjdXJyZW50 IGxpbmUgbnVtYmVyIGZvciB0aGlzIG9iamVjdC4gIFRoaXMKIGF0dHJpYnV0 ZSBpcyBub3Qgd3JpdGFibGUuCkluZGV4OiBweXRob24vcHktc3ltdGFiLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi9weXRob24vcHktc3ltdGFiLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuOQpkaWZmIC11IC1wIC1yMS45IHB5LXN5bXRhYi5jCi0tLSBweXRob24v cHktc3ltdGFiLmMJMyBNYXkgMjAxMiAwNzowNzoyNSAtMDAwMAkxLjkKKysr IHB5dGhvbi9weS1zeW10YWIuYwkyMSBNYXkgMjAxMiAwNzoyMzoxNSAtMDAw MApAQCAtMjM3LDYgKzIzNywxOSBAQCBzYWxweV9nZXRfcGMgKFB5T2JqZWN0 ICpzZWxmLCB2b2lkICpjbG9zCiAgIHJldHVybiBnZGJfcHlfbG9uZ19mcm9t X3Vsb25nZXN0IChzYWwtPnBjKTsKIH0KIAorLyogSW1wbGVtZW50YXRpb24g b2YgdGhlIGdldCBtZXRob2QgZm9yIHRoZSAnZW5kJyBhdHRyaWJ1dGUgb2YK KyAgIGdkYi5TeW10YWJfYW5kX2xpbmUuICAqLworCitzdGF0aWMgUHlPYmpl Y3QgKgorc2FscHlfZ2V0X2VuZCAoUHlPYmplY3QgKnNlbGYsIHZvaWQgKmNs b3N1cmUpCit7CisgIHN0cnVjdCBzeW10YWJfYW5kX2xpbmUgKnNhbCA9IE5V TEw7CisKKyAgU0FMUFlfUkVRVUlSRV9WQUxJRCAoc2VsZiwgc2FsKTsKKwor ICByZXR1cm4gZ2RiX3B5X2xvbmdfZnJvbV91bG9uZ2VzdCAoc2FsLT5lbmQp OworfQorCiBzdGF0aWMgUHlPYmplY3QgKgogc2FscHlfZ2V0X2xpbmUgKFB5 T2JqZWN0ICpzZWxmLCB2b2lkICpjbG9zdXJlKQogewpAQCAtNTU2LDYgKzU2 OSw3IEBAIHN0YXRpYyBQeVR5cGVPYmplY3Qgc3ltdGFiX29iamVjdF90eXBl ID0KIHN0YXRpYyBQeUdldFNldERlZiBzYWxfb2JqZWN0X2dldHNldFtdID0g ewogICB7ICJzeW10YWIiLCBzYWxweV9nZXRfc3ltdGFiLCBOVUxMLCAiU3lt dGFiIG9iamVjdC4iLCBOVUxMIH0sCiAgIHsgInBjIiwgc2FscHlfZ2V0X3Bj LCBOVUxMLCAiUmV0dXJuIHRoZSBzeW10YWJfYW5kX2xpbmUncyBwYy4iLCBO VUxMIH0sCisgIHsgImVuZCIsIHNhbHB5X2dldF9lbmQsIE5VTEwsICJSZXR1 cm4gdGhlIHN5bXRhYl9hbmRfbGluZSdzIGVuZCBwYy4iLCBOVUxMIH0sCiAg IHsgImxpbmUiLCBzYWxweV9nZXRfbGluZSwgTlVMTCwKICAgICAiUmV0dXJu IHRoZSBzeW10YWJfYW5kX2xpbmUncyBsaW5lLiIsIE5VTEwgfSwKICAge05V TEx9ICAvKiBTZW50aW5lbCAqLwpJbmRleDogdGVzdHN1aXRlL2dkYi5weXRo b24vcHktc3ltYm9sLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1z eW1ib2wuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS42CmRpZmYgLXUgLXAg LXIxLjYgcHktc3ltYm9sLmMKLS0tIHRlc3RzdWl0ZS9nZGIucHl0aG9uL3B5 LXN5bWJvbC5jCTMgTWF5IDIwMTIgMDc6MDc6MjYgLTAwMDAJMS42CisrKyB0 ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW1ib2wuYwkyMSBNYXkgMjAxMiAw NzoyMzoxNiAtMDAwMApAQCAtNDAsOCArNDAsOCBAQCBpbnQgcXEgPSA3MjsJ CQkvKiBsaW5lIG9mIHFxICovCiBpbnQgZnVuYyAoaW50IGFyZykKIHsKICAg aW50IGkgPSAyOwotICBpID0gaSAqIGFyZzsKLSAgcmV0dXJuIGFyZzsgLyog QmxvY2sgYnJlYWsgaGVyZS4gICovCisgIGkgPSBpICogYXJnOyAvKiBCbG9j ayBicmVhayBoZXJlLiAgKi8KKyAgcmV0dXJuIGFyZzsKIH0KIAogc3RydWN0 IHNpbXBsZV9zdHJ1Y3QKSW5kZXg6IHRlc3RzdWl0ZS9nZGIucHl0aG9uL3B5 LXN5bXRhYi5leHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9zcmMvc3JjL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW10 YWIuZXhwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjkKZGlmZiAtdSAtcCAt cjEuOSBweS1zeW10YWIuZXhwCi0tLSB0ZXN0c3VpdGUvZ2RiLnB5dGhvbi9w eS1zeW10YWIuZXhwCTMgTWF5IDIwMTIgMDc6MDc6MjYgLTAwMDAJMS45Cisr KyB0ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1zeW10YWIuZXhwCTIxIE1heSAy MDEyIDA3OjIzOjE2IC0wMDAwCkBAIC01NCwxMCArNTQsMTMgQEAgZ2RiX3B5 X3Rlc3Rfc2lsZW50X2NtZCAicHl0aG9uIHN0YXRpY19ibAogZ2RiX3B5X3Rl c3Rfc2lsZW50X2NtZCAicHl0aG9uIGdsb2JhbF9zeW1ib2xzID0gXFtcXTsg c3RhdGljX3N5bWJvbHMgPSBcW1xdIiAiU2V0IHVwIHN5bWJvbCBuYW1lIGxp c3RzIiAwCiBnZGJfcHlfdGVzdF9zaWxlbnRfY21kICJweXRob24gZm9yIHN5 bSBpbiBnbG9iYWxfYmxvY2s6IGdsb2JhbF9zeW1ib2xzLmFwcGVuZChzeW0u bmFtZSkiICJHZXQgZ2xvYmFsIHN5bWJvbCBuYW1lcyIgMAogZ2RiX3B5X3Rl c3Rfc2lsZW50X2NtZCAicHl0aG9uIGZvciBzeW0gaW4gc3RhdGljX2Jsb2Nr OiBzdGF0aWNfc3ltYm9scy5hcHBlbmQoc3ltLm5hbWUpIiAiR2V0IHN0YXRp YyBzeW1ib2wgbmFtZXMiIDAKK2dkYl9weV90ZXN0X3NpbGVudF9jbWQgInN0 ZXAiICJTdGVwIHRvIHRoZSBuZXh0IGxpbmUiIDAKK2dkYl9weV90ZXN0X3Np bGVudF9jbWQgInB5dGhvbiBuZXdfcGMgPSBnZGIuc2VsZWN0ZWRfZnJhbWUo KS5maW5kX3NhbCgpLnBjIiAiR2V0IG5ldyBQQyIgMAogCiAjIFRlc3Qgc2Fs LgogZ2RiX3Rlc3QgInB5dGhvbiBwcmludCBzYWwuc3ltdGFiIiAiLipnZGIu cHl0aG9uL3B5LXN5bWJvbC5jLioiICJUZXN0IHN5bXRhYiIKIGdkYl90ZXN0 ICJweXRob24gcHJpbnQgc2FsLnBjIiAiJHtkZWNpbWFsfSIgIlRlc3Qgc2Fs LnBjIgorZ2RiX3Rlc3QgInB5dGhvbiBwcmludCBzYWwuZW5kID09IG5ld19w YyIgIlRydWUiICJUZXN0IHNhbC5lbmQiCiBnZGJfdGVzdCAicHl0aG9uIHBy aW50IHNhbC5saW5lIiAiJGxpbmVfbm8iICJUZXN0IHNhbC5saW5lIgogZ2Ri X3Rlc3QgInB5dGhvbiBwcmludCBzYWwuaXNfdmFsaWQoKSIgIlRydWUiICJU ZXN0IHNhbC5pc192YWxpZCIKIAo= --20cf3074b472c8c9be04c087dafb--