From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128869 invoked by alias); 25 Oct 2016 01:08:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128859 invoked by uid 89); 25 Oct 2016 01:08:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f180.google.com Received: from mail-qk0-f180.google.com (HELO mail-qk0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 01:08:11 +0000 Received: by mail-qk0-f180.google.com with SMTP id o68so251308465qkf.3 for ; Mon, 24 Oct 2016 18:08:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PdpHtN4wz6HMUKSjcea2Yi59K46O3wNO5fhgqA/oIx8=; b=J8Y5H86QQ0tViolh6Fo5KzU3HkET318kbdqetdq4WJ2Y6S7pUEXAkbn2H2ch36xtHs ATYQHcdAn0MnQz/SYktDpCbMaVUDUx8UUTsSizdkwvmFxTKpVybiSNmx6fx1QDDOonsH oHkOxWR5BAhPAJcNgqSUKYtIjnDWMfE8ZIpDBPiU5l0y51ps0K2wjf0M8mfJ8Bvf4/rQ DoY3lwxmL4iWBZJQvcI35Ja8ETmiT2oMzQ38HqGWsL9BEzvANF1Vo88ral5W13C2MVPB ntHP2k/7ZeR1Bgq69a8dMr020/yx2kWg1Dlq/UB8BFmuvAtwjoqoQ2xivM7lnQs2VYWE iSSQ== X-Gm-Message-State: ABUngvfOgdmNcNXRdBpAtRTllw7mmxI3I32NAcKt6VIkrKxowvdpLl4lBQYQlH2NI06/d09uNbDyOGgzIshcWQ== X-Received: by 10.55.151.70 with SMTP id z67mr18715541qkd.185.1477357689635; Mon, 24 Oct 2016 18:08:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.131.225 with HTTP; Mon, 24 Oct 2016 18:08:09 -0700 (PDT) In-Reply-To: <12052de4-a0dd-8d23-2f46-57e91059cfa5@redhat.com> References: <01ba546d-060d-8591-9c5a-84d4bda2af22@redhat.com> <9a7ac4b5-2f5c-916c-a52e-c94e64d6f4f0@redhat.com> <12052de4-a0dd-8d23-2f46-57e91059cfa5@redhat.com> From: David Edelsohn Date: Tue, 25 Oct 2016 01:08:00 -0000 Message-ID: Subject: Re: GDB AIX build broken To: Pedro Alves Cc: GDB Patches Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-10/txt/msg00683.txt.bz2 On Mon, Oct 24, 2016 at 8:50 PM, Pedro Alves wrote: > On 10/25/2016 01:31 AM, Pedro Alves wrote: >> On 10/25/2016 01:13 AM, David Edelsohn wrote: >>> On Mon, Oct 24, 2016 at 7:00 PM, Pedro Alves wrote: >>> >>>> That's a hint, but it can't be the fix. common-defs.h must be the >>>> first file included. I suspect that gnulib's inttypes.h >>>> replacement logic is broken on AIX. >>> >>> The gnulib import definitely is the commit that caused the breakage. > > Could it be it's the commit after the import? The one > that removes __STDC_CONSTANT_MACROS/__STDC_LIMIT_MACROS from > common-defs.h? common-defs.h needs __STDC_FORMAT_MACROS defined before stdio.h is included, as one possible solution. Thanks, David > Looking at the import (49e4877c5487), we see that stdint.h > now relies on a new limits.h replacement, which sounds suspicious. > > # The substitute stdint.h needs the substitute limit.h's _GL_INTEGER_WIDTH: > > + LIMITS_H=limits.h > + if test -n "$LIMITS_H"; then > + GL_GENERATE_LIMITS_H_TRUE= > + GL_GENERATE_LIMITS_H_FALSE='#' > +else > + GL_GENERATE_LIMITS_H_TRUE='#' > + GL_GENERATE_LIMITS_H_FALSE= > > > and it had this change: > > --- a/gdb/gnulib/import/stdint.in.h > +++ b/gdb/gnulib/import/stdint.in.h > @@ -1,4 +1,4 @@ > -/* Copyright (C) 2001-2002, 2004-2015 Free Software Foundation, Inc. > +/* Copyright (C) 2001-2002, 2004-2016 Free Software Foundation, Inc. > Written by Paul Eggert, Bruno Haible, Sam Steingold, Peter Burwood. > This file is part of gnulib. > > @@ -79,54 +79,51 @@ > #if ! defined _@GUARD_PREFIX@_STDINT_H && ! defined _GL_JUST_INCLUDE_SYSTEM_STDINT_H > #define _@GUARD_PREFIX@_STDINT_H > > +/* Get SCHAR_MIN, SCHAR_MAX, UCHAR_MAX, INT_MIN, INT_MAX, > + LONG_MIN, LONG_MAX, ULONG_MAX, _GL_INTEGER_WIDTH. */ > +#include > + > +#if ! @HAVE_C99_STDINT_H@ > + > /* defines some of the stdint.h types as well, on glibc, > IRIX 6.5, and OpenBSD 3.8 (via ). > AIX 5.2 isn't needed and causes troubles. > Mac OS X 10.4.6 includes (which is us), but > relies on the system definitions, so include > after @NEXT_STDINT_H@. */ > -#if @HAVE_SYS_TYPES_H@ && ! defined _AIX > -# include > -#endif > - > -/* Get SCHAR_MIN, SCHAR_MAX, UCHAR_MAX, INT_MIN, INT_MAX, > - LONG_MIN, LONG_MAX, ULONG_MAX. */ > -#include > +# if @HAVE_SYS_TYPES_H@ && ! defined _AIX > +# include > +# endif > > > Note the new HAVE_C99_STDINT_H check. The _AIX check > is also curious. > > Thanks, > Pedro Alves >