From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-104571-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4855 invoked by alias); 23 Aug 2013 07:23:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4837 invoked by uid 89); 23 Aug 2013 07:23:19 -0000
X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.2
Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 07:22:51 +0000
Received: by mail-vc0-f171.google.com with SMTP id ij15so188220vcb.2        for <gdb-patches@sourceware.org>; Fri, 23 Aug 2013 00:22:49 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.58.211.227 with SMTP id nf3mr15419824vec.20.1377242569129; Fri, 23 Aug 2013 00:22:49 -0700 (PDT)
Received: by 10.220.53.132 with HTTP; Fri, 23 Aug 2013 00:22:49 -0700 (PDT)
In-Reply-To: <20130823004837.GC5221@adacore.com>
References: <CAGWvnynVeLt6F-QREsP_CtQvwvtZgwqHxtcS6pn58LMf=AX=GA@mail.gmail.com>	<OF91B6D42F.B0CFCB9C-ON65257BC5.004284AA-65257BC5.0042F553@in.ibm.com>	<CAGWvnynzsNL--qPhHOhqZ912A4M9ZpXtT2JbjW4EHRodEXAF9Q@mail.gmail.com>	<20130822233234.GA13292@adacore.com>	<20130823004837.GC5221@adacore.com>
Date: Fri, 23 Aug 2013 07:23:00 -0000
Message-ID: <CAGWvnymjyCc9vFbh4+eNdr2mdxJYU0=LFC1-itC38SDKfRaG-w@mail.gmail.com>
Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
From: David Edelsohn <dje.gcc@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Raunaq 12 <raunaq12@in.ibm.com>, GDB Patches <gdb-patches@sourceware.org>, 	Mark Kettenis <mark.kettenis@xs4all.nl>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
X-SW-Source: 2013-08/txt/msg00665.txt.bz2

On Thu, Aug 22, 2013 at 8:48 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello again,
>
>> Actually, I just found that it breaks thread support on 32bit AIX,
>> at least.  A simpler way to show the problem is:
>>
>>     (gdb) x /x &__n_pthreads
>>     0xf06a8258 <__n_pthreads>:      Cannot access memory at address 0xf06a8258
>>
>> Prior to the patch, we have:
>>
>>     (gdb) x /x &__n_pthreads
>>     0xf06a8258 <__n_pthreads>:      0x00000003
>
> Attached is the patch I checked in locally at AdaCore:
>
> gdb/ChangeLog:
>
>         * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
>         instead of "long long" in call to ptrace64.
>
> Tested on ppc-aix in full 32bit mode (both GDB and inferior are
> 32bit). I think the other scenario would be 64bit GDB debugging
> a 32bit inferior, but I don't have a 64bit compiler to try it.
>
> I'd like to commit this patch, unless there are comments/suggestions.

LGTM.

Is there a testcase that can be added to the GDB testsuite to catch
this type of regression?

Thanks, David