From: "Leszek Swirski via gdb-patches" <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Leszek Swirski via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] MI: Allow non-raw varobj evaluation
Date: Fri, 02 Feb 2018 09:01:00 -0000 [thread overview]
Message-ID: <CAGRskv8Mr51cVY+BVxHQQFgEKCQNrbi0Vdnq2RuXRBy7WU53vQ@mail.gmail.com> (raw)
In-Reply-To: <a7d57157-139c-57d1-383a-65ac8047056e@polymtl.ca>
On Fri, 2 Feb 2018, 04:27 Simon Marchi, <simon.marchi@polymtl.ca> wrote:
>
> Also, from what I understand we don't have a test for this, so I converted your example
> to a test case. If you are fine, I would push the following patch.
That looks fantastic, I'm happy for you to push the amended patch and
thank you for your due diligence.
next prev parent reply other threads:[~2018-02-02 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 17:32 Leszek Swirski via gdb-patches
2018-01-25 2:53 ` Simon Marchi
2018-01-25 11:11 ` Leszek Swirski via gdb-patches
2018-02-02 4:27 ` Simon Marchi
2018-02-02 9:01 ` Leszek Swirski via gdb-patches [this message]
2018-02-02 19:05 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGRskv8Mr51cVY+BVxHQQFgEKCQNrbi0Vdnq2RuXRBy7WU53vQ@mail.gmail.com \
--to=gdb-patches@sourceware.org \
--cc=leszeks@google.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox