From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116444 invoked by alias); 11 Jun 2017 13:55:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116423 invoked by uid 89); 11 Jun 2017 13:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f169.google.com Received: from mail-wr0-f169.google.com (HELO mail-wr0-f169.google.com) (209.85.128.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Jun 2017 13:55:21 +0000 Received: by mail-wr0-f169.google.com with SMTP id v104so71896785wrb.0 for ; Sun, 11 Jun 2017 06:55:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=4QjPhfDBaFqMU5v0qTyegWvTosC4nwUMhQnUYQbm8rM=; b=uCOzciFvp66gYIPaXWAoucC7KmaaznV4OHBy5AGimVizywo1vFUU0kqJZovMuvxOYU H4bt5NWZb+YhKSw+lhVK5JWo5usxgOa1tGLn9y/0jPzpjmOq2E4iklaLC/h0dFfbQhKa MbCnczTHTadRqmqTbcpG4zv6E3WUlJMqEJx59hM7Y0pHnVylcRvrXhlFvDXj28eLW1lg u/bFn1JqqId7926CX1DnjGGF2RBEQvwKDCkoGKU0/wm3btkP4jkFmvFA2DznEkXGTV0c 5r5coUIyqWuJF1fvnqWR5cMQSHfiL/1VNpjhnvdr+avQC6IBj4HrnrAwc2q1P8XPih9f 6HXg== X-Gm-Message-State: AODbwcAlVAfvRZh8mXdHxD3a81FJVRpZqEHoL2pVto3rNPswbFeVuq9s KqLfZ2yk4NvEF400ub/VAk56kKUAk2TP X-Received: by 10.80.183.4 with SMTP id g4mr39261383ede.138.1497189323658; Sun, 11 Jun 2017 06:55:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.137.173 with HTTP; Sun, 11 Jun 2017 06:55:23 -0700 (PDT) In-Reply-To: References: From: Orgad Shaneh Date: Sun, 11 Jun 2017 13:55:00 -0000 Message-ID: Subject: Re: [PATCH] Fix python compatibility with old gdb versions To: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-06/txt/msg00261.txt.bz2 On Wed, Mar 8, 2017 at 10:23 AM, Orgad Shaneh wrote: > > Type.name was introduced in GDB 7.9. > --- > gdb/python/lib/gdb/printing.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/python/lib/gdb/printing.py b/gdb/python/lib/gdb/printing.py > index 181701c719..106da4ac8b 100644 > --- a/gdb/python/lib/gdb/printing.py > +++ b/gdb/python/lib/gdb/printing.py > @@ -205,7 +205,7 @@ class RegexpCollectionPrettyPrinter(PrettyPrinter): > > # Get the type name. > typename = gdb.types.get_basic_type(val.type).tag > - if not typename: > + if not typename and hasattr(val.type, "name"): > typename = val.type.name > if not typename: > return None > -- > 2.12.0.windows.1 ping? - Orgad