From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93303 invoked by alias); 12 Jun 2017 04:31:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93284 invoked by uid 89); 12 Jun 2017 04:31:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f176.google.com Received: from mail-wr0-f176.google.com (HELO mail-wr0-f176.google.com) (209.85.128.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Jun 2017 04:31:55 +0000 Received: by mail-wr0-f176.google.com with SMTP id g76so82150893wrd.1 for ; Sun, 11 Jun 2017 21:31:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WG1E6pddN2nl89xDCLfuEuQUF1lAR8wq/iqhWYKKDDQ=; b=HI2IJe5mdEj2HKneMsrR98/8DJVobjlVElyC20mUh/aWgChANxTuMh0P6jtCTAWekB bT67PFMx26+HoHSSdvFMSHHF4n/gRg4LEvVCbzjkXAarM085Yk4g3Hj/zfGrn/x7p+sH ZhKTZzeb3ufPtdRCjzHIc9fqtQ2uc2PcJvWPakz7i/ssWP3jOSJrGCb1LbTt43hwf47F EncFITLe1/LUADWlklX6KEXztRt22axO7u/47mlElU+r7U48xnsZn/9J4mbBohB57z3m WTep1EFEmb8PQYjJAqMEUW0H4V7hsqH5WTdlSc1IChat0vmbGOuvi7ZA16Yji76QsYNl iPOQ== X-Gm-Message-State: AODbwcBI6Kv8M6RjHC3kEzXM7I+kqLWQM3CVOJLUnpB3/MfcQcDtff21 zg9x/5hzauDjX+jK+5eu2Ug/Vq+D2AZp X-Received: by 10.80.177.151 with SMTP id m23mr29130838edd.162.1497241917747; Sun, 11 Jun 2017 21:31:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.137.173 with HTTP; Sun, 11 Jun 2017 21:31:57 -0700 (PDT) In-Reply-To: References: From: Orgad Shaneh Date: Mon, 12 Jun 2017 04:31:00 -0000 Message-ID: Subject: Re: [PATCH] Fix python compatibility with old versions of GDB To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-06/txt/msg00267.txt.bz2 On Mon, Jun 12, 2017 at 12:09 AM, Simon Marchi wrote: > On 2017-06-11 19:48, Orgad Shaneh wrote: >> >> If data-directory is shared between various version of GDB, it should >> work for all of them. >> >> There are several hasattr conditions that enable this kind of >> compatibility. >> >> RegexpCollectionPrettyPrinter was missing a check that enables it to >> work with GDB prior to 7.9, when Type.name was introduced. > > > Hi Orgad, > > I still don't understand what problem this is trying to fix. It looks like > you want to make older versions of GDB work with newer versions of the > Python scripts in the data directory. I am not sure this is what we want. > If you want multiple version of GDB in parallel on a system, they should all > be compiled with a different --prefix, and they will all get their own > data-directory. We should only expect a certain version of the data > directory to be compatible with the version of GDB it was shipped with. Or > am I missing some use case where this is not true? Hi, Practically the data-directory is mostly backwards-compatible, except this small part which I found (there might be others which I didn't find). With this patch, I'm able to run GDB 7.8 with the latest data-directory. Is there a reason not to accept it? - Orgad