From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uOcFAKKpgGDWRQAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 18:39:30 -0400 Received: by simark.ca (Postfix, from userid 112) id F21F41F104; Wed, 21 Apr 2021 18:39:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 402551E789 for ; Wed, 21 Apr 2021 18:39:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06CEF3838013; Wed, 21 Apr 2021 22:39:29 +0000 (GMT) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 3496D3846012 for ; Wed, 21 Apr 2021 22:39:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3496D3846012 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ed1-x52c.google.com with SMTP id h8so11017275edb.2 for ; Wed, 21 Apr 2021 15:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=mYcVZ+KH+KScrnvWQhxt47FBb5PfNeZRS2qRmio8xdI=; b=FNJKAHoKsfvaZUDzTMjN62FyEffUB4qb1w+CsDIUcxfI+gk1l+hLl71HV61t+AObBk IscUDHuT44gpj756cD/fY8ReNsm+QgmBDJ6f3Kj7BYHFztVZG1OHE2w6/X7KdD8wgMRD Qvd5D4GxzDgH0Kff02Z2Z1nLaCCCQAANBUqFRlcBHqkFth+5z9kGNsvYkfJNC71aa9id jAN0klG6zZ5FY3Jj2uYLQmW3OGW8JRrTOm3X95J0/dixPWw1CZ7YmcZFZHPS9NNNy11B 9pGNKnht+LuqIHj16eU3W1BamDXh+jI7DAlKRkRSW0sUNHKwY8fFsVtVOyGtdhpTDgRY kOuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=mYcVZ+KH+KScrnvWQhxt47FBb5PfNeZRS2qRmio8xdI=; b=QOSIdaWktJyec7nK7pDQ6QL5n+9ekBMMYSkU42rRUt9EVpDp8QNJi3I2kjQralJxo/ 1uAEVxEN3IQ9xWsh8Suk0ghxm41w/KxlxX47YZuBoTEFQzKI94hO+8/EDUwOYF0iogPy d26clqF2NLgwGjd5S5KlcrGZCYhOthz1EOrsFfdgfIDLSu2uYOYdWw/k5RgOIVcHil7p GSXu8VBUeI04LZzbKA+rw5iL9TqchJ2Jqe0WWlUD/lSd+FCHtpEQATvMEAUIunSdKMfz Q6jnGcnNcdH2eeQDtoa6traybiUjvjVdP45kHY9IfZY+RHxbV8WxZtQNTvz/MtgnZqpG vB5A== X-Gm-Message-State: AOAM532yQfHb7xI7YFrOANSCtg1yDu6Vx4IPuAOjyrGCSnzQ+4kC2yAg nm8Ryc452zityWwi0BXbhHIZrxarOtN9UeY99jWgSjOG7VGAsA== X-Google-Smtp-Source: ABdhPJxG0DhsT1iCWthdfSpgOeh7fRXxoUBcGS5f6gAeHf1LAN339avX2S73jZY8rXUnSNxi19F9Ffk5Q4eMafv1J1s= X-Received: by 2002:a05:6402:b31:: with SMTP id bo17mr274310edb.46.1619044766340; Wed, 21 Apr 2021 15:39:26 -0700 (PDT) MIME-Version: 1.0 References: <20210417175831.16413-1-jimw@sifive.com> <20210417175831.16413-6-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Wed, 21 Apr 2021 15:39:15 -0700 Message-ID: Subject: Re: [PATCH 05/24] RISC-V sim: Fix stack pointer alignment. To: Jim Wilson , gdb-patches@sourceware.org, Kuan-Lin Chen Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sun, Apr 18, 2021 at 8:58 PM Mike Frysinger wrote: > > + /* Synchronize sp alignment with GCC's STACK_BOUNDARY. */ > > ... this is not. this should state the reason as ABI requirements, not a > random toolchain implementation. > OK. I rewrote the comment as /* Align stack as per ABI requirement. 16 bytes for rv32i and rv64i. */ JIm