From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81532 invoked by alias); 26 Oct 2018 17:34:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80996 invoked by uid 89); 26 Oct 2018 17:34:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Committed X-HELO: mail-vs1-f68.google.com Received: from mail-vs1-f68.google.com (HELO mail-vs1-f68.google.com) (209.85.217.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 17:34:32 +0000 Received: by mail-vs1-f68.google.com with SMTP id h78so234506vsi.6 for ; Fri, 26 Oct 2018 10:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CcRigUmiFZsL2m67ze28wgzj3na+uTq+xG3vScVXCV8=; b=miSAwexfLixrn9+0ImYZVSa7jsMfoiq5CcYsMUvkSUdad4OlZPg4h2inEqLJJh/o27 CU/P5BJnmjF2+ler//l5BVtQbWnYT3rPlN22BjbFwIXs5p+pbddFhPCur/aoBxZV1dOJ PrNapTVwIvexjTBA+3vNeVSovhZ9udvuWctb6OZ+l/AUJFii4PWlr5gxcn8RNEsMX9bv 7o/EghTWHf7/jLAid7gNCM9aM3dFcPOemUQw5vKvf3E3yqM/w9E1S0CwX24VkSkKJvsw y78n0uXnJMTUACfH+DvUjWMvbOO4AMH0THoJx0lYVe85G9LPwQzJwHXVXk/z34TfewtV k7qw== MIME-Version: 1.0 References: <20181025235935.3781-1-jimw@sifive.com> <20181025202529.5b52880e@pinnacle.lan> In-Reply-To: <20181025202529.5b52880e@pinnacle.lan> From: Jim Wilson Date: Fri, 26 Oct 2018 17:34:00 -0000 Message-ID: Subject: Re: [PATCH 1/2] RISC-V: Linux signal frame support. To: kevinb@redhat.com Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-10/txt/msg00628.txt.bz2 On Thu, Oct 25, 2018 at 8:25 PM Kevin Buettner wrote: > > On Thu, 25 Oct 2018 16:59:35 -0700 > Jim Wilson wrote: > > > Make riscv_isa_flen available to the linux native code, and clean up duplicate > > comments. > > > > gdb/ > > * riscv-tdep.c (riscv_isa_xlen): Refer to riscv-tdep.h comment. > > (riscv_isa_flen): Likewise. Drop static. > > * riscv-tdep.h (riscv_isa_xlen): Move riscv-tdep.c comment to here. > > (riscv_isa_flen): Likewise. > > Maybe: > > (riscv_isa_flen): Likewise; declare. > > ? > > Otherwise, LGTM. Thanks. Committed with the corrected ChangeLog entry. Jim