From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-163648-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 34743 invoked by alias); 29 Jan 2020 23:26:11 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 33233 invoked by uid 89); 29 Jan 2020 23:26:11 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-vs1-f65.google.com
Received: from mail-vs1-f65.google.com (HELO mail-vs1-f65.google.com) (209.85.217.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Jan 2020 23:26:10 +0000
Received: by mail-vs1-f65.google.com with SMTP id t12so932821vso.13        for <gdb-patches@sourceware.org>; Wed, 29 Jan 2020 15:26:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=sifive.com; s=google;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=l2JNOrXPgFzvrmdHd1dFSIztaLCd1y2w2a/29YDIQEQ=;        b=ZbGvqj5wc46BtJqstOAqNvVNZxyl6KJJvfn+etJQR0YlBhS3eYRuHwkl/OKY6XHvIz         kHq/JU3JAbg8Pp3wJJMWN11s/dy3TRJ4oRgDU4qB4xZWlRp26Okf2LGmNCgD4HOMJI/r         1bU69DAra4etmF9JpISeDGAbNTa7PiKfFB93wYLLL/wkoKubSCaVTdFfKNcPwqBTvYig         MvKwn6JRsL+3TIzOkK+nF8gay3p6gkz5Muq9v384Vl6K/rY3kmsd5ntSUP/sYxCc1OHl         LcGRl/OQW9/jhvtLFe/olNXLPhNg1Pj7TVOnqV9PEn3dllQQuXDEEKAjdzwAUW6hGzxo         eJwg==
MIME-Version: 1.0
References: <alpine.LFD.2.21.2001291207310.14118@redsun52.ssa.fujisawa.hgst.com> <alpine.LFD.2.21.2001291412340.14118@redsun52.ssa.fujisawa.hgst.com>
In-Reply-To: <alpine.LFD.2.21.2001291412340.14118@redsun52.ssa.fujisawa.hgst.com>
From: Jim Wilson <jimw@sifive.com>
Date: Wed, 29 Jan 2020 23:39:00 -0000
Message-ID: <CAFyWVaabU5csqGn12DtSrRw9tPkFqAtPW3wD+9VZgeC_tg_hHA@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] RISC-V/Linux/native: Factor out target description determination
To: "Maciej W. Rozycki" <macro@wdc.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, 	Andrew Burgess <andrew.burgess@embecosm.com>, Palmer Dabbelt <palmer@dabbelt.com>, 	Tom Tromey <tom@tromey.com>, "guoren@kernel.org" <guoren@kernel.org>, 	"lifang_xia@c-sky.com" <lifang_xia@c-sky.com>, "yunhai_shang@c-sky.com" <yunhai_shang@c-sky.com>, 	"jiangshuai_li@c-sky.com" <jiangshuai_li@c-sky.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2020-01/txt/msg00962.txt.bz2

On Wed, Jan 29, 2020 at 10:13 AM Maciej W. Rozycki <macro@wdc.com> wrote:
>         gdb/
>         * nat/riscv-linux-tdesc.h: New file.
>         * nat/riscv-linux-tdesc.c: New file, taking code from...
>         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
>         ... here.
>         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
>         NATDEPFILES.

Looks good to me, though I'm not an official reviewer.

Jim