Re: [PATCH] riscv: add gdbserver support

Andrew Burgess
2020-01-21T12:57:15Z

* Simon Marchi <simark@simark.ca> [2020-01-20 20:31:31 -0500]:

> On 2020-01-20 6:33 p.m., Maciej W. Rozycki wrote:
> > Offhand I can see the proposal fails to implement XML register
> > descriptions, which I think every modern port is expected to do (we also
> > need to disallow non-XML-enabled RISC-V stubs in GDB proper, as we
> > discussed before; I fail to understand why it wasn't done right away with
> > the initial implementation, as it's quite straightforward and would have
> > set the policy for debug stubs right from the beginning).
>
> I would also expect new ports to use XML target descriptions. And I see
> that there is already code in arch/riscv.c to build target descriptions based
> on detected features... so should gdbserver use it?

Completely agree.

I started reviewing this patch last weekend, but ended up getting
distracted when I tried to get a RISC-V/Linux VM running again - the
instructions I previously followed[1] no longer produce a usable VM.

I had planned to go back and review this code next w/e, but I might
hold off now to see if the xml issue is addressed.

Thanks,
Andrew