From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by sourceware.org (Postfix) with ESMTPS id 35DFF386F477 for ; Tue, 9 Jun 2020 20:15:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 35DFF386F477 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-vs1-xe35.google.com with SMTP id u17so12812151vsu.7 for ; Tue, 09 Jun 2020 13:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3lUasf8H3y2HCvhJRDvzITE9jm/etzHFKTEYTIq4KLY=; b=Jccyup8zQYRLa3YoR1wagzYWmF7pldwN78kOwqJTDH2Z1J5YQ1P8Wx5IkrS0AXnBGP 6J2sPWCCfa8+0TrHMCcGgZ2gPSuFbG3zhiFSQGEAvfMiW2YHTwseO/EYETgtXi8jHqPZ /UcP1OYWx+CY2Z3fZ/4nfghL8328MvqjbmbksMCTXmFL+R4M6xNlFg/oObhp4g60f+FX XwGvhrNd69z/y62CRimUlZxakyQ2gAKBh0NldRLYkKhSG06Lc63+tsvnHf0XF0ZRwJ1o rGikn0I1wp6Hxbw+Zq16uZKDRjlrdZN9jksSnCtiCE2g04vxq+FlgRXPSW1Qr4CWArb/ 6DsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3lUasf8H3y2HCvhJRDvzITE9jm/etzHFKTEYTIq4KLY=; b=N4YlfedThzJaduLPfmbm5hPv0KyqO1rKIJkJoSOCa2cHaAxLMYMxsRMWr0xv4elVEy 8kGSc/ATnuR8eVM0/g13C3mcfsotldpyqWq6MWIUIMIJIxHvtsYCFuiTWxM2gieC0qXG A0nAqmf0S9Rbwub0CTCVy8m33iUbcWkeLQQxpCrlu1J6IJ4ue2VhvjlkAeDtZOQMFDY1 lAVgdYlt5bZDjOeIs1q1miLh3b2Ibdqwt08vAyyxqGMQzoFRiRm41zc4KjOWqtahQKZe Q6XbjvgSzsNdBsiqP7tMiVG7HdyI2+/2WVrF/U9Vn5qzAlPOet1QDEPnwEVqPWpDrx+a lLsg== X-Gm-Message-State: AOAM532KjifGeKaC8FK36bz1sh2IBjjWwQDerNxC49s/ZuMLMnNCmiQP D4w9YUFiE45TqD4HGwOkXXjw06m9mS0d10FTn5q0x+D3 X-Google-Smtp-Source: ABdhPJxSt/qRiDoN7Y3bTebLYkNHO2OhWrnpDEtJyvkKNtu49oCW+hv+1CNW7U8UTOEU5NF3MNzix9iZqDw4nVUNH0c= X-Received: by 2002:a67:eb98:: with SMTP id e24mr47519vso.72.1591733709599; Tue, 09 Jun 2020 13:15:09 -0700 (PDT) MIME-Version: 1.0 References: <1584007257-14466-1-git-send-email-nelson.chu@sifive.com> <87r1upefg8.fsf@tromey.com> <20200609173040.GE2737@embecosm.com> In-Reply-To: <20200609173040.GE2737@embecosm.com> From: Jim Wilson Date: Tue, 9 Jun 2020 13:14:58 -0700 Message-ID: Subject: Re: [RFC] gdb/riscv: Improved register alias name creation To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 20:15:12 -0000 On Tue, Jun 9, 2020 at 10:30 AM Andrew Burgess wrote: > Looking then at the final PRIV_SPEC_CLASS_* field for each alias then > we can see that currently we only want to take the alias from > PRIV_SPEC_CLASS_1P11. For now then this is what I'm using to filter > the aliases within GDB. This will do the right thing, but looks a little funny. It isn't quite the right way to express what we want. I do think it is OK for now, but we will have to be careful when maintaining binutils that we don't break this assumption, or remember to update it when necessary. Otherwise this look OK to me. Jim