From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54881 invoked by alias); 8 Aug 2018 18:19:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54790 invoked by uid 89); 8 Aug 2018 18:19:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Aug 2018 18:19:19 +0000 Received: by mail-wm0-f65.google.com with SMTP id c14-v6so3695609wmb.4 for ; Wed, 08 Aug 2018 11:19:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/Ug3OTczVXpvvfSYW717iHnWGUFpA18r32VyuhkLQ0Y=; b=GUG0ctXXuErNUAGky8l1D0NMEkT9xCF+CZPZVHWwp0Ft9kFQB00ptLlSQqWbSElJf8 lVlEcGmhSo6l6hSaaff1M5k+yVW8B33DtQHHDh7uKF3+r1/TOZx0+oWH0OH5nWawFd7F lkCOCJE3Hn7ng3A7r61cvwg1swVDUaTYGUxQXyj8wgfj0ulZ04uD6Jc/SQU2FO1r/9uz 5ls2GX8uei1jxQm+dDMdFDs49MnlHUuzkdQyhkgORrbsZAMPWuNVPMa1yvLz17NUXu2V uMHI7fkd8AwLhWljQXrCXPpZdnT/SSUD8aZqRro/ln/pASFqu2ypHs+rmiIH8NXCyWE5 YlRg== MIME-Version: 1.0 Received: by 2002:adf:e44b:0:0:0:0:0 with HTTP; Wed, 8 Aug 2018 11:19:16 -0700 (PDT) In-Reply-To: <20180808144153.GN3155@embecosm.com> References: <20180808021638.7716-1-jimw@sifive.com> <20180808144153.GN3155@embecosm.com> From: Jim Wilson Date: Wed, 08 Aug 2018 18:19:00 -0000 Message-ID: Subject: Re: [PATCH 3/5] RISC-V: Add linux target support. To: Andrew Burgess Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-08/txt/msg00177.txt.bz2 On Wed, Aug 8, 2018 at 7:41 AM, Andrew Burgess wrote: >> +const struct regset riscv_linux_gregset = >> +{ >> + riscv_linux_gregmap, regcache_supply_regset, regcache_collect_regset >> +}; > > Could this not be static? > > Also, I think 'riscv_linux_gregmap' and 'riscv_linux_gregset' should > both have comments against them, I'm pretty sure the expectation these > days is that every definition has a comment.... I added the static and the comments. Jim