From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pi0YODzjgGBuSwAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 22:45:16 -0400 Received: by simark.ca (Postfix, from userid 112) id D71B01F104; Wed, 21 Apr 2021 22:45:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F89E1E54D for ; Wed, 21 Apr 2021 22:45:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6694A386EC2F; Thu, 22 Apr 2021 02:45:15 +0000 (GMT) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 7A386386EC2F for ; Thu, 22 Apr 2021 02:45:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7A386386EC2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ed1-x52d.google.com with SMTP id g17so50951322edm.6 for ; Wed, 21 Apr 2021 19:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LdYdVr0y/QrPCpI86jdlj/mntWKhEeoIv5SZ3+pM6w8=; b=alUrXzSD497H/ZX86K/UUKL2fCi7to8hzuc/oYCy7hjayopgqqUphBtGMbGLwfNkb8 5dq034dEOlCpfm+LnD1wk//bQU5ZFxOBee5HM+fgvRo1HOgRFlfJWDijUM+N0qQD+6Ma YvD58r3stMc6xkB7zWt9dqn7APnZPvJ7SLxKR8M4yt196utIW7zmVzcUHLlbFcYS/wjF ZfF04FZdjJU9/uIy1ByaviCKlj/qFhJMYguDvYuBYyxZXSTfZaX2fi+Z849ukOq2q25t FUntbfuTxAtNRuhWF/1RpdqQnUxeBT6cSIf34gukhgqTGS6YubHwkt8ZxPmjiLTKWT5N njrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LdYdVr0y/QrPCpI86jdlj/mntWKhEeoIv5SZ3+pM6w8=; b=rURvOUvIhK1/wPPf99p8P5UjO70M3wb74sskwwIn3c4k5njR/N+GZVzZjiKVZpplck DAzndOQu31PjU6Tjf8USWH8zYPGPlqDKIbMsK/HYPyWEr9VSLQG2KdHAcE/yaICyIklQ S16YSSPZcXkZSBQfmDV6of+Ux2YCkzrh6Rn5xQFslqRWh/8/XSw9wg3ajUgj0ZeBSrxj MwcIyGhLD30+cAJlaQsnxC5HBDutijuETSj5zMP61sygQyS/Ybv8BPrxk6/0LhQlFkLr 4ab5sAu/F/cm1KNPnn1aj6xos1AfCSstCNFpj4FcvB/RZaSN8QQDhcnJBei6haCYMOEu 2SKg== X-Gm-Message-State: AOAM531vOilzgY2tVekNalC4/xRXjs5ezd+fDTDw2MvdnilOdEWmWQCP 3wFp2N5kqqOB0ZQ0O/DsAuLS6y52se0YSHH57eKycg== X-Google-Smtp-Source: ABdhPJyYBxo5WhqTbuXOzHrvxME0DoGPzy1qphhOJtyTpT/FC/cuNijzFiUHkaGHBnpzNrJREO1H8CuVoHptnZd8x5E= X-Received: by 2002:a05:6402:b31:: with SMTP id bo17mr1070934edb.46.1619059512647; Wed, 21 Apr 2021 19:45:12 -0700 (PDT) MIME-Version: 1.0 References: <20210417175831.16413-1-jimw@sifive.com> <20210417175831.16413-21-jimw@sifive.com> In-Reply-To: From: Jim Wilson Date: Wed, 21 Apr 2021 19:45:01 -0700 Message-ID: Subject: Re: [PATCH 20/24] RISC-V sim: Set brk to _end if possible. To: Jim Wilson , gdb-patches@sourceware.org, Kito Cheng Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sun, Apr 18, 2021 at 10:41 PM Mike Frysinger wrote: > On 17 Apr 2021 10:58, Jim Wilson wrote: > > +static bfd_vma > > +riscv_get_symbol (SIM_DESC sd, const char *sym) > ... > > this is trace_sym_value. am i missing something ? > I think the patch author didn't realize trace_sym_value was there. I will fix to use it instead. > + /* Try to find _end symbol, and set it to the end of brk. */ > > + trace_load_symbols (sd); > > missing error checking > With the change to use trace_sym_value this line gets deleted. Jim