From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103170 invoked by alias); 20 Sep 2018 20:57:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103039 invoked by uid 89); 20 Sep 2018 20:57:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=D*freebsd.org X-HELO: mail-ot1-f67.google.com Received: from mail-ot1-f67.google.com (HELO mail-ot1-f67.google.com) (209.85.210.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Sep 2018 20:56:59 +0000 Received: by mail-ot1-f67.google.com with SMTP id e18-v6so10857563oti.8 for ; Thu, 20 Sep 2018 13:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NBL5aEz1CwyKAJHiOHWQfpWTB8QMahGJupx5aFDDYZM=; b=Ti7s/+1fvfsPOr6Z7hrrfmd0hVbCvzez8gNP3yRjT4W/0e/9SUZz88vycqjEXjbYxO caEus2tfU+tNLrv12/PbGUMu/5ek6EFw0arEQa5uTmNrYiDEhjA6sNToLis35zkUK8Qv vR1XIgkSYvTJfIjFS1SFe7hulbtNI77CMJ5jYA50bVTicCHja1Enh9PPUwE2Ulhkii2T GoKhA4opQ4dLP2ddYzC5o3iQOPIi3jbQ7dD/bKs1rqQB8PaBLTC86YpiMKLqF1eJzb83 p24QLHb35ShF86ffY6ykNU3aEDocDR4aCg16Qpq7QkR1XS4b5rf78zuQxarSQjW5P166 L7mA== MIME-Version: 1.0 References: <20180919231950.22634-1-jhb@FreeBSD.org> <20180919231950.22634-3-jhb@FreeBSD.org> <0081bdf8-04cb-f6b7-d80a-d9a878d0a3ab@FreeBSD.org> In-Reply-To: From: Jim Wilson Date: Thu, 20 Sep 2018 20:57:00 -0000 Message-ID: Subject: Re: [PATCH 2/4] Fall back to a default value of 0 for the MISA register. To: John Baldwin Cc: gdb-patches@sourceware.org, Andrew Burgess , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-09/txt/msg00740.txt.bz2 On Thu, Sep 20, 2018 at 1:31 PM John Baldwin wrote: > Use the existing instruction to determine the RISC-V breakpoint kind. Yes, this looks like a nice solution to the problem. In riscv_breakpoint_kind_from_pc, you are setting a byte_order local variable but not obviously using it. You presumably don't need byte order here as you are only reading one byte. Jim