From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xzh6FYNJJGB6EwAAWB0awg (envelope-from ) for ; Wed, 10 Feb 2021 16:00:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 285EA1EF4F; Wed, 10 Feb 2021 16:00:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C30441E54D for ; Wed, 10 Feb 2021 16:00:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78D013848000; Wed, 10 Feb 2021 21:00:50 +0000 (GMT) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 8F5A53848000 for ; Wed, 10 Feb 2021 21:00:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F5A53848000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ej1-x62b.google.com with SMTP id i8so6608966ejc.7 for ; Wed, 10 Feb 2021 13:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aoR0I81kQeqeMVGJaRmTk/l+4BjTrmbVUTm3N3s5AKY=; b=l4jOcQ3Exvh7PnG28StBAS43i4NKFucf8Q03zJE0+wyHWIrgoIlXRFypTJfPN5FF8a 7p3Vj8GxQ0qOX8baOknRyvbjIfmy6DZj2jPrK4oF/tehxQHcfDHQk97TuIodCILMWio2 cMfP9N0+sweb2a7QHMwsxsinmKPZVlDvP/sMqla03mJvlMhzEftu80awGPyLQR39rYYV NG0VmCJvHna3CjGU18FApffrNriA77bAgraiouzqxraZJrx75jN22C21Io6riZArtydZ /3Wyho7lNLUJajVcVVlIbwQuxmEvW/p8JcyTu5Sr9wc234hIlJcbaWkh2C9QhcEb2mcc PJDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aoR0I81kQeqeMVGJaRmTk/l+4BjTrmbVUTm3N3s5AKY=; b=DehGSEbABO/V/J5ggpoEwwYCKOvtozdFMM/MELy3NsLZGZuo/bDvUiF2ERiPsrsDxy re6kgpm/6XJk7PdOdoTNIcfUShns51Dmt1N9U797BjzOi715GmEQRGurnlKQ1B9wvZaM wu0la2hsaG5GVuQmpHx0IY2lmtyA2emwHkh1k4iG0RDOO9Mr3z31IC1UZwYxbN7A+cyy qJg0GvEdyB7C9WexQu4DVnvHMhZdFWWYxE6PMUOt+4jf9lcKeTk473t5r1ly49ttHOjG YBbACmZ1DuwiynnCliEPIqE1UidtiQ3Onxy8theO+e5jyaLfoUEMYb3Fack8bBiQHApc Clzw== X-Gm-Message-State: AOAM533ch73OOWw7fEHKs03OO5Wn4oEFG3NG6XW4Ahp2RRSYj6LlBOVe k3IXp+CB6DpMH5A+/R5ve/i/Vyr7H5cQHEMb7QOCZw== X-Google-Smtp-Source: ABdhPJyNID58DQ1W3MYy1W1ksEtxvjeYqJDf+f2wvfoR78PRWEKzzkf2FiiaS+Xme2IzRrgnp7QqBaGPCse/Jqh+vwM= X-Received: by 2002:a17:906:26ca:: with SMTP id u10mr4871416ejc.165.1612990845209; Wed, 10 Feb 2021 13:00:45 -0800 (PST) MIME-Version: 1.0 References: <20210201120036.GT265215@embecosm.com> In-Reply-To: <20210201120036.GT265215@embecosm.com> From: Jim Wilson Date: Wed, 10 Feb 2021 13:00:34 -0800 Message-ID: Subject: Re: [PATCHv2 6/9] bfd/binutils: add support for RISC-V CSRs in core files To: Andrew Burgess Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Hederstierna , Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Mon, Feb 1, 2021 at 4:00 AM Andrew Burgess wrote: > bfd/ChangeLog: > > * elf-bfd.h (elfcore_write_riscv_csr): Declare. > * elf.c (elfcore_grok_riscv_csr): New function. > (elfcore_grok_note): Handle NT_RISCV_CSR. > (elfcore_write_riscv_csr): New function. > (elfcore_write_register_note): Handle '.reg-riscv-csr'. > > binutils/ChangeLog: > > * readelf.c (get_note_type): Handle NT_RISCV_CSR. > > include/ChangeLog: > > * elf/common.h (NT_RISCV_CSR): Define. > > Looks OK to me. As before, ideally new functions should have explanatory comments before them, unless maybe that rule has changed. Jim