From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sNRmEP5FJGAfEwAAWB0awg (envelope-from ) for ; Wed, 10 Feb 2021 15:45:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 349CD1EF4F; Wed, 10 Feb 2021 15:45:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C20111E54D for ; Wed, 10 Feb 2021 15:45:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B345A3854812; Wed, 10 Feb 2021 20:45:48 +0000 (GMT) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 319193857C4E for ; Wed, 10 Feb 2021 20:45:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 319193857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jimw@sifive.com Received: by mail-ed1-x531.google.com with SMTP id s11so4629874edd.5 for ; Wed, 10 Feb 2021 12:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dChWVkLqxAjgO7BgjepTXAAe58B3awSiP2hmlgmkyGA=; b=BpHzORFhHa0w9rC2F2qiXBQRKH+TGMZ1C6BHpMHCx1eZbfCnSoB6RaYPnGgRBoSQ9U MfQdIos69Mi6j00S1l4+Mtx4qr108F2+gL4S6Ufp6rQ5ll/jW1VzBjwFiSvmRhXsJERJ GZw4ra8YvX5WLlRi3YoSVlugKb3Qp2xon8vdfLnFaLZ9dNERkkmBZP+Jeuv/E8gkC3pb dcWkAw3/SOuhX/nF9uPagT3hdSX/dAaXBQLxi9abcsULT1ajHLv3/hQqzVguiXn7oGQz KzNRpoZ+jgwXdRRlaBmo8UTBppFAdwbTHgxFrX/IaxuAS3vblm+UUhAUgGs44XXInezf jalg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dChWVkLqxAjgO7BgjepTXAAe58B3awSiP2hmlgmkyGA=; b=ajMJEn0kp3gxoOTE9ZA3Vlfg9NVuKwofCJSlC//osxNFbG+I38iNcKLWUx+bpv3g0q OKvjPWOaVvkOxDdJwwqJoUKKtUdfCKmZ17Fp8SAHeQGTmX9B73oMfLhfmCc48WdkXmZN 3fYoBiqT6gRtGkSlAbqUq4nhcs8xr+MYpTjb8Hq2jy8XerLwEvLKPJnT16rden3WJaPn THZ9XEa/747c81f9BKj9GMTUFMG307lDe2Qg5qsYWENr40AKj0tIlCfG/vZa/execRAz DBZm5IBkwLt/rWKgm3XXUGAWpEBKwsqIuSgf/CP9agnpxUT+RH1O1N+Fk7Oeu3RIZp67 iN/Q== X-Gm-Message-State: AOAM533q47Sa0iRKC4NbG2qWNZdePfeEl/pjqw5Vn9P+MPnLHZSknSoT i5FCzi6gCC3gnjmuuqfLByMztg6jOK8kX47NzEIMWbuqqus= X-Google-Smtp-Source: ABdhPJxMsLWnszaHUc23HywJdRVhxiCK/jezFs0cdeuYzGn/dizvvlmJgixdUTxroV/mMDogrHzB7+2ash3qIhamdHk= X-Received: by 2002:a05:6402:26c7:: with SMTP id x7mr5087233edd.24.1612989944834; Wed, 10 Feb 2021 12:45:44 -0800 (PST) MIME-Version: 1.0 References: <5a9bb029efd1737d81d1e9ff0e82f359d4267113.1611172468.git.andrew.burgess@embecosm.com> In-Reply-To: <5a9bb029efd1737d81d1e9ff0e82f359d4267113.1611172468.git.andrew.burgess@embecosm.com> From: Jim Wilson Date: Wed, 10 Feb 2021 12:45:33 -0800 Message-ID: Subject: Re: [PATCHv2 2/9] bfd/binutils: support for gdb target descriptions in the core file To: Andrew Burgess Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Hederstierna , Binutils , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Wed, Jan 20, 2021 at 12:23 PM Andrew Burgess wrote: > bfd/ChangeLog: > > * elf-bfd.h (elfcore_write_gdb_tdesc): Declare new function. > * elf.c (elfcore_grok_gdb_tdesc): New function. > (elfcore_grok_note): Handle NT_GDB_TDESC. > (elfcore_write_gdb_tdesc): New function. > (elfcore_write_register_note): Handle NT_GDB_TDESC. > > binutils/ChangeLog: > > * readelf.c (get_note_type): Handle NT_GDB_TDESC. > > include/ChangeLog: > > * elf/common.h (NT_GDB_TDESC): Define. > This looks OK. Technically, new functions are supposed to have explanatory comments before them, but there are others missing comments. If you could add the missing comments to the new functions in your patch that would be nice. Jim