From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8740 invoked by alias); 19 Dec 2013 10:26:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8730 invoked by uid 89); 19 Dec 2013 10:26:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f182.google.com Received: from mail-vc0-f182.google.com (HELO mail-vc0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 19 Dec 2013 10:26:09 +0000 Received: by mail-vc0-f182.google.com with SMTP id lc6so511365vcb.41 for ; Thu, 19 Dec 2013 02:26:07 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.58.208.130 with SMTP id me2mr295377vec.13.1387448767546; Thu, 19 Dec 2013 02:26:07 -0800 (PST) Received: by 10.52.171.202 with HTTP; Thu, 19 Dec 2013 02:26:07 -0800 (PST) In-Reply-To: <1687CC80-34C1-4D76-836B-418050049B16@gmail.com> References: <52B1C84F.4000102@arm.com> <430CEAB7-7F7B-430D-9C37-75F87D1F65AC@gmail.com> <1687CC80-34C1-4D76-836B-418050049B16@gmail.com> Date: Thu, 19 Dec 2013 10:26:00 -0000 Message-ID: Subject: Re: [PATCH, AArch64] Fix bug in hardware watchpoint/breakpoint handling From: Marcus Shawcroft To: pinskia@gmail.com Cc: Yufeng Zhang , "gdb-patches@sourceware.org" , Marcus Shawcroft Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00742.txt.bz2 On 19 December 2013 10:23, wrote: > Oh, I see I think this should have been written using offsetof [0] and then count*sizeof to make easier to understand and fits in with most other code which uses a variable size last element. Umm, yes, I agree, that would be better. /Marcus