From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4012 invoked by alias); 18 Jun 2014 12:27:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3836 invoked by uid 89); 18 Jun 2014 12:27:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f177.google.com Received: from mail-vc0-f177.google.com (HELO mail-vc0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 18 Jun 2014 12:27:41 +0000 Received: by mail-vc0-f177.google.com with SMTP id ij19so686585vcb.36 for ; Wed, 18 Jun 2014 05:27:39 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.220.202.69 with SMTP id fd5mr131344vcb.43.1403094459605; Wed, 18 Jun 2014 05:27:39 -0700 (PDT) Received: by 10.52.106.107 with HTTP; Wed, 18 Jun 2014 05:27:39 -0700 (PDT) In-Reply-To: <20140616132557.GA4317@arm.com> References: <1390243792-31176-1-git-send-email-tromey@redhat.com> <87oaxxrhj4.fsf@fleche.redhat.com> <20140616132557.GA4317@arm.com> Date: Wed, 18 Jun 2014 12:27:00 -0000 Message-ID: Subject: Re: [RFC 0/2] let gdbserver use libiberty From: Marcus Shawcroft To: James Greenhalgh Cc: Tom Tromey , "gdb-patches@sourceware.org" Content-Type: multipart/mixed; boundary=001a11c1be70da089b04fc1b626a X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00653.txt.bz2 --001a11c1be70da089b04fc1b626a Content-Type: text/plain; charset=UTF-8 Content-length: 1170 On 16 June 2014 14:25, James Greenhalgh wrote: > On Thu, Jun 12, 2014 at 09:37:19PM +0100, Tom Tromey wrote: >> This series slipped through the cracks somehow. I'm going to push it >> now. I believe I addressed all the review comments upthread. I rebased >> it and rebuilt it on x86-64 Fedora 20; let me know if you encounter any >> problems. > > Hi Tom, > > This seems to cause issues when building gdbserver as part of a larger > Canadian Cross ARM/AArch64 build. ar ends up confused having seemingly lost > the expected flags: The issue here appears to be that libiberty configure script probes for and finds an appropriate AR for the --build/--target combination. However, the gdbserver configure does not probe for AR but does override the AR used in the libiberty build by explicitly passing AR to the sub-builds. This has the effect of passing the systems 'ar' rather than an ar appropriate for the --build/--target combination. An alternative approach to that suggested by James is to have the gdbserver configure scri[t probe for AR to ensure that something sane is passed on to the sub-builds. Patch attached. OK ? /Marcus --001a11c1be70da089b04fc1b626a Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fix-gdbserver-canadian-cross-build.patch" Content-Disposition: attachment; filename="0001-Fix-gdbserver-canadian-cross-build.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hwkm3ys40 Content-length: 1948 RnJvbSA5NmMxNGMyN2ZjN2ZmODZlMDI4ZDFmMWExNTYzOTExNTRkOGU3YzA0 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjdXMgU2hhd2Ny b2Z0IDxtYXJjdXMuc2hhd2Nyb2Z0QGFybS5jb20+CkRhdGU6IFdlZCwgMTgg SnVuIDIwMTQgMTE6NTM6MzMgKzAxMDAKU3ViamVjdDogW1BBVENIIDEvMl0g Rml4IGdkYnNlcnZlciBjYW5hZGlhbiBjcm9zcyBidWlsZC4KCi0tLQogZ2Ri L2dkYnNlcnZlci9DaGFuZ2VMb2cgICAgfCAgICA1ICsrKysrCiBnZGIvZ2Ri c2VydmVyL01ha2VmaWxlLmluICB8ICAgIDIgKysKIGdkYi9nZGJzZXJ2ZXIv Y29uZmlndXJlLmFjIHwgICAgMSArCiAzIGZpbGVzIGNoYW5nZWQsIDggaW5z ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dkYi9nZGJzZXJ2ZXIvQ2hhbmdl TG9nIGIvZ2RiL2dkYnNlcnZlci9DaGFuZ2VMb2cKaW5kZXggMzE4NjMzNi4u ODc4OGJlMSAxMDA2NDQKLS0tIGEvZ2RiL2dkYnNlcnZlci9DaGFuZ2VMb2cK KysrIGIvZ2RiL2dkYnNlcnZlci9DaGFuZ2VMb2cKQEAgLTEsMyArMSw4IEBA CisyMDE0LTA2LTE4ICBNYXJjdXMgU2hhd2Nyb2Z0ICA8bWFyY3VzLnNoYXdj cm9mdEBhcm0uY29tPgorCisJKiBjb25maWd1cmUuYWM6IEludm9rZS4gQUNf Q0hFQ0tfVE9PTChBUiwgYXIpLgorCSogTWFrZWZpbGUuaW4gKEFSLCBBUl9G TEFHUyk6IERlZmluZS4KKwogMjAxNC0wNi0xOCAgR2FyeSBCZW5zb24gIDxn YmVuc29uQHJlZGhhdC5jb20+CiAKIAkqIGkzODYtbG93LmggKGkzODZfbG93 X2luc2VydF93YXRjaHBvaW50KTogUmVuYW1lZCB0bwpkaWZmIC0tZ2l0IGEv Z2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbiBiL2dkYi9nZGJzZXJ2ZXIvTWFr ZWZpbGUuaW4KaW5kZXggY2JmMzZhYi4uYzY1MDQ3NyAxMDA2NDQKLS0tIGEv Z2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbgorKysgYi9nZGIvZ2Ric2VydmVy L01ha2VmaWxlLmluCkBAIC01MCw2ICs1MCw4IEBAIElOU1RBTExfREFUQSA9 IEBJTlNUQUxMX0RBVEFACiBSQU5MSUIgPSBAUkFOTElCQAogCiBDQyA9IEBD Q0AKK0FSID0gQEFSQAorQVJfRkxBR1MgPSByYwogCiAjIERlcGVuZGVuY3kg dHJhY2tpbmcgaW5mb3JtYXRpb24uCiBERVBNT0RFID0gQENDREVQTU9ERUAK ZGlmZiAtLWdpdCBhL2dkYi9nZGJzZXJ2ZXIvY29uZmlndXJlLmFjIGIvZ2Ri L2dkYnNlcnZlci9jb25maWd1cmUuYWMKaW5kZXggZWRlMzhkMC4uN2ZhODlk NiAxMDA2NDQKLS0tIGEvZ2RiL2dkYnNlcnZlci9jb25maWd1cmUuYWMKKysr IGIvZ2RiL2dkYnNlcnZlci9jb25maWd1cmUuYWMKQEAgLTMyLDYgKzMyLDcg QEAgQUNfU1lTX0xBUkdFRklMRQogQUNfQ0FOT05JQ0FMX1NZU1RFTQogCiBB Q19QUk9HX0lOU1RBTEwKK0FDX0NIRUNLX1RPT0woQVIsIGFyKQogQUNfUFJP R19SQU5MSUIKIAogQUNfQVJHX1BST0dSQU0KLS0gCjEuNy45LjUKCg== --001a11c1be70da089b04fc1b626a--