From: Marcus Shawcroft <marcus.shawcroft@gmail.com>
To: Kyle McMartin <kmcmarti@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCHv2] aarch64: detect atomic sequences like other ll/sc architectures
Date: Thu, 27 Mar 2014 16:13:00 -0000 [thread overview]
Message-ID: <CAFqB+PyPpHUr+7TSzaKwfPShcDHGi9Zmer0RBiNXJpuQ3eQFug@mail.gmail.com> (raw)
In-Reply-To: <20140327154033.GI3075@redacted.bos.redhat.com>
On 27 March 2014 15:40, Kyle McMartin <kmcmarti@redhat.com> wrote:
> On Thu, Mar 27, 2014 at 02:07:35PM +0000, Marcus Shawcroft wrote:
>> Are you sure these masks and patterns are accurate? Looks to me that
>> this excludes many of the load exclusive instructions and includes
>> part of the unallocated encoding space. There are several different
>> encodings to match here covering ld[a]xr{b,h,} and ld[a]xp. The masks
>> and patterns will be something like:
>>
>> 0xbfff7c00 0x085f7c00
>> 0xbfff7c00 0x885f7c00
>> 0xbfff0000 0x887f0000
>>
>> > + if (decode_masked_match (insn, 0x3fc00000, 0x08000000))
>>
>> This also looks wrong.
>>
>
> Eh... I tested all 24 possible ldxr/stxr opcodes...
Kyle
You are right, sorry, I can't read the encoding tables. This mask and
pattern is indeed sensible.
Cheers
/Marcus
next prev parent reply other threads:[~2014-03-27 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 1:51 Kyle McMartin
2014-03-27 13:07 ` Joel Brobecker
2014-03-27 15:45 ` Kyle McMartin
2014-03-27 14:07 ` Marcus Shawcroft
2014-03-27 15:40 ` Kyle McMartin
2014-03-27 16:13 ` Marcus Shawcroft [this message]
2014-03-27 16:37 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFqB+PyPpHUr+7TSzaKwfPShcDHGi9Zmer0RBiNXJpuQ3eQFug@mail.gmail.com \
--to=marcus.shawcroft@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=kmcmarti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox