Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64

Tom Tromey
2013-11-27T17:21:51Z

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> Now, about the tests... I have been using ARM Foundation's simulator
Sergio> on x86_64 (Fedora 18). This is an incredibly slow simulator, to the
Sergio> point that I gave up compiling GDB directly on it. Instead, I am
Sergio> cross-compiling it on my machine and testing only the binary there.
Sergio> Therefore, I also gave up running the testsuite, and only ran
Sergio> stap-related tests. As far as I'm concerned, everything succeeded and
Sergio> I didn't break anything. The code is pretty much self contained that
Sergio> it doesn't affect other areas of GDB, but of course this patch could
Sergio> use more testing, and I won't complain if you have the means and the
Sergio> will to do this!

FWIW in this specific case I think this testing approach is ok.
The patch pretty clearly just touches the stap probe code.
Could you say, though, exactly which tests you ran?

Tom