Re: [PATCH] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64

Marcus Shawcroft
2013-11-26T09:46:22Z

Hi

On 25 November 2013 21:11, Sergio Durigan Junior <sergiodj@redhat.com> wrote:

> I am not sure I completely understood your comment. Are you criticizing
> the shared asm parser for ARM targets only, or the generic asm parser in
> stap-probe.c? I assume it is the former. And I also fail to see why it
> can be considered coincidental cohesion... The shared parser covers one
> specific ARM assembly syntax, which is pretty similar to both 32- and
> 64-bit ARM.

> Correct me if I'm wrong, but you're actually against the way I've chosen
> to share the code between the targets, right? Or am I missing something
> here. If that's the case, I can try to come up with a simpler/cleaner
> way to share this code... Suggestions are appreciated, of course :-).

Sorry, I was not clear. I think the a64 and a32 parsers should be kept
separate rather than using a common parser for a different, but
similar syntax, thus avoiding the need to pass the flag that
distinguishes the different syntaxes.

Cheers
/Marcus