From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9949 invoked by alias); 2 Oct 2015 12:35:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9928 invoked by uid 89); 2 Oct 2015 12:35:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-lb0-f173.google.com Received: from mail-lb0-f173.google.com (HELO mail-lb0-f173.google.com) (209.85.217.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 02 Oct 2015 12:35:15 +0000 Received: by lbos8 with SMTP id s8so25599237lbo.0; Fri, 02 Oct 2015 05:35:12 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.198.97 with SMTP id jb1mr5336230lbc.8.1443789311959; Fri, 02 Oct 2015 05:35:11 -0700 (PDT) Received: by 10.25.165.142 with HTTP; Fri, 2 Oct 2015 05:35:11 -0700 (PDT) In-Reply-To: <1443785039-24602-3-git-send-email-yao.qi@linaro.org> References: <1443785039-24602-1-git-send-email-yao.qi@linaro.org> <1443785039-24602-3-git-send-email-yao.qi@linaro.org> Date: Fri, 02 Oct 2015 12:35:00 -0000 Message-ID: Subject: Re: [PATCH 2/3] [aarch64] expose disas_aarch64_insn and rename it to aarch64_decode_insn From: Marcus Shawcroft To: Yao Qi Cc: "gdb-patches@sourceware.org" , "binutils@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00020.txt.bz2 On 2 October 2015 at 12:23, Yao Qi wrote: > include/opcode: > > 2015-10-02 Yao Qi > > * aarch64.h (aarch64_decode_insn): Declare it. > > opcodes: > > 2015-10-02 Yao Qi > > * aarch64-dis.c (disas_aarch64_insn): Remove static. Change > argument insn type to aarch64_insn. Rename to ... > (aarch64_decode_insn): ... it. > (print_insn_aarch64_word): Caller updated. > --- > include/opcode/aarch64.h | 3 +++ > opcodes/aarch64-dis.c | 9 +++++---- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h > index dcf0fef..d0c7489 100644 > --- a/include/opcode/aarch64.h > +++ b/include/opcode/aarch64.h > @@ -925,6 +925,9 @@ aarch64_stack_pointer_p (const aarch64_opnd_info *); > extern > int aarch64_zero_register_p (const aarch64_opnd_info *); > > +extern > +int aarch64_decode_insn (aarch64_insn, aarch64_inst *); The usual layout would be: extern int aarch64_decode_insn (.... OK with that change. /Marcus