Re: [PATCH 00/14] Split generic_val_print in smaller parts

Pedro Alves
2015-07-23T21:54:20Z

On 07/15/2015 05:47 PM, Simon Marchi wrote:

> Simon Marchi (14):
> Factor out print_unpacked_pointer from generic_val_print
> Factor out array printing code from generic_val_print
> Factor out pointer printing code from generic_val_print
> Factor out memberptr printing code from generic_val_print
> Factor out reference printing code from generic_val_print
> Factor out enum printing code from generic_val_print
> Factor out flags printing code from generic_val_print
> Factor out function/method printing code from generic_val_print
> Factor out bool printing code from generic_val_print
> Factor out int printing code from generic_val_print
> Factor out char printing code from generic_val_print
> Factor out float printing code from generic_val_print
> Factor out decfloat printing code from generic_val_print
> Factor out complex printing code from generic_val_print

I read the whole series. Patches that I didn't comment
on looked OK to me as is. The one's I commented on,
just fix them and push right ahead.

Nice cleanup! Keep 'em coming. :-)

Thanks,
Pedro Alves