From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54793 invoked by alias); 24 Jul 2015 02:29:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54778 invoked by uid 89); 24 Jul 2015 02:29:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f48.google.com Received: from mail-oi0-f48.google.com (HELO mail-oi0-f48.google.com) (209.85.218.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 24 Jul 2015 02:29:43 +0000 Received: by oigd21 with SMTP id d21so9511367oig.1 for ; Thu, 23 Jul 2015 19:29:41 -0700 (PDT) X-Received: by 10.182.142.74 with SMTP id ru10mr13103413obb.75.1437704981526; Thu, 23 Jul 2015 19:29:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.224.66 with HTTP; Thu, 23 Jul 2015 19:29:12 -0700 (PDT) In-Reply-To: <55B16081.5010400@redhat.com> References: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com> <1436978863-15125-2-git-send-email-simon.marchi@ericsson.com> <55B16081.5010400@redhat.com> From: Simon Marchi Date: Fri, 24 Jul 2015 02:29:00 -0000 Message-ID: Subject: Re: [PATCH 01/14] Factor out print_unpacked_pointer from generic_val_print To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg00677.txt.bz2 On 23 July 2015 at 17:45, Pedro Alves wrote: > Line too long. Comment seems stale -- there's no UNRESOLVED_ELTTYPE > parameter. > > Otherwise looks good. Thanks, fixed.