From: Simon Marchi <simon.marchi@polymtl.ca>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Remove references to HP CC/aCC compiler from testsuite
Date: Sun, 20 Dec 2015 15:40:00 -0000 [thread overview]
Message-ID: <CAFXXi0nLoxu8iT84GZ-KYzAL-RaUkGCZvYnJJ8t2SNZntV2Qtg@mail.gmail.com> (raw)
In-Reply-To: <20151220051518.GC4639@adacore.com>
On 20 December 2015 at 00:15, Joel Brobecker <brobecker@adacore.com> wrote:
>> From 8d7c3cff8ced75bedbe050d3fefde10e3349de70 Mon Sep 17 00:00:00 2001
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Date: Sat, 19 Dec 2015 11:36:49 -0500
>> Subject: [PATCH] Remove references to HP CC/aCC compiler from testsuite
>>
>> The HP CC/aCC compiler is exclusive to HP-UX, for which support has been
>> explicitely removed. Therefore, It does not make sense to keep tests
>
> "explicitly"
Fixed.
>> for these compilers' quirks.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.base/break.exp: Remove references to HP CC/aCC compilers.
>> * gdb.base/call-ar-st.exp: Likewise.
>> * gdb.base/callfuncs.exp: Likewise.
>> * gdb.base/condbreak.exp: Likewise.
>> * gdb.base/constvars.exp: Likewise.
>> * gdb.base/hbreak2.exp: Likewise.
>> * gdb.base/langs.exp: Likewise.
>> * gdb.base/list.exp: Likewise.
>> * gdb.base/long_long.exp: Likewise.
>> * gdb.base/ptype.exp: Likewise.
>> * gdb.base/scope.exp: Likewise.
>> * gdb.base/signals.exp: Likewise.
>> * gdb.base/so-impl-ld.exp: Likewise.
>> * gdb.base/varargs.exp: Likewise.
>> * gdb.base/volatile.exp: Likewise.
>> * gdb.base/whatis.exp: Likewise.
>> * gdb.cp/cplusfuncs.exp: Likewise.
>> * gdb.cp/inherit.exp: Likewise.
>> * gdb.cp/local.exp: Likewise.
>> * gdb.cp/member-ptr.exp: Likewise.
>> * gdb.cp/method.exp: Likewise.
>> * gdb.cp/overload.exp: Likewise.
>> * gdb.cp/templates.exp: Likewise.
>> * gdb.stabs/weird.exp: Likewise.
>> * lib/compiler.c: Likewise.
>> * lib/compiler.cc: Likewise.
>> * lib/cp-support.exp: Likewise.
>> * lib/gdb.exp: Likewise.
>
> OK for me.
>
> Note that there was one area where an expected output alternative
> was removed which mentioned hp aCC, but also GCC 2.95. I assumed
> it's OK to only support more recent versions than 2.95 ;-).
Indeed, I didn't feel too bad removing it.
I'll push this patch at the same time as 3/3, so it'll give some time
to other people who want to take a look at it.
Thanks for the review!
next prev parent reply other threads:[~2015-12-20 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 23:41 Simon Marchi
2015-12-20 5:15 ` Joel Brobecker
2015-12-20 15:40 ` Simon Marchi [this message]
2015-12-21 12:48 ` Pedro Alves
2015-12-21 16:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFXXi0nLoxu8iT84GZ-KYzAL-RaUkGCZvYnJJ8t2SNZntV2Qtg@mail.gmail.com \
--to=simon.marchi@polymtl.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox