From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22979 invoked by alias); 28 Oct 2015 19:29:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22898 invoked by uid 89); 28 Oct 2015 19:29:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f47.google.com Received: from mail-qg0-f47.google.com (HELO mail-qg0-f47.google.com) (209.85.192.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 28 Oct 2015 19:29:37 +0000 Received: by qgad10 with SMTP id d10so15753570qga.3 for ; Wed, 28 Oct 2015 12:29:35 -0700 (PDT) X-Received: by 10.140.93.104 with SMTP id c95mr59224346qge.101.1446060575156; Wed, 28 Oct 2015 12:29:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.75.66 with HTTP; Wed, 28 Oct 2015 12:29:05 -0700 (PDT) In-Reply-To: <1446058487-22472-1-git-send-email-palves@redhat.com> References: <1446058487-22472-1-git-send-email-palves@redhat.com> From: Simon Marchi Date: Thu, 29 Oct 2015 12:43:00 -0000 Message-ID: Subject: Re: [PATCH] guile/: Add enum casts To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-10/txt/msg00667.txt.bz2 On 28 October 2015 at 14:54, Pedro Alves wrote: > In both cases the casts looks appropriate to me. In the > gdbscm_disasm_memory_error case, the status is marshaled through the > opcodes disassemble interface. In the > gdbscm_unwind_stop_reason_string case, the int comes from Guile. > > gdb/ChangeLog: > 2015-10-28 Pedro Alves > > * guile/scm-disasm.c (gdbscm_disasm_memory_error): Add cast. > * guile/scm-frame.c (gdbscm_unwind_stop_reason_string): Add cast. > --- > gdb/guile/scm-disasm.c | 2 +- > gdb/guile/scm-frame.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/guile/scm-disasm.c b/gdb/guile/scm-disasm.c > index 78b38df..0cc2f84 100644 > --- a/gdb/guile/scm-disasm.c > +++ b/gdb/guile/scm-disasm.c > @@ -133,7 +133,7 @@ static void > gdbscm_disasm_memory_error (int status, bfd_vma memaddr, > struct disassemble_info *info) > { > - memory_error (status, memaddr); > + memory_error ((enum target_xfer_status) status, memaddr); > } > > /* disassemble_info.print_address_func for gdbscm_print_insn_from_port. > diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c > index 24e26e8..55e0faf 100644 > --- a/gdb/guile/scm-frame.c > +++ b/gdb/guile/scm-frame.c > @@ -1045,7 +1045,7 @@ gdbscm_unwind_stop_reason_string (SCM reason_scm) > if (reason < UNWIND_FIRST || reason > UNWIND_LAST) > scm_out_of_range (FUNC_NAME, reason_scm); > > - str = unwind_stop_reason_to_string (reason); > + str = unwind_stop_reason_to_string ((enum unwind_stop_reason) reason); > return gdbscm_scm_from_c_string (str); > } > > -- > 1.9.3 > The status comes from gdbscm_disasm_read_memory returning TARGET_XFER_E_IO: return status != NULL ? TARGET_XFER_E_IO : 0; Does it make sense that this function returns TARGET_XFER_E_IO, and not just -1 (or any other non-zero value) on error? It's an all-or-nothing memory read function, unlike those of the xfer_partial interface. I would have done a change similar to what you have done in target_read_memory&co: make gdbscm_disasm_read_memory return -1 on error, and change memory_error (status, memaddr); to memory_error (TARGET_XFER_E_IO, memaddr); Would it make sense?