From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89050 invoked by alias); 29 Oct 2015 17:45:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89027 invoked by uid 89); 29 Oct 2015 17:45:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_SBL autolearn=ham version=3.3.2 X-HELO: mail-qg0-f52.google.com Received: from mail-qg0-f52.google.com (HELO mail-qg0-f52.google.com) (209.85.192.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 29 Oct 2015 17:45:11 +0000 Received: by qgad10 with SMTP id d10so40775598qga.3 for ; Thu, 29 Oct 2015 10:45:09 -0700 (PDT) X-Received: by 10.140.133.10 with SMTP id 10mr4241245qhf.95.1446140709427; Thu, 29 Oct 2015 10:45:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.75.66 with HTTP; Thu, 29 Oct 2015 10:44:40 -0700 (PDT) In-Reply-To: <563253F0.1050305@redhat.com> References: <1446123767-25046-1-git-send-email-simon.marchi@polymtl.ca> <1446123767-25046-2-git-send-email-simon.marchi@polymtl.ca> <563253F0.1050305@redhat.com> From: Simon Marchi Date: Thu, 29 Oct 2015 17:54:00 -0000 Message-ID: Subject: Re: [PATCH c++ 1/6] dwarf2read.c: Add cast To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-10/txt/msg00723.txt.bz2 On 29 October 2015 at 13:14, Pedro Alves wrote: > On 10/29/2015 02:57 PM, Simon Marchi wrote: > >>> --- a/gdb/dwarf2read.c >>> +++ b/gdb/dwarf2read.c >>> @@ -6854,7 +6854,7 @@ partial_die_full_name (struct partial_die_info *pdi, >>> struct dwarf2_cu *ref_cu = cu; >>> >>> /* DW_FORM_ref_addr is using section offset. */ >>> - attr.name = 0; >>> + attr.name = (dwarf_attribute) 0; >> >> Oops, here it should say (enum dwarf_attribute), so it works in C too. > > OK with that change. > > Thanks, > Pedro Alves Pushed everything except patch 2, thanks!