From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34776 invoked by alias); 29 Oct 2015 14:58:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34762 invoked by uid 89); 29 Oct 2015 14:58:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_SBL autolearn=ham version=3.3.2 X-HELO: mail-qk0-f182.google.com Received: from mail-qk0-f182.google.com (HELO mail-qk0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 29 Oct 2015 14:58:16 +0000 Received: by qkcl124 with SMTP id l124so14831124qkc.3 for ; Thu, 29 Oct 2015 07:58:14 -0700 (PDT) X-Received: by 10.55.75.87 with SMTP id y84mr2812946qka.56.1446130694327; Thu, 29 Oct 2015 07:58:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.75.66 with HTTP; Thu, 29 Oct 2015 07:57:44 -0700 (PDT) In-Reply-To: <1446123767-25046-2-git-send-email-simon.marchi@polymtl.ca> References: <1446123767-25046-1-git-send-email-simon.marchi@polymtl.ca> <1446123767-25046-2-git-send-email-simon.marchi@polymtl.ca> From: Simon Marchi Date: Thu, 29 Oct 2015 17:10:00 -0000 Message-ID: Subject: Re: [PATCH c++ 1/6] dwarf2read.c: Add cast To: gdb-patches@sourceware.org Cc: Simon Marchi Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-10/txt/msg00693.txt.bz2 On 29 October 2015 at 09:02, Simon Marchi wrote: > There is no enum value representing 0. It seems like the value of the > name field is irrelevant here. > > gdb/ChangeLog: > > * dwarf2read.c (partial_die_full_name): Add cast. > --- > gdb/dwarf2read.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > index d43c42e..baa288c 100644 > --- a/gdb/dwarf2read.c > +++ b/gdb/dwarf2read.c > @@ -6854,7 +6854,7 @@ partial_die_full_name (struct partial_die_info *pdi, > struct dwarf2_cu *ref_cu = cu; > > /* DW_FORM_ref_addr is using section offset. */ > - attr.name = 0; > + attr.name = (dwarf_attribute) 0; Oops, here it should say (enum dwarf_attribute), so it works in C too. > attr.form = DW_FORM_ref_addr; > attr.u.unsnd = pdi->offset.sect_off; > die = follow_die_ref (NULL, &attr, &ref_cu); > -- > 2.6.1 >