From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11466 invoked by alias); 25 Oct 2011 19:50:27 -0000 Received: (qmail 11455 invoked by uid 22791); 25 Oct 2011 19:50:26 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Oct 2011 19:50:12 +0000 Received: by faat2 with SMTP id t2so1169463faa.0 for ; Tue, 25 Oct 2011 12:50:11 -0700 (PDT) Received: by 10.223.85.139 with SMTP id o11mr53423500fal.0.1319572211270; Tue, 25 Oct 2011 12:50:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.22.6 with HTTP; Tue, 25 Oct 2011 12:49:51 -0700 (PDT) In-Reply-To: <83ipndc92n.fsf@gnu.org> References: <4E8DCE67.80507@earthlink.net> <4E92E639.7000402@earthlink.net> <83ipnjs9i1.fsf@gnu.org> <83ipndc92n.fsf@gnu.org> From: Justin Lebar Date: Tue, 25 Oct 2011 19:52:00 -0000 Message-ID: Subject: Re: Status of 'blacklist' patch? To: Eli Zaretskii Cc: dje@google.com, stanshebs@earthlink.net, gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00678.txt.bz2 > (If you have a function called @code{file} that you want to skip, use > @kbd{skip function file} to specify it.) I have no stake in the matter, but is this really such a common issue that it belongs in the manual? -Justin On Tue, Oct 25, 2011 at 12:47 PM, Eli Zaretskii wrote: >> From: Justin Lebar >> Date: Tue, 25 Oct 2011 12:08:09 -0400 >> Cc: dje@google.com, stanshebs@earthlink.net, gdb-patches@sourceware.org >> >> > What happens if I have a function called "file" in the same program? >> > IOW, to what degree is "file" a reserved keyword here? >> >> Even if you have a function named "file", |skip file| will skip the >> current file. =C2=A0But |skip function file| would skip the function cal= led >> "file". > > I suggest to say this explicitly as a note. =C2=A0E.g., like this: > > =C2=A0(If you have a function called @code{file} that you want to skip, u= se > =C2=A0@kbd{skip function file} to specify it.) > >> >> +@item Type >> >> +@samp{function} or @samp{file} >> > >> > The text below the @item line should be at least one complete >> > sentence. >> >> FWIW, I think >> >> =C2=A0 =C2=A0@samp{function} or @samp{file} >> >> beats >> >> =C2=A0 =C2=A0 This field contains either @samp{function} or @samp{file}, >> indicating whether >> the skip is on one function or all the functions in a file. > > I didn't suggest the latter; you did ;-) > > I will settle for > > =C2=A0The type of this skip, either @samp{function} or @samp{file}. > >> > @item Identifier >> > A number identifying this skip. >> >> This is not a complete sentence. =C2=A0Should it be changed as well? > > No need, it is complete enough for me. > > Thanks. >