Checked in, with two spaces after periods in comments.

Thank you for your patience!

-Justin

2011-10-06  Justin Lebar  <justin.lebar@gmail.com>

	* Makefile.in: (SFILES): Add skip.c.
	(HFILES_NO_SRCDIR): Add skip.h.
	(COMMON_OBS): Add skip.o.
	* skip.h, skip.c: New.
	* breakpoint.h (set_default_breakpoint): Remove.
	(get_sal_arch): Declare.
	* breakpoint.c: Remove default_breakpoint_valid,
	default_breakpoint_address, default_breakpoint_symtab,
	default_breakpoint_line, default_breakpoint_pspace variables.
	(get_sal_arch): Make public.
	(set_default_breakpoint): Remove.
	(parse_breakpoint_sals, create_breakpoint, clear_command,
	decode_line_spec_1): Remove uses of default_breakpoint variables;
	replaced with function calls into stack.c.
	* cli/cli-cmds.h: Add cmd_list_element *skiplist.
	* cli/cli-cmds.c: Add skiplist.
	(init_cmd_lists): Initialize skiplist.
	(init_cli_cmds): Fix comment (classes of commands appear in
	alphabetical order).
	* infrun.c (handle_inferior_event): Add check that we don't step into
	a function whose pc is marked for skip.
	* stack.c: Declare last_displayed_sal_valid, last_displayed_pspace,
	last_displayed_addr, last_displayed_symtab, last_displayed_line
	variables.
	(set_last_displayed_sal): New static function.
	(print_frame_info): Switch call to set_default_breakpoint to call to
	set_last_displayed_sal.
	(clear_last_displayed_sal, last_displayed_sal_is_valid,
	get_last_displayed_pspace, get_last_displayed_addr,
	get_last_displayed_symtab, get_last_displayed_line,
	get_last_displayed_sal): New public functions.
	* stack.h (clear_last_displayed_sal, last_displayed_sal_is_valid,
	get_last_displayed_pspace, get_last_displayed_addr,
	get_last_displayed_symtab, get_last_displayed_line,
	get_last_displayed_sal): Declare.

2011-10-06  Justin Lebar <justin.lebar@gmail.com>

	Add tests for skip command.
	* testsuite/gdb.base/skip-solib-lib.c: New
	* testsuite/gdb.base/skip-solib-main.c: New
	* testsuite/gdb.base/skip-solib.exp: New
	* testsuite/gdb.base/skip.c: New
	* testsuite/gdb.base/skip.exp: New
	* testsuite/gdb.base/skip1.c: New
	* testsuite/gdb.base/Makefile.in: Adding new files.


On Mon, Oct 31, 2011 at 7:23 PM, Stan Shebs <stanshebs@earthlink.net> wrote:
> On 10/31/11 6:28 AM, Justin Lebar wrote:
>>>
>>> Thanks, this version is ok.
>>
>> Is this final approval on the patch, or are we waiting on something else?
>
> I was going to say it was ready to go in, but then I noticed these in
> skip.c:
>
> +  /* Default to the current function if no argument is given. */
>
>
> We like to have two spaces after the period.  (Yes, it's borderline OCD, but
> we avoid source churn and confusing diffs if we prescribe this level of
> consistency.)
>
> There might be other things to fix, but at this point I think it's more
> efficient to push the code in and start getting it some real-world exercise.
>
>
>> If the former, how do I check in?
>
> Somebody else can commit it for you, but if you intend to be an ongoing
> contributor, you need an account on sourceware.org (see
> http://sourceware.org/ for instructions), and then set up a read-write
> checkout, per http://sourceware.org/gdb/current/ , and check in from there.
>
> Stan
> stan@codesourcery.com
>
>