From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12142 invoked by alias); 25 Oct 2011 16:09:27 -0000 Received: (qmail 12123 invoked by uid 22791); 25 Oct 2011 16:09:23 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Oct 2011 16:09:05 +0000 Received: by faat2 with SMTP id t2so900130faa.0 for ; Tue, 25 Oct 2011 09:09:04 -0700 (PDT) Received: by 10.223.5.201 with SMTP id 9mr53885610faw.5.1319558944234; Tue, 25 Oct 2011 09:09:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.152.22.6 with HTTP; Tue, 25 Oct 2011 09:08:09 -0700 (PDT) In-Reply-To: <83ipnjs9i1.fsf@gnu.org> References: <4E8DCE67.80507@earthlink.net> <4E92E639.7000402@earthlink.net> <83ipnjs9i1.fsf@gnu.org> From: Justin Lebar Date: Tue, 25 Oct 2011 16:47:00 -0000 Message-ID: Subject: Re: Status of 'blacklist' patch? To: Eli Zaretskii Cc: dje@google.com, stanshebs@earthlink.net, gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00659.txt.bz2 > What happens if I have a function called "file" in the same program? > IOW, to what degree is "file" a reserved keyword here? Even if you have a function named "file", |skip file| will skip the current file. But |skip function file| would skip the function called "file". >> +@item Type >> +@samp{function} or @samp{file} > > The text below the @item line should be at least one complete > sentence. FWIW, I think @samp{function} or @samp{file} beats This field contains either @samp{function} or @samp{file}, indicating whether the skip is on one function or all the functions in a file. > @item Identifier > A number identifying this skip. This is not a complete sentence. Should it be changed as well? -Justin On Thu, Oct 20, 2011 at 4:17 PM, Eli Zaretskii wrote: >> From: Justin Lebar >> Date: Sun, 16 Oct 2011 12:40:39 -0400 >> Cc: Stan Shebs , gdb-patches@sourceware.org >> >> Added a NEWS entry in this patch. > > Thanks. > >> +* GDB now allows you to skip over uninteresting functions and files when > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ^^^^^^^^^ > I think either "step over" or just "skip". > >> +@node Skipping Over Functions and Files >> +@subsection Skipping Over Functions and Files >> +@cindex skip > > This @cindex entry would be better if it just said what the subsection > name says: > > =C2=A0@cindex skipping over functions and files > >> +The program you are debugging may contain some functions which are >> +uninteresting to debug. =C2=A0The @code{skip} comand lets you tell @val= ue{GDBN} to >> +skip over a file or function when stepping. > > Again, I think this is better: > > =C2=A0... to skip a function or all functions in a file ... > >> +A more flexible solution is to execute @code{skip boring}. =C2=A0This i= nstructs > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^= ^^^^^^^^^^^^^^^^ > @kbd{skip boring}, since this is something the user types on the > keyboard. > >> +You can also instruct @value{GDBN} to skip all functions in a file, wit= h, for >> +example, @code{skip file boring.c}. > > What happens if I have a function called "file" in the same program? > IOW, to what degree is "file" a reserved keyword here? > >> +@table @code >> +@kindex skip >> +@kindex skip function > > No need for two @kindex entries here, the second one is enough. > >> +stepping. =C2=A0(@pxref{Specify Location}) > > Just @xref, and no parentheses, like so: > > =C2=A0@xref{Specify Location}. > >> +@item Type >> +@samp{function} or @samp{file} > > The text below the @item line should be at least one complete > sentence. > >> +being skipped. =C2=A0If you've set a function skip on a function which = has not yet >> +been loaded, this field will contain @samp{}. =C2=A0Once a sha= red library >> +which has the function is loaded, @code{info break} will show the funct= ion's > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^= ^^^^^^^^^ > I guess you meant "info skip", right? > > Okay with those changes. > > Thanks. >