Re: Status of 'blacklist' patch?

Justin Lebar
2011-10-25T16:09:27Z

> What happens if I have a function called "file" in the same program?
> IOW, to what degree is "file" a reserved keyword here?

Even if you have a function named "file", |skip file| will skip the
current file. But |skip function file| would skip the function called
"file".

>> +@item Type
>> +@samp{function} or @samp{file}
>
> The text below the @item line should be at least one complete
> sentence.

FWIW, I think

@samp{function} or @samp{file}

beats

This field contains either @samp{function} or @samp{file},
indicating whether
the skip is on one function or all the functions in a file.

> @item Identifier
> A number identifying this skip.

This is not a complete sentence. Should it be changed as well?

-Justin

On Thu, Oct 20, 2011 at 4:17 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Justin Lebar <justin.lebar@gmail.com>
>> Date: Sun, 16 Oct 2011 12:40:39 -0400
>> Cc: Stan Shebs <stanshebs@earthlink.net>, gdb-patches@sourceware.org
>>
>> Added a NEWS entry in this patch.
>
> Thanks.
>
>> +* GDB now allows you to skip over uninteresting functions and files when
>                           ^^^^^^^^^
> I think either "step over" or just "skip".
>
>> +@node Skipping Over Functions and Files
>> +@subsection Skipping Over Functions and Files
>> +@cindex skip
>
> This @cindex entry would be better if it just said what the subsection
> name says:
>
>  @cindex skipping over functions and files
>
>> +The program you are debugging may contain some functions which are
>> +uninteresting to debug.  The @code{skip} comand lets you tell @value{GDBN} to
>> +skip over a file or function when stepping.
>
> Again, I think this is better:
>
>  ... to skip a function or all functions in a file ...
>
>> +A more flexible solution is to execute @code{skip boring}.  This instructs
>                                          ^^^^^^^^^^^^^^^^^^
> @kbd{skip boring}, since this is something the user types on the
> keyboard.
>
>> +You can also instruct @value{GDBN} to skip all functions in a file, with, for
>> +example, @code{skip file boring.c}.
>
> What happens if I have a function called "file" in the same program?
> IOW, to what degree is "file" a reserved keyword here?
>
>> +@table @code
>> +@kindex skip
>> +@kindex skip function
>
> No need for two @kindex entries here, the second one is enough.
>
>> +stepping.  (@pxref{Specify Location})
>
> Just @xref, and no parentheses, like so:
>
>  @xref{Specify Location}.
>
>> +@item Type
>> +@samp{function} or @samp{file}
>
> The text below the @item line should be at least one complete
> sentence.
>
>> +being skipped.  If you've set a function skip on a function which has not yet
>> +been loaded, this field will contain @samp{<PENDING>}.  Once a shared library
>> +which has the function is loaded, @code{info break} will show the function's
>                                           ^^^^^^^^^^
> I guess you meant "info skip", right?
>
> Okay with those changes.
>
> Thanks.
>