Re: Status of 'blacklist' patch?

Tom Tromey
2011-10-28T19:48:07Z

>>>>> "Justin" == Justin Lebar <justin.lebar@gmail.com> writes:

One more note...

Justin> +int
Justin> +function_pc_is_marked_for_skip (CORE_ADDR pc)
Justin> +{
Justin> + int searched_for_sal = 0;
Justin> + struct symtab_and_line sal;
Justin> + char *filename = NULL;
Justin> + struct skiplist_entry *e;
Justin> +
Justin> + sal = find_pc_line (pc, 0);
Justin> + filename = sal.symtab->filename;

These last two lines should be removed.
They defeat the lazy computation scheme.

Justin> + sal = find_pc_line (pc, 0);
Justin> + filename = sal.symtab->filename;

I think sal.symtab can be NULL.

Tom