Re: Status of 'blacklist' patch?

Tom Tromey
2011-10-28T19:49:55Z

>>>>> "Justin" == Justin Lebar <justin.lebar@gmail.com> writes:

Justin> I'm sorry about all the formatting issues; it's hard to keep multiple
Justin> styles in my head at once! I need a set of git hooks to pester me, I
Justin> guess.

No worries, everybody struggles with this.
I wish we could define our style as the output of some tool; then we
wouldn't have to review for this at all. But AFAIK no tool comes close
enough.

>> Blank line between intro comment and the start of the function.
>> I think there are a few instances of this.

Justin> Only for function definitions, not declarations, right? I don't see
Justin> blank lines in breakpoint.h, for example.

I think so. Or at least I don't recall us agreeing on anything and the
code is already not very consistent.

Unfortunately I just noticed a different issue, so you'll need one more
spin. See my other mail.

Tom