Re: Status of 'blacklist' patch?

Stan Shebs
2011-11-02T23:52:56Z

On 11/2/11 3:42 PM, Maciej W. Rozycki wrote:
> This change broke the build of gdb.info:
>
> makeinfo --css-ref=../cs.css --split-size=5000000 --split-size=5000000 --split-size=5000000 -DHAVE_MAKEINFO_CLICK -I .../gdb/doc/../../readline/doc -I .../gdb/doc/../mi -I .../gdb/doc \
> -o gdb.info .../gdb/doc/gdb.texinfo
> .../gdb/doc/gdb.texinfo:4899: warning: `.' or `,' must follow @xref, not `I'.
> .../gdb/doc/gdb.texinfo:4857: `Skipping Over Functions and Files' has no Up field(perhaps incorrect sectioning?).
> .../gdb/doc/gdb.texinfo:4857: warning: unreferenced node `Skipping Over Functionsand Files'.
> makeinfo: Removing output file `gdb.info' due to errors; use --force to preserve.
> make[5]: *** [gdb.info] Error 1
>
> Also a ChangeLog entry is missing for changes to gdb.texinfo -- please fix
> that up.
>
> OK to apply the fix for the build errors below?

Yes, this is good. (I just bumped into it myself...)

Stan

>
> 2011-11-02 Maciej W. Rozycki<macro@codesourcery.com>
>
> gdb/doc/
> * gdb.texinfo (Skipping Over Functions and Files): Remove node
> designation. Fix "Specify Location" cross-reference.
>
> Maciej
>
> gdb-info-fix.diff
> Index: gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo
> ===================================================================
> --- gdb-fsf-trunk-quilt.orig/gdb/doc/gdb.texinfo 2011-11-02 21:25:50.000000000 +0000
> +++ gdb-fsf-trunk-quilt/gdb/doc/gdb.texinfo 2011-11-02 22:22:53.495572496 +0000
> @@ -4854,7 +4854,6 @@ proceed until the function returns.
> An argument is a repeat count, as in @code{next}.
> @end table
>
> -@node Skipping Over Functions and Files
> @subsection Skipping Over Functions and Files
> @cindex skipping over functions and files
>
> @@ -4896,7 +4895,7 @@ example, @code{skip file boring.c}.
> @itemx skip function @r{[}@var{linespec}@r{]}
> After running this command, the function named by @var{linespec} or the
> function containing the line named by @var{linespec} will be skipped over when
> -stepping. @xref{Specify Location}
> +stepping. @xref{Specify Location}.
>
> If you do not specify @var{linespec}, the function you're currently debugging
> will be skipped.
>