Re: Status of 'blacklist' patch?

Stan Shebs
2011-10-26T03:45:22Z

On 10/25/11 6:05 PM, Justin Lebar wrote:
> Rollup patch is attached, incorporating all feedback so far (I
> think!). As usual, you should be able to use interdiff to view the
> changes. Let me know if that doesn't work and I can make git spit it
> out.
>
> Unfortunately the tests are randomly failing on me. I'm not sure
> what's going on, but it looks like we're not always waiting long
> enough after runto_main, somehow.
>
> The relevant expect code (in gdb.base/skip.exp) is:
>
> if ![runto_main] { fail "skip tests suppressed" }
> send_gdb "step\n"
> # XXX This gdb_test sometimes fails, due to an apparent race.
> gdb_test "bt" "\\s*\\#0\\s+main.*" "step after all ignored"
>

You need a gdb_expect after the send_gdb, otherwise the output from the
step leaks into the next gdb_test and things get confused in the way
you're seeing. I would use gdb_test for the "step" also, it's much
simpler; send_gdb is only needed for unusual testing situations, and
this is not one of them. :-)

Stan