> If you update the patch and resubmit, I promise I'll give it a prompt > review. Deal. I've attached an updated patch, and it looks like gmail got the mime type right this time. :) > There's a lot of change of terminology from "default breakpoint" to > "displayed codepoint". I know we've debated better substitutes for > "breakpoint", but this patch is maybe not the best place to introduce one. How about "last displayed symtab and line"? That seems to be something which is meaningful. On Thu, Oct 6, 2011 at 1:33 PM, Tom Tromey wrote: > Just for future reference, I encourage everybody to ping a lot -- send a > ping once a week. In my experience, it feels like I'm being obnoxious > when I write the note, but it is a good way to get attention, and I > promise you nobody will be offended by it. Thanks; that's good to know. Different communities handle this sort of thing differently. Regards, -Justin On Thu, Oct 6, 2011 at 11:51 AM, Stan Shebs wrote: > On 10/6/11 7:07 AM, Justin Lebar wrote: >> >> I last pinged gdb-patches about the patch on May 16 and got no response. >> >> I imagine the patch has bitrotted by now.  I'd be happy to bring it up >> to date if there were a reasonable chance it would get reviewed this >> time. >> > > (It took a bit of digging to find the last version of the patch - I probably > missed it because the patch was attached as a binary, including the > changelog entry.) > > Anyway, I really like the concept, and "skip" seems like a good general term > for the functionality. > > I skimmed the April version, and noticed a few things to fix up. > > The file headers say things like "Header for GDB line completion.", which > I'm guessing is cut-n-paste from another file. :-)  Also it's now 2011, not > 2010. > > There's a lot of change of terminology from "default breakpoint" to > "displayed codepoint".  I know we've debated better substitutes for > "breakpoint", but this patch is maybe not the best place to introduce one. >  (Or I'm confused about what "codepoint" means, I didn't see a definition.) > > I didn't see a patch for the GDB manual, so I'm not sure of the intended > functionality details. > > If you update the patch and resubmit, I promise I'll give it a prompt > review. > > Stan > stan@codesourcery.com > > >