From: Uros Bizjak <ubizjak@gmail.com>
To: gdb-patches@sourceware.org
Cc: Alan Modra <amodra@gmail.com>, Richard Henderson <rth@redhat.com>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Subject: Re: [PATCH v2, alpha]: Handle single-stepping of atomic sequences
Date: Thu, 24 Nov 2011 09:21:00 -0000 [thread overview]
Message-ID: <CAFULd4YoafjwF2ReZKY-QbiTxY29-GhxVeKnJWF+G-1kLgOvCw@mail.gmail.com> (raw)
In-Reply-To: <CAFULd4ZZXmnvzEXMZ-GRpDeFkSwXTmm9p+Xoz5N9rsdb3xng8w@mail.gmail.com>
On Fri, Nov 18, 2011 at 1:18 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>
>> The gcc simulate-thread.exp testsuite exposed the problem in handling
>> of alpha atomic sequences. Single-stepping broke link in alpha's LL/SC
>> atomic sequences.
>>
>> Attached patch copies handling of atomic sequences from rs6000-tdep.c
>> and adapts the functionality for alpha.
>>
>> I don't have write access, so If OK, please someone commit this patch
>> to gdb CVS.
>
> [v2]: Since this patch is almost a copy of rs6000-tdep.c atomic
> sequence handling, also take into account proposed changes [1] to
> original rs6000 implementation.
>
> [1] http://sourceware.org/ml/gdb-patches/2011-11/msg00468.html
2011-11-24 Uros Bizjak <ubizjak@gmail.com>
* alpha-tdep.c (br_opcode): New.
(ldl_l_opcode, ldq_l_opcode, stl_c_opcode, stq_c_opcode): Ditto.
(alpha_deal_with_atomic_sequence): New function.
(alpha_gdbarch_init): Handle single stepping of atomic sequences
with alpha_deal_with_atomic_sequence.
[v3]: As suggested by Ulrich, handle all branch instructions inside
compare and exchange loop.
Re-tested on alphaev68-pc-linux-gnu, also with simulate-thread.exp
from GCC testsuite.
Uros.
next prev parent reply other threads:[~2011-11-24 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 22:47 [PATCH, " Uros Bizjak
2011-11-18 12:19 ` [PATCH v2, " Uros Bizjak
2011-11-24 9:21 ` Uros Bizjak [this message]
2011-11-24 12:37 ` Ulrich Weigand
2011-11-24 13:29 ` [PATCH v3, " Uros Bizjak
2011-11-25 17:09 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFULd4YoafjwF2ReZKY-QbiTxY29-GhxVeKnJWF+G-1kLgOvCw@mail.gmail.com \
--to=ubizjak@gmail.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=amodra@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox