From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102237 invoked by alias); 29 Jun 2016 15:30:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102220 invoked by uid 89); 29 Jun 2016 15:30:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f51.google.com Received: from mail-wm0-f51.google.com (HELO mail-wm0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 29 Jun 2016 15:30:27 +0000 Received: by mail-wm0-f51.google.com with SMTP id v199so186046559wmv.0 for ; Wed, 29 Jun 2016 08:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZYT7H5j+tVJtHumtF3FcvgATr0MfnmfFusivCjE6tNE=; b=kgoQAk2iURxG1HTm7rCEQDH06J7sB5+2mOYXtBzVRX7Eb57FPesbThJTP2Cgiriehq sSYmiX21GV3k5gAiEm8gvqX6q7AiJM98Nd7CPPwT6CxcGpGc1bc3KZPJ66uQk3w9Rn/B BD6ufGC4HVe3EAW/XhvCnOpTrQqZPHfk4fZa+UMeaL/23mH6rZU+CcXtbheWZvssmkYh tjCCJNZUeLeVo+ikXX/fK9/rCQ299ZLxD+mGeeQJKQMG1WkZMz/nT0nqU2fd2QNC2p3L E14iJZEKBvAnzjt/FTx4PlQz9yQ1VVa7pHOqVWEp65mx9JDOi22xTHeB0ipYtLFGxbAf Q55g== X-Gm-Message-State: ALyK8tL1SeBfru/MI7V8RAOBE+nfn71SecHPdgL0HDjM+tVv96Y0eRv5mbHlfUXzVz6cuz6cz4QH6AcqEppGFbss X-Received: by 10.194.109.232 with SMTP id hv8mr9215926wjb.115.1467214224480; Wed, 29 Jun 2016 08:30:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.36.215 with HTTP; Wed, 29 Jun 2016 08:30:23 -0700 (PDT) In-Reply-To: <096d4eba-1f36-1a1c-055e-331353293364@redhat.com> References: <096d4eba-1f36-1a1c-055e-331353293364@redhat.com> From: Manish Goregaokar Date: Wed, 29 Jun 2016 15:30:00 -0000 Message-ID: Subject: Re: [PATCH] Initialize strtok_r's saveptr to NULL To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00519.txt.bz2 Yipes, sorry about that. Copy-paste error :) -Manish On Wed, Jun 29, 2016 at 8:42 PM, Pedro Alves wrote: > On 06/29/2016 03:42 PM, Manish Goregaokar wrote: >> Fixed and pushed. > > Thanks. Please don't put the "gdb/ChangeLog:" lines in the > ChangeLog file though. :-) > >> >> Is this something we can fix in gcc? Pointer overflow is UB IIRC so >> + should never be null. Not sure if the >> compiler knows that this is positive though. > > I'd hope so. Was already working on a minimal reproducer. :-) > Filed a gcc bug now: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71699 > > Thanks, > Pedro Alves >